Among the 4 debian patches available in version 0.14.0+git20230912.76e1eee6-2 of the package, we noticed the following issues:
commit 0df76cbaf908150fc59b41ac04f258dcb359ea31
Merge: 5eacc66 aca4ade
Author: Xiyue Deng <manphiz@gmail.com>
Date: Fri Nov 29 20:12:34 2024 -0800
Merge from sid [dgit]
commit aca4ade2416a90a651e516cff12cabcea944719d
Author: Sean Whitton <spwhitton@spwhitton.name>
Date: Fri Jul 26 11:45:37 2024 +0900
Rebuild against dh-elpa 2.1.5
commit cd1c085185a71570601d501b516443ebdf1b790d
Merge: 326a1b4 3ba2cdf
Author: Aymeric Agon-Rambosson <aymeric.agon@yandex.com>
Date: Sun Oct 8 12:34:57 2023 -0300
Declare fast forward from 0.14.0+git20200603.5cbdbf0d-2
[dgit --quilt=gbp --overwrite]
commit 326a1b430c0d8e02df008a3d4cabe215441f6c05
Author: Aymeric Agon-Rambosson <aymeric.agon@yandex.com>
Date: Sun Oct 8 17:03:52 2023 +0200
Condition two tests that fail with emacs 29+
Those two tests error out during the functions yas-skip-and-clear-field or
yas-skip-and-clear-or-delete-char.
More specifically, during the call to yas-next-field, which is common to both
functions.
In emacs 28, upon the return from yas--skip-and-clear, the functions
yas-active-snippets and yas-current-field evaluated to non-nil, which guaranteed
yas-next-field to work without error.
This is not the case anymore with emacs 29 : on the return from
yas--skip-and-clear, both functions yas-active-snippets and yas-current-field
evaluate to nil, which makes yas-next-field to error out.
We disable both these tests in emacs 29+.
Upstream was notified (https://github.com/joaotavora/yasnippet/issues/1175)
Gbp-Pq: Name condition-tests-11-and-12.patch
commit f6fe26ccefc7449c0d08bcbd81d204e3919c1c7f
Author: Aymeric Agon-Rambosson <aymeric.agon@yandex.com>
Date: Sat Oct 7 00:21:25 2023 +0200
Repair major modes unit test
Forwarded: yes (https://github.com/joaotavora/yasnippet/pull/1174)
Two unit tests compare lists of major modes. However lisp-data-mode is
added twice, so the lists never compare as equal.
This is due to upstream commit 1ca316fb which adds lisp-data-mode despite the
fact that it is already there.
Gbp-Pq: Name repair-major-modes-unit-tests.patch
commit f46fede57df7d1da16fd6a96683d4b5bf501765a
Author: Aymeric Agon-Rambosson <aymeric.agon@yandex.com>
Date: Sun Jan 15 08:59:31 2023 +0100
Unbreak unit tests that failed due to trampoline compilation
Forwarded: https://github.com/joaotavora/yasnippet/pull/1158
The trampoline compilation of primitive buffer-list due to macro
yas-with-overriden-buffer-list makes three tests fail :
* 5/91 basic-jit-loading
* 6/91 basic-jit-loading-with-compiled-snippets
* 80/91 visiting-compiled-snippets
We aren't exactly sure why.
In the meantime, a quick workaround is to deactivate trampoline compilation
optimisation for this primitive.
Gbp-Pq: Name unbreak-other-unit-tests-(trampoline).patch
commit 880c69ea70038ce5c4389751089adb51d8e9a87a
Author: Aymeric Agon-Rambosson <aymeric.agon@yandex.com>
Date: Wed Dec 28 10:06:28 2022 +0100
Repair documentation build
Forwarded: https://github.com/joaotavora/yasnippet/pull/1156
The following form produces an error in emacs 28+ :
(replace-regexp-in-string "\\\\{[^}]+}"
(lambda (match)
(substitute-command-keys match))
"\\{yas-minor-mode-map}")
The yas--document-symbol function needs to be repaired.
Since command key substitution is done anyway in the next block, we can simply
remove it from the block that does org-example block enclosing.
Gbp-Pq: Name repair-documentation-build.patch
commit 3ba2cdfa3c0de84b054025b3a368b257814ee960
Merge: 0405c00 b7b604f
Author: Aymeric Agon-Rambosson <aymeric.agon@yandex.com>
Date: Sun Jan 29 17:21:41 2023 -0400
Record yasnippet (0.14.0+git20200603.5cbdbf0d-2) in archive suite sid
commit b7b604f7d978947c856f7bb8806fdbe287b4210a
Author: Aymeric Agon-Rambosson <aymeric.agon@yandex.com>
Date: Sun Jan 15 08:59:31 2023 +0100
Unbreak unit tests that failed due to trampoline compilation
Forwarded: https://github.com/joaotavora/yasnippet/pull/1158
The trampoline compilation of primitive buffer-list due to macro
yas-with-overriden-buffer-list makes three tests fail :
* 5/91 basic-jit-loading
* 6/91 basic-jit-loading-with-compiled-snippets
* 80/91 visiting-compiled-snippets
We aren't exactly sure why.
In the meantime, a quick workaround is to deactivate trampoline compilation
optimisation for this primitive.
Gbp-Pq: Name unbreak-other-unit-tests-(trampoline).patch
commit 348f205088ed3723f66cf2a8e0757f0b692840a4
Author: Philipp Stephani <phst@google.com>
Date: Mon Dec 6 18:50:10 2021 +0100
Unbreak unit tests under Emacs 28.
Origin: https://github.com/joaotavora/yasnippet/pull/1125
- Emacs 28 has a new mode ‘lisp-data-mode’ for Lisp data.
- A test that was temporarily broken passes again.
- The default for ‘org-adapt-indentation’ has changed.
Gbp-Pq: Name 0003-Unbreak-unit-tests-under-Emacs-28.patch
commit 0583c79a0544ef8b7eaceedeaa53ae44723b0a76
Author: Aymeric Agon-Rambosson <aymeric.agon@yandex.com>
Date: Wed Dec 28 10:06:28 2022 +0100
Repair documentation build
Forwarded: https://github.com/joaotavora/yasnippet/pull/1156
The following form produces an error in emacs 28+ :
(replace-regexp-in-string "\\\\{[^}]+}"
(lambda (match)
(substitute-command-keys match))
"\\{yas-minor-mode-map}")
The yas--document-symbol function needs to be repaired.
Since command key substitution is done anyway in the next block, we can simply
remove it from the block that does org-example block enclosing.
Gbp-Pq: Name repair-documentation-build.patch
commit e55cc4e8b4992c2b27c3782f2f88e3571576e774
Author: Nicholas D Steeves <nsteeves@gmail.com>
Date: Thu Nov 5 09:29:09 2020 -0500
Correct link to 'Eligible snippets' headline
Bug-Debian: https://bugs.debian.org/973152
Forwarded: https://github.com/joaotavora/yasnippet/pull/1081
Gbp-Pq: Name 0001-Correct-link-to-Eligible-snippets-headline.patch
commit ec3a524e2e624d77658c367244af1df900e2941e
Merge: 001a88c aa8a439
Author: Aymeric Agon-Rambosson <aymeric.agon@yandex.com>
Date: Sun Jan 29 17:21:41 2023 -0400
yasnippet (0.14.0+git20200603.5cbdbf0d-2) unstable; urgency=medium
* Team upload.
[ Aymeric Agon-Rambosson ]
* d/control : Remove elpa-org from Build-Conflicts: (does not fail build
anymore).
* d/control : Bump Standards-Version to 4.6.1 (no changes required).
* d/copyright : Update Source field.
* d/watch : update to version 4.
* Add unbreak-other-unit-tests-(trampoline).patch.
[ Sean Whitton ]
* Remove myself, Sean Whitton, from Uploaders:.
[ Aymeric Agon-Rambosson and Nicholas D Steeves ]
* Resolve all known causes of FTBFS related to building the documentation
(Closes: #1020143).
+ Add repair-documentation-build.patch.
+ Cherry pick 0003-Unbreak-unit-tests-under-Emacs-28.patch from an
upstream pull request to fix the tests: extra-modes-parenthood,
indent-org-property, and loading-with-cyclic-parenthood.
[dgit import unpatched yasnippet 0.14.0+git20200603.5cbdbf0d-2]
commit aa8a439b1adcab0286a4335007edb340e8a894fb
Author: Aymeric Agon-Rambosson <aymeric.agon@yandex.com>
Date: Sun Jan 29 17:21:41 2023 -0400
Import yasnippet_0.14.0+git20200603.5cbdbf0d-2.debian.tar.xz
[dgit import tarball yasnippet 0.14.0+git20200603.5cbdbf0d-2 yasnippet_0.14.0+git20200603.5cbdbf0d-2.debian.tar.xz]
commit 0405c00be049967432e54537578845712477d364
Author: Nicholas D Steeves <nsteeves@gmail.com>
Date: Thu Nov 5 09:29:09 2020 -0500
Correct link to 'Eligible snippets' headline
Bug-Debian: https://bugs.debian.org/973152
Forwarded: https://github.com/joaotavora/yasnippet/pull/1081
Gbp-Pq: Name 0001-Correct-link-to-Eligible-snippets-headline.patch
commit 001a88c7d6ed07c56a426312edfdfd08c461612c
Author: Sean Whitton <spwhitton@spwhitton.name>
Date: Thu Nov 5 11:31:38 2020 -0400
Import yasnippet_0.14.0+git20200603.5cbdbf0d.orig.tar.xz
[dgit import orig yasnippet_0.14.0+git20200603.5cbdbf0d.orig.tar.xz]
![[bug history graph]](https://qa.debian.org/data/bts/graphs/y/yasnippet.png){kind=link}