Among the 4 debian patches available in version 1.9.4+ds1-1 of the package, we noticed the following issues:
commit 88725752d5b6a8c8e1d4bd6042c50a6e363c1b84
Author: Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Date: Sun Nov 1 17:03:18 2026 +0100
d/copyright: record what upstream answered about the ext4 hash
commit ad2c2de1c7e608ee77c46ada3b9b9e095d4ed682
Author: Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Date: Sat Oct 31 21:03:59 2026 +0100
d/watch: follow the +ds1 repack suffix
Repacksuffix and Dversionmangle still said +ds, so uscan could not match
the packaged version and salsa's test-uscan job failed.
commit e8aaf0c8419e16b7ce6cba34c3682bedf2e91f58
Merge: ffe60ac 1ec9285
Author: Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Date: Sat Oct 31 20:42:07 2026 +0100
Merge the 1.9.4+ds-2 changelog that went to debian/sid
# Conflicts:
# debian/changelog
commit ffe60acef3772a8454464065e34abb3ddb91335b
Author: Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Date: Sat Oct 31 20:40:17 2026 +0100
d/changelog: release as 1.9.4+ds1-1
commit 3afc9205fea924cfff59c63e06e03e947ea3f113
Merge: deb5f6a 5e9dc0a
Author: Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Date: Sat Oct 31 20:40:08 2026 +0100
Update upstream source from tag 'upstream/1.9.4+ds1'
commit deb5f6a08503f99e33b25e4992003dd2f70a3e65
Author: Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Date: Sat Oct 31 20:39:42 2026 +0100
d/copyright: declare the real licence of the ext4 hash and of testhelper/docker.go
The ext4 directory hash in filesystem/ext4/dirhash.go and
filesystem/ext4/md4/md4.go is a transliteration of code by Theodore Ts'o
that the kernel ships under GPL-2.0, so it is not Expat. testhelper/docker.go
credits moby/tool, which is Apache-2.0. Also exclude a 5.5 MB squashfs image
that no generator script produces and no test reads.
README.source carries the reasoning and the upstream question.
commit 1ec9285e6f51fdc638e87cd7587cd6728b613bb5
Author: Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Date: Sat Oct 31 17:03:21 2026 +0100
d/changelog: release as 1.9.4+ds-2
dak refuses a second upload of 1.9.4+ds-1: its .dsc no longer matches the
one sitting in the NEW queue, which is the upload rejected on 27 October.
A new revision is the only way up until that one leaves the queue.
commit d182b3c594ad4f19a8b7851a5deaec95c19d0f3b
Merge: e6ca56c 8c772ff
Author: Simon Quigley <tsimonq2@debian.org>
Date: Wed Oct 28 15:20:11 2026 -0500
Merge branch 'wip/new-review-fixes' into 'debian/sid'
Make the test suite a real build gate, the NEW review points, and the 32 bit build
See merge request go-team/packages/golang-github-diskfs-go-diskfs!1
commit 8c772ffa05089befa97d1d228a3b47bbdcc8b05e
Author: Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Date: Tue Oct 27 20:31:05 2026 +0100
d/patches: the two 32 bit fixes are upstream now
Merged in https://github.com/diskfs/go-diskfs/pull/453 so both drop at the next
upstream release.
commit 5ebb866559e426c6ef59228cb67af2be5e181c41
Author: Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Date: Tue Oct 27 19:29:12 2026 +0100
d/patches: carry upstream's nolint on the timespec conversion
golangci-lint's unconvert fires on the conversion when the fields are already
int64, so upstream asked for the directive in https://github.com/diskfs/go-diskfs/pull/453
commit f14573b05b68783b5dbf804d01df23f118ff35b3
Author: Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Date: Tue Oct 27 18:33:47 2026 +0100
d/patches: type the DEADBEEF constant in the ext4 journal test
0xDEADBEEF does not fit in int on 32 bit and t.Errorf takes the constant
untyped, so the ext4 test package did not compile on i386. With this and the
timespec patch, GOARCH=386 go build ./... and go vet ./... are clean.
commit 01b87e2d7e08fe191881b7d63d63c3045b8e928e
Author: Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Date: Tue Oct 27 16:52:11 2026 +0100
d/patches: point the 32 bit fix at the upstream pull request
commit d4ea38c49679539a29794b3c0f9ab36173ac50e0
Author: Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Date: Tue Oct 27 16:41:00 2026 +0100
Fix the build on 32 bit architectures
unix.Stat_t.Atim.Sec and .Nsec are int32 on 32 bit Linux and time.Unix takes
int64, so the sync package does not compile there. GOARCH=386 go build ./sync/
reproduces it outside the package, and upstream master carries the same code.
commit 82f39c4975f6b3a5e4f99f31eb36fa2956e1d503
Author: Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Date: Mon Oct 26 03:08:51 2026 +0100
Fix the one test that the ignored exit status was hiding
TestTimeStamp's "not set" case inherits the SOURCE_DATE_EPOCH that dpkg
exports, so it compared the changelog date against time.Now().
commit 3b56a25ef50ebbc4ed81a9180201fe7eb15c4e40
Author: Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Date: Mon Oct 26 03:06:21 2026 +0100
d/control: build-depend on dh-sequence-single-binary
execute_after_dh_auto_install reads debian/<binary>, which is dh_auto_install's
destdir only while the single-binary addon is implicit. Compat 15 drops that.
commit d7faa697b0765ac894366a5b015d799e7fc693d3
Author: Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Date: Mon Oct 26 03:06:19 2026 +0100
Make the test suite a real build gate again
override_dh_auto_test ended in || true, so no failure could fail the build,
and the comment blamed the excluded mksquashfs binaries, which no test uses.
The tests that fail are ext4, fat32 and disk: they generate their image
fixtures with scripts that run inside docker, which a build chroot has not
got. The patch looks for docker and skips those, so every other failure is
a build failure again.
commit e6ca56ccb25aacc1a7e653d86e9b326fa4dea9a5
Author: Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Date: Sun Sep 27 22:37:37 2026 +0200
Depend on the module the library imports, not only build-depend on it
The -dev package listed it in Build-Depends only, so it built here but every
consumer failed: the sources installed under /usr/share/gocode import it, and a
module-aware build of anything that imports this library stops with "no required
module provides package". Found by the grype session's integration build.
Rebuilt: Status successful, Lintian successful.
commit 6650f74b1bdecbcce910d965075ee2004b5d60cb
Author: Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Date: Tue Sep 22 04:20:38 2026 +0200
Do not ship upstream's testdata .gitignore files
commit 94620e1d5c253a2866888049a805c0b22d2e259b
Author: Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Date: Tue Sep 22 04:03:59 2026 +0200
Fix lintian errors and release
commit 4e47f4556cbd07be2b1fc661a6ae42a8c87da6d7
Author: Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Date: Mon Sep 21 15:35:03 2026 +0200
Build-depend on the newly packaged dependency
commit bc663b73d7c4b4a74e13be51330ac8c0629ec7d7
Author: Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Date: Mon Sep 21 15:14:46 2026 +0200
d/changelog: record ITP bug 1148636
commit 4f0a9aacaaea220499d3e4bcdd496a76bcb0ea11
Author: Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Date: Mon Sep 21 10:00:03 2026 +0200
d/copyright: correct copyright holders to match upstream LICENSE
commit bbcabbbdb98889b739d4da95593e77d28a311cb5
Author: Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Date: Mon Sep 21 01:25:31 2026 +0200
Initial packaging targeting dh-go
![[bug history graph]](https://qa.debian.org/data/bts/graphs/g/golang-github-diskfs-go-diskfs.png){kind=link}