commit 12d4be2a5167cb479fd69ef3dc734e7c4db62180
Author: Nathan Scott <nathans@redhat.com>
Date: Mon Jul 27 18:52:40 2026 +1000
docs: updates to the changelog for pcp-7.2.0 release
commit d0e9316cb1ee78008edccddfc9fe064239a3353e
Merge: 6e81bfc6 cc942250
Author: Nathan Scott <nathans@redhat.com>
Date: Mon Jul 27 18:18:19 2026 +1000
Merge branch 'secure'
commit 6e81bfc663e50e2dcf50a8bfb2477eee6c6be7d6
Merge: 0c6ddfc6 b9b456da
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon Jul 27 13:35:50 2026 +1000
Merge pull request #2666 from kmcdonell/wip
QA fixups
commit b9b456da5daccd1734cfea30370529b7377bab96
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon Jul 27 12:24:16 2026 +1000
qa/common.check: fix comment for _require_linux_kernel_version()
commit dc3c58441d8621cee80127b9d8b2d2b0193ee087
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon Jul 27 12:04:01 2026 +1000
src/selinux/pcp.te: use optional_policy() for bpftrace PMDA allow
First use of type proc_t in this policy file, so be cautious, as
per @coderabbitai's suggestion.
commit 103009713b2f60a0f6bd0484d93f6d80d05d0f67
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon Jul 27 12:00:10 2026 +1000
qa/common.check: make diagnostics match function name for _wait_for_metric_value()
Thanks @coderabbitai.
commit 484072e034f0389d6bb3295d47bf2a0d99d7e82c
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon Jul 27 11:59:48 2026 +1000
qa/COOKBOOK.md: fix whitespace issue
commit 78b0cfdfdb62c8b57357d83758909995a35c51f5
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon Jul 27 11:31:51 2026 +1000
qa: refactor
1. harden _service() so the return value is always 1 for failure
and 0 means success, possibly with some warnings
2. rename _require_kernel_version() to be _require_linux_kernel_versio()
and enforce the "Linux" part with uname -s
commit 4c8e5888b2035ebbb46ccaab492e08ac9c25a583
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sun Jul 26 16:48:36 2026 +1000
qa/023 & 032: slight improvement for ! _service rewrite
Insert cat $tmp.tmp before _exit 1 ... so we get to see why _service
failed.
commit 5b1f5077237e4690d069ad158c36ef1d7f549f39
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sun Jul 26 15:20:42 2026 +1000
qa: add _wait_for_metric_value()
- added in common.check
- used in qa/1999 to stop racing after nixl PMDA's Install
- documented in COOKBOOK.md
We now have _check_metric(), avail_metric(), need_metric() and
_wait_for_metric_value() ... all similar, but subtly different ... 8^)
commit d81ad9f794ef98b1e1c983fcccf125685a17ad60
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sun Jul 26 07:34:40 2026 +1000
qa/1700 and 1705: add _require_kernel_version guards
On vm26 (x86_64 CentOS Stream9) we're seeing this text:
WARNING: Kernel version (5.14.0-710.el9.x86_64) is lower than the
minimum supported kernel version (5.15.0). Some features/scripts
may not work as expected.
in the value of the bpftrace.scripts.*.error
and bpftrace.info.scripts_json metrics.
Now these tests are _notrun on kernels older than 5.15.
commit 5df0ef834fceb7e8a026bce74c4dbb6534531fb5
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sun Jul 26 07:32:08 2026 +1000
src/selinux/pcp.te: more additions for the bpftrace PMDA
- group bpftrace PMDA stanzas together
- add a couple of allow clauses to avoid AVCs seen on vm26
(x86_64 CentOS Stream9) for multiple bpftrace PMDA QA tests
commit 1ab29048fdea352d90ec90fb9bbfb10367d5cbff
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sun Jul 26 07:27:36 2026 +1000
common.check: add _require_kernel_version
Actually promote and rename, so _pmdabpf_require_kernel_version()
is renamed _require_kernel_version() and moved from common.bpf to
common.check.
This is a useful helper function and on vm26 (x86_64 CentOS Stream9)
we're seeing a need for this in a couple of bpftrace PMDA tests.
COOKBOOK.md updates to match.
commit 2495f5b8cb587bbcfb64f1f404c5187b266a66be
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Jul 25 15:07:28 2026 +1000
qa/088: use -S to get past the (non-deterministic) start of the bar archive family
commit 43c73cea26ca9603f7be5a90bef6d16b5276a2de
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Jul 25 15:02:08 2026 +1000
qa/023: refactor if ! _service ...; fi | _filter...
As suggested by coderabbitai ... plan to apply this refactor on each
test as we commit it for other reasons, but 023 is just a trial run.
For reference, this pattern is kinda wrong ...
if ! _service pmcd start 2>&1; then _exit 1; fi \
| _filter_pcp_start
becuase the _exit 1 does not really do anything and certainly does not
abort the test.
This is better (avoid the subshell from the pipeline and
then the _exit really works):
if ! _service pmcd start >$tmp.tmp 2>&1; then _exit 1; fi
_filter_pcp_start <$tmp.tmp
commit 0c6ddfc653254750ec3bcde207f2ad8075e7a175
Merge: 74a4a4f6 9c8434d9
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Jul 25 13:06:02 2026 +1000
Merge pull request #2664 from kmcdonell/wip
QA fixups
commit 9c8434d9855377917d8775fb53e494dce555d761
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Jul 25 13:04:43 2026 +1000
qa/1998: fix _notrun guard
commit 4299c326a0e0a0d83b1c1be3de4d9bf6312ccb9d
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Jul 25 11:36:00 2026 +1000
qa/032: file's mode got lost in last commit
commit e4c8bd65a909fd49ee93dfe625a45b9296ef8cc7
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Jul 25 11:32:35 2026 +1000
qa/032 and qa/1998: fix a couple of small issues
Thanks @coderabbitai in the context of PR #2664.
commit 21c8b49d2bf1e12a7a95df60052c29d8515875c9
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Jul 25 08:57:54 2026 +1000
qa/032: explicitly restart pmlogger in _cleanup()
May fix some transient failures in the QA Farm.
commit 808d6ca32f0b7802ad6b2afbc5ea80b00f923db2
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Jul 25 08:09:19 2026 +1000
qa/023: change pmcd [access] clause to match src/agenttimeout.c
Changed access controls for pmStore and the pmcd PMDA meant
src/agenttimeout.c needed to create a pmNewContext using "local:"
rather than "localhost".
But this change needed to be reflected in qa/023 in the [access]
clause and the filtering (connection is now via a Unix domain socket,
not a TCP/IP port), which in turn trigeers remakes for 023.out.1 and
023.out.2.
commit 461610e9424be980566b1417bb2170a066529419
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Jul 25 07:42:39 2026 +1000
qa/src/chknumval.c and qa/043.out: change of metric
Change chknumval.c to use "mmv.control.reload" instead of
"pmcd.control.sighup" (in the default case) to dodge new access
controls for pmStore in the pmcd PMDA.
Triggered remake of qa/043.
commit 26ee10988fc579ac9ce26e8984a6fec0aab04d10
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Jul 25 07:11:25 2026 +1000
qa/1998: add _notrun guards, remove from qa/triaged
The comment in the test explains:
Based on smack-a-mole testing, it would appear that this PMDA is
only going to work in an AWS context where there is at least one
RDS endpoint.
This moves qa/1998 from failing+triaged to notrun *everywhere* in CI
and the QA Farm.
We really need the developers of the rds PMDA (Oracle) to step up to
the plate here and help us provision some QA environment that would
allow this PMDA to be tested.
commit 7159b3521e51b0ca943e779b7ee1daf34c41d5c3
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Jul 25 06:45:42 2026 +1000
qa/069: rework pmstore usage after increased "store" access controls in pmcd PMDA
Needed to change
sudo pmstore -h '$LOCALHOST_FULL' pmcd.control.debug ...
which will not work because it is run on a remote host aimed at
pmcd on the host where the QA test is being run and the access
controls bite early and break the test.
Replace this with
pmstore -h '$LOCALHOST_FULL' sample.write_me 42
which will work because the sample PMDA does not have the same
store access controls as the pmcd PMDA.
Actually setting pmcd.control.debug or not has no functional impact
on this QA test, we're just after *some* pmstore operation.
commit ae0bd998ba962149a76866da469d2c4850f24fb2
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Jul 25 06:32:12 2026 +1000
qa/273.out: remade after change to src/chknumval.c
localhost -> local: change in src/chknumval.c made one diagnostic
slightly different for qa/273.
commit 3adf02873e42f241ae961f8e87f314dee438d7d4
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Jul 25 06:28:04 2026 +1000
qa/272: remove pmstore that was not doing anything useful
Left over from a long-forgotten debugging session. Triggered a
remake of 272.out to match.
commit 74a4a4f6ddd8ad465f3377bc4575d72762aaec6c
Author: Nathan Scott <nathans@redhat.com>
Date: Fri Jul 24 10:47:49 2026 +1000
qa: resolve some remaining fallout from root pmcd.control stores
commit f5aed8644662a1d02f1888e7c3ea044d0d1f4cee
Merge: 5a21b213 31f701ba
Author: Ken McDonell <kenj@kenj.id.au>
Date: Fri Jul 24 09:00:54 2026 +1000
Merge pull request #2662 from kmcdonell/wip
QA and chrony PMDA fix
commit 31f701ba9c084b2785ff678c73d6bc3bcc11c62b
Author: Ken McDonell <kenj@kenj.id.au>
Date: Fri Jul 24 07:28:57 2026 +1000
qa/README.vm: improve package size calculation recipess for some less common platforms
commit 0cada16b66c79c580ed0ed7582a7a7d3d6d2cbda
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Jul 23 21:53:21 2026 +1000
qa/1721: tweak bpftrace version checks
Add _notrun for missing version of .bt file between $minver and $maxver
(currently there is no such missing version, but there could be in the
future).
commit 885c129aa8a72f723b98a9bddbce3e0c55af24d5
Merge: fab65ff2 5a21b213
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Jul 23 21:18:35 2026 +1000
Merge branch 'main' of https://github.com/performancecopilot/pcp
commit cc942250bf342dc5968afbba72c13409a6dd7655
Merge: b0765d46 3ae202a0
Author: Nathan Scott <nathans@redhat.com>
Date: Thu Jul 23 18:05:10 2026 +1000
Merge branch 'secure' of github.com:natoscott/private-pcp into secure
commit b0765d462d72d834a134fca7e839a659f0547b03
Merge: a9fa73d3 5a21b213
Author: Nathan Scott <nathans@redhat.com>
Date: Thu Jul 23 18:04:34 2026 +1000
Merge branch 'main' into secure
commit 5a21b21341c84633ddf54db2babf14448956315a
Merge: 3bb81926 dd68999a
Author: Nathan Scott <nathans@redhat.com>
Date: Thu Jul 23 17:48:31 2026 +1000
Merge branch 'agenticode-pr-labelset-leak'
commit dd68999ab6e091fa1ee73dcf2e11d076ff98ffaf
Author: Nathan Scott <nathans@redhat.com>
Date: Thu Jul 23 17:47:08 2026 +1000
libpcp: fix labelset leak on addlabel() error paths in __pmLogLoadMeta
When addlabel() returned an error the decoded labelsets from
__pmLogLoadLabelSet() were never freed — the existing cleanup only
handled PMLOGPUTINDOM_DUP. Widen the guard to free on any non-zero
return so ownership is correctly reclaimed on both duplicate and
error paths.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
commit caf30c32962156f97e4c5ae183a71881c8a277d2
Merge: 3bb81926 b610076e
Author: Nathan Scott <nathans@redhat.com>
Date: Thu Jul 23 17:31:18 2026 +1000
Merge branch 'pr-labelset-leak' of github.com:agenticode/pcp into agenticode-pr-labelset-leak
commit 3bb819268b158885a0ae918bf9a10910635e2f10
Author: Nathan Scott <nathans@redhat.com>
Date: Thu Jul 23 17:29:46 2026 +1000
qa, pmdapmcd: fixup cases of pmstore to pmcd.control needing root
Lots of places in QA required $sudo now when storing to pmcd.control
metrics - make it so. Also small cleanup to the pmcd.control metric
store logic regarding which metrics to apply EPERM checks to.
commit fab65ff2691cdcc9f4618cfb7b3cfd2bf2b5d22a
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Jul 23 17:09:21 2026 +1000
qa/common.check: add _stash_pmda_logs() function
Appends a PMDA's log file and any reference to the PMDA in pmcd's
log file to $seq_full. Most useful for failing tests when a PMDA
does not start or starts crippled.
Documented in COOKBOOK.md and used in a handful of tests that
have been failing in the QA Farm.
commit 15d363a7fedbfd050b35205b22d08460f4b43101
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Jul 23 17:08:45 2026 +1000
qa/README.vm: a little tweaking, nothing important
commit 74bc8c6e6abe9eb1876f8680fdd26ece8adc5b33
Merge: b2e279e9 f315b1d1
Author: Nathan Scott <nathans@redhat.com>
Date: Thu Jul 23 16:56:54 2026 +1000
Merge branch 'pmda_control_fix' of github.com:orasagar/pcp into orasagar-pmda_control_fix
commit b2e279e983512a8b8d01971141a98e03cd137259
Merge: 6e92a7c6 83cddd6e
Author: Nathan Scott <nathans@redhat.com>
Date: Thu Jul 23 16:43:40 2026 +1000
Merge branch 'lmchilton-pcp2openmetrics-timestamps'
commit 83cddd6ea6f888422ca9229cf3bb3ac82d784faf
Merge: 6e92a7c6 2b4bd598
Author: Nathan Scott <nathans@redhat.com>
Date: Thu Jul 23 16:42:52 2026 +1000
Merge branch 'pcp2openmetrics-timestamps' of github.com:lmchilton/pcp into lmchilton-pcp2openmetrics-timestamps
commit 7e6b1f2860ea382bb731ff3ea65329b0da99c1a0
Merge: 95d41f6b 6e92a7c6
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Jul 23 16:33:53 2026 +1000
Merge branch 'main' of https://github.com/performancecopilot/pcp
commit 6e92a7c6a972688ac7cfb25e7a98ebae51669e00
Author: Nathan Scott <nathans@redhat.com>
Date: Thu Jul 23 09:20:08 2026 +1000
qa: add chronyd test diagnostics for deb platforms
commit 95d41f6b568503baed0d3a99c8f1e67e73841799
Merge: c539a2ce 5258dbcb
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Jul 22 17:18:35 2026 +1000
Merge branch 'main' of https://github.com/kmcdonell/pcp
commit c539a2ce83b79ca11a261123ff55c5d08d53270e
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Jul 22 17:14:30 2026 +1000
src/pmdas/chrony/pmdachrony.python: the chrony user may not be "chrony"
On vm13 (MX 23.6) the user appears to be "_chrony".
Since there are no visible command line arguments for this PMDA I
cannot fix it in the Install script (which seems the right place),
so I've had to hard-code some alternative logic into the PMDA's Python
code.
With these changes qa/1686 is magically passing on vm13.
commit 5258dbcb279cc41e6a42e1510973922407486d80
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Jul 22 17:14:30 2026 +1000
src/pmdas/chrony/pmdachrony.python: the chrony user may not be "chrony"
On vm13 (MX 23.6) the user appears to be "_chrony".
Since there are no visible command line arguments for this PMDA I
cannot fix it in the Install script (which seems the right place),
so I've had to hard-code some alternative logic into the PMDA's Python
code.
With these changes qa/1721 is magically passing on vm13.
commit ed884a828d628bac8bfa3646e363ab8cb4a554d1
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Jul 22 17:12:56 2026 +1000
qa/1686: add some useful diagnostics to $seq_full
Specifically the PMDA's log file and relate lines from pmcd's
log file.
commit ab04682ec474d9d8a71f75f75ac5adbd0e4e29a3
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Jul 22 16:58:42 2026 +1000
qa/1721: smarter handling of bpftrace versions
and longer timeouts for slow VMs.
commit c4c1e7cf339faabe86e4207ec3773d581dad2ae9
Merge: 58dd97fc 9a9be68f
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Jul 22 16:36:02 2026 +1000
Merge branch 'main' of https://github.com/performancecopilot/pcp
commit 58dd97fc3058cdf6fed9263d7e38c7efcf486282
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Jul 22 16:35:07 2026 +1000
qa/1999: increase timeouts and gather more triage info
commit 9a9be68f2b1404e43659ce54fa769b4a30f0739b
Merge: f0c99d89 ffe5ba43
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Jul 22 16:12:02 2026 +1000
Merge pull request #2660 from kmcdonell/wip
QA fixups and selinux changes for chrony PMDA
commit ffe5ba430bcd36a79fc2d78391665b05822e7a7b
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Jul 22 06:26:40 2026 +1000
src/selinux/pcp.te: fix syntax error in last commit
commit 70d064e7b5af7d231d1e8c7ba986f818a7554f9f
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Jul 22 06:18:38 2026 +1000
src/selinux/pcp.te: guard kernel_io_uring_use() macro use
@coderabbitai suggestion to avoid build failure on RHEL 7
(and older) where kernel_io_uring_use() is not defined.
commit a20b68e8476740d98f692e5628c09396c731ca67
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Jul 22 05:49:43 2026 +1000
qa/common.check: small _triage_wait_point() change
As suggested by @coderrabbitai in the context of PR #2660, I had missed
setting the "$here/" prefix for the wait file on the no arguments code
path ... fortunately this is usage of _triage_wait_point() rare (maybe
never?) and not very useful in practice.
commit 3ad3f0686b1a892706a15645a52464e0e9f46ee2
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Jul 22 05:42:40 2026 +1000
src/selinux/GNUmakefile: don't make | grep
As pointed out by @coderrabbitai in the context of PR #2660 it is a bad
idea to use the construct
$(MAKE) ... | grep
in a makefile rule because the result (as far as make is concerned)
moves from the exit status of $(MAKE) to the exit status of grep.
Simply dropping the | grep part of the rule is the right fix.
We are already catching and culling these triaged (not-a-PCP-issue)
selinux build warnings in scripts/cull-build-warnings.
Same change in src/selinux/import/GNUmakefile
commit f315b1d1ed29c4ea4a9957e60505efe6cb84c5fb
Author: Sagar Sagar <sagar.sagar@oracle.com>
Date: Tue Jul 21 09:56:23 2026 +0000
qa/1746: added test root-only pmcd control stores
commit cecb1ff160e48ddb3cf94d05c3571880f95283ae
Author: Ken McDonell <kenj@kenj.id.au>
Date: Tue Jul 21 17:06:50 2026 +1000
src/selinux/import/GNUmakefile: same filter change as parent GNUmakefile
commit d1f61f23051e01978398c16f814d8883d1641810
Merge: 8fc7f247 f0c99d89
Author: Ken McDonell <kenj@kenj.id.au>
Date: Tue Jul 21 08:23:43 2026 +1000
Merge branch 'main' of https://github.com/performancecopilot/pcp
Conflicts:
src/selinux/GNUmakefile
Resolved diffs.
commit 8fc7f247282391a3e4248a6aecb5fb34da8c6819
Author: Ken McDonell <kenj@kenj.id.au>
Date: Tue Jul 21 08:05:07 2026 +1000
src/selinux/pcp.te: multiple fixups: kernel_io_uring_use() and chrony PMDA
1. on RHEL 9.8 the construct
ifdef(`kernel_io_uring_use', ...)
fails because the interface is defined but it expands to use
io_uring_t which is not defined ... this involves a fair amount of
digging starting with
$ sudo semodule -X 200 -i pcp.pp
Failed to resolve typeattributeset statement at /var/lib/selinux/targeted/tmp/modules/200/pcp/cil:118
Failed to resolve AST
semodule: Failed!
replace the ifdef() with optional_policy() [like we use elswhere
for other interface uses] seems to fix this.
2. there were a stack of extra AVCs from qa/1686 and the chrony PMDA
... it took several iterations before I stopped seeing new AVCs
so I suspect there are multiple code paths in this PMDA and their
execution while running qa/1686 is not deterministic, so repeated
runs see potentially different AVCs
Also tidied up the GNUmakefile to remove duplicate definitions Warnings
that are caused by other people's policies and have nothing to do with
PCP.
commit f0c99d89479d3d77833f87be633e32e7217adf8a
Author: Nathan Scott <nathans@redhat.com>
Date: Mon Jul 20 16:20:23 2026 +1000
pcp-atop: fix systemd service for changed logdir path
commit 3b90369a6c6404145a99525455456714cee88264
Author: Nathan Scott <nathans@redhat.com>
Date: Mon Jul 20 13:49:25 2026 +1000
build: prepare for next weeks pcp-7.2.0 release
commit 891a42a4ec6671419582e9309abe5b6262734786
Author: Nathan Scott <nathans@redhat.com>
Date: Mon Jul 20 13:48:58 2026 +1000
docs: fix pcp-import-benchmarks description pluralism
Resolves Debian bug #1142200
commit 776df2ca67bc117a98b00056ad60ff6424c0efc2
Merge: 3f35be65 d25126c9
Author: Nathan Scott <nathans@redhat.com>
Date: Mon Jul 20 13:31:39 2026 +1000
Merge commit 'd25126c9c1731eb22c304d9e7af5c9404e1c7856' into htop-merge
commit d25126c9c1731eb22c304d9e7af5c9404e1c7856
Author: Nathan Scott <nathans@redhat.com>
Date: Mon Jul 20 13:31:39 2026 +1000
Squashed 'vendor/github.com/htop-dev/htop/' changes from 1579d02a5e..d4297a41b2
d4297a41b2 Extend man page to include a External Libraries section on libnl-3 / libnl-genl-3
255b014c7a Merge pull request #2047 from ABHIRAMSHIBU/feature/zswap-meters
fdf6309c2d Add zswap pool usage meters
53207de160 Disable NetBSD build for now as their cdn sends partial files breaking the build consistently
671df7975b Update version to 3.6.0-dev. Again.
393b224603 Update Changelog, Release 3.5.2
d0c5072686 Merge branch 'fix/issue-1982-systemdmeter-newline' of dengzhongyuan365-dev/htop
eb9859a6f4 Merge pull request #2046 from winklemad/fix-reset-on-fork-flag
4dc18e7c7e Scheduling: OR in SCHED_RESET_ON_FORK instead of ANDing it
a97ad96d18 Add comment on why snprintf instead of xSnprintf (omit error handling)
5d870936e3 Merge branch 'fix/issue-1991-trace-fork-error-feedback' of re2zero/htop
f7e79f97f2 Merge branch 'fix-cpumeter-segfault' of fasterit/htop
bf8cc6e85e Merge branch 'linux-zram' of eworm-de/htop
bdf4ffc15e linux: fix reading zram values
5839bca117 systemd: fix SystemdMeter parsing when falling back to systemctl show
1ef42260c4 Merge pull request #2034 from BenBE/ci-sec-fix
81ed8c1664 Merge pull request #2033 from crocidb/main
73cf23cff8 Address review feedback from @Explorer09
bf9d40f9d3 Don't persist credentials when cloning the repository for CI
afd5974915 Unified indentation style
ede50e5dd8 Replace apt-key by signed-by repo spec for clang
b174af9b15 freebsd: unifying buffer/cache memory usage for all filesystem cache
080461baa5 Use consistent CI job naming
b233e88243 Update CI to use $(...) subshell syntax
f137d5a736 Merge pull request #2028 from add-uos/main
bcbebfe156 desktop: add trailing semicolon to Keywords and expand keyword list
7ff5716515 Merge pull request #2010 from BenBE/remove-openvz
90369a4912 Remove obsolete OpenVZ and VServer support
287df38a19 Reduce default token permissions
254da5566b Merge pull request #2027 from htop-dev/dependabot/github_actions/actions/checkout-7
978b76e577 Bump actions/checkout from 6 to 7
f85df099e1 Merge pull request #2026 from ugolnikovE/issue-1992
f0d2b7e151 linux: add M_EPSS column (effective proportional set size)
6f86c5f8e9 Housekeeping: Make count, start, ncol unsigned, removes lots of casting
143147ebf1 Fix segfault when vCPUs are hot-added: resize AllCPUsMeter data->meters array on CPU count change
e9518b3320 PgDown -> PgDn for consistency (introduced in 87c2f29a)
3896cb87e6 Merge pull request #2021 from BenBE/sticky-follow
87c2f29aa8 Introduce sticky_follow setting
c05187cc69 Unfollow when moving cursor
d66df1f567 Show error message when trace feature fails on fork
98be31b2bd Merge pull request #2020 from BenBE/fork-exit-fixes
99f456b83b Merge pull request #2019 from BenBE/openrc-bugfix
dcee86f939 Avoid memory leak on error when listing open files
81fcd80aaa Simplify interrupted waitpid handling
6e833bc5e1 Properly terminate forked process for TraceScreen
1dc64b55d9 Avoid running atexit handlers for forked children
ca8e1c80e7 Split runlevel and service count queries
224748653b Merge pull request #2017 from BenBE/security-process
3a002219ce Merge pull request #1976 from natoscott/fix/macos-memory-used-calculation
e7409e80e5 Skip displaying service counts if both values are missing
b9f4aa0424 Use size_t for count tracking
af145094f8 Refactor Row_printRate to scale units with a loop
7709c12b42 Formalize security process
3af3426923 Merge pull request #2015 from natoscott/fix/darwin-mach-port-leak
76a0c21839 darwin: fix Mach port leak in DarwinProcess_scanThreads()
ac2cdeeb56 Merge pull request #1999 from MatthewLavine/main
2cc93218ec linux: resolve actual executable path for Flatpak processes
008c621e67 Merge pull request #2008 from nikhilwankhedee/main
a75e9011f9 Handle unavailable OOM scores as N/A
af53de40ba darwin: fix used memory calculation to match Activity Monitor
git-subtree-dir: vendor/github.com/htop-dev/htop
git-subtree-split: d4297a41b285374336ae860afe5b5c16128f9f87
commit 739e5abdb0da519ebd47da40db2eb115e77b7629
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon Jul 20 13:24:52 2026 +1000
qa/988: make order of xfs metrics deterministic
Same fix as previously applied for qa/987.
commit 3f35be653cc8849960c93eb458ecb17a93521940
Merge: f7668761 327acb76
Author: Nathan Scott <nathans@redhat.com>
Date: Mon Jul 20 13:22:17 2026 +1000
Merge branch 'pcp-selinux-import'
commit f7668761a6ac2c9db497ab3ae7b0bb22089446c2
Author: Nathan Scott <nathans@redhat.com>
Date: Mon Jul 20 13:21:52 2026 +1000
docs: otel QG, fix incorrect stray pcp2openmetrics reference
Minor formatting fixes (don't use '&' as its special in html escape
sequences, and informal). Add a short note about the PMWEBAPI(3)
opentelemetry exporting via /metrics API.
commit acbcb9b9fba675e893fbe19d592e6c5cc78a13d5
Merge: 19781879 8b4bb3ed
Author: Nathan Scott <nathans@redhat.com>
Date: Mon Jul 20 13:14:46 2026 +1000
Merge branch 'otel-QG' of github.com:lmchilton/pcp into lmchilton-otel-QG
commit 6d09501d47874936d3f42a3d67e2566ead795e49
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon Jul 20 13:01:41 2026 +1000
qa/1307, 1438 and 1471: more filtering for odd fstat() issue
Same problem and same fix as was previously triaged for qa/1290.
I now believe this line:
Warning: invalid file descriptor -1 in syscall fstat()
comes from valgrind on x86_64 RHEL 9.8 and (some versions) of x86_64
Ubuntu 26.04 ... the non-valgrind "dual" tests don't show the warning,
only the valgind variants do.
commit 4d82eaeb1ad3d0a3bdf345a8916ba20ea83a252f
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon Jul 20 13:00:01 2026 +1000
qa/README.vm: extend the documentation and hints a little
Specifically one-liners to answer the question "which installed
packages are using the most disk space?".
commit b9c400b925881d04519e83aa32d64bdbbd713ad9
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon Jul 20 11:44:56 2026 +1000
qa/1290: filter away odd fstat() warning
commit a9fa73d3ba2d24f9a6a0374b82936e7145cd2794
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Jul 11 11:26:38 2026 +1000
libpcp: fix integer overflow in __pmGetPDU() (CWE-190)
When php->len is near INT_MAX (e.g. 0x7FFFFFFF), the buffer size
computation PDU_CHUNK * (1 + php->len / PDU_CHUNK) overflows signed
int, producing a negative value that permanently corrupts the static
maxsize variable. Every subsequent __pmFindPDUBuf() call returns NULL,
rendering the affected daemon (pmlogger, pmcd) unable to process any
further PDUs for the remainder of its lifetime — a persistent denial
of service requiring a restart.
The overflow is reachable from ANY_SIZE callers including the SASL/AUTH
handshake path in secureserver.c, which accepts unauthenticated PDUs
without the LIMIT_SIZE ceiling check.
Fix: add an overflow guard (php->len > INT_MAX - PDU_CHUNK) before
the multiplication, returning PM_ERR_TOOBIG for absurdly large PDU
lengths. This protects all code paths regardless of size mode.
Also add _filter_pmcd() to qa/common.pmcd.pdu to normalize fd=N in
pmcd log output, and qa/2105 with a crafted PDU exercising the
overflow.
Reported-by: Francisco Alisson Bezerra, TIM Security Red Team
Reported-by: Lucas Gabriel Alves, TIM Security Red Team
Reported-by: Massimiliano Brolli, TIM Security Red Team
Reported-by: Keith Linneman, LinnemanLabs
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
commit 03326c6fba087994f898d537d57283ff153f0d35
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon Jul 20 06:49:00 2026 +1000
qa/common.check: tweak for _triage_wait_point()
If filename is given, look for it in $here, just like the default
$seq.wait.
commit c169fc22b8cf1cc74f04bee5f59a0ff3d5fcb501
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon Jul 20 06:45:00 2026 +1000
qa/987: make xfs PMNS deterministic
The xfs metric names order seems to have some dependency on directory
order for the "fake" stats files ... take control and make the order of
metrics to be fetched deterministic.
Also added per-tarball _triage_wait_point using $seq.wait.$iter.
commit 72d7ac1afd36877e69793d3acd03dda0924c975e
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sun Jul 19 17:20:21 2026 +1000
bpftrace PMDA QA: small tweaks
- fix typo in common.bpftrace diagnostic
- rework logic in 1721 to track biolatency.bt being replaced by
multiple versions of this file
commit f0fa359a52bcd1f81e46457d6e411778bbe1803c
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sun Jul 19 16:48:22 2026 +1000
qa/check: correct accounting for callback failures
commit b610076e7d56080846a844c583d223ecdab3aa78
Author: agenticode <16611333+agenticode@users.noreply.github.com>
Date: Sat Jul 18 15:41:58 2026 +0000
libpcp, pmproxy: fix unbounded memory growth from duplicate label records
addlabel() appends every label record presented to it onto the
per-(type, ident) chain in the archive context's label hash, with no
duplicate detection. This is unlike the sibling metadata paths:
addindom() and __pmLogAddDesc() both reject records that duplicate one
already stored (addindom() even documents why: identical indoms "very
common in multi-archive contexts"). Labels get the same duplicate
records but keep every copy for the life of the context.
pmproxy's discovery presents the same label records repeatedly during
normal operation:
- when an archive is first discovered, __pmLogLoadMeta() (called from
pmNewContext()) loads all label records into the context, and then
process_metadata() re-reads the same records from the .meta file and
adds them again via pmDiscoverInvokeLabelsCallBacks();
- pmlogger_daily rollover and multi-archive contexts re-present the
same records with identical (type, ident, timestamp, content).
Because discovery contexts are long-lived, the duplicate pmLabelSets
accumulate without bound. Observed on PCP 7.1.5 as pmproxy RSS climbing
~62MB -> 1.8GB over six days (roughly doubling each night at the
rollover) until the process aborted under memory exhaustion and was
restarted by systemd at an ever-higher baseline; valkey stayed flat, so
the growth was entirely in the daemon. bcc memleak attributed ~30MB of
outstanding allocations per 30-minute window to __pmLogLoadLabelSet()
reached via process_metadata(), ~150x the equivalent (de-duplicated)
indom path.
Give addlabel() the same exact-duplicate rejection addindom() has: when
an incoming labelset matches an existing entry at the same timestamp
(same instances, label counts and JSON payload), free the wrapper and
return PMLOGPUTINDOM_DUP. The two callers that own the decoded labelsets
on a non-store outcome -- __pmLogLoadMeta() and
pmDiscoverInvokeLabelsCallBacks() -- free them on the duplicate return,
mirroring how __pmLogLoadMeta() already disposes of a duplicate indom's
payload. Only byte-for-byte redundant records are dropped, so no
context's effective label state changes; a genuine label change at a
later timestamp is a different time slot and is preserved.
A standalone reproduction that re-presents one context labelset to
__pmLogAddLabelSets() 30000 times goes from +8832 kB RSS (301 bytes each,
0 rejected) before this change to +0 kB (1 stored, 29999 rejected) after.
commit 19781879556216ab36eb6a5a0c1eb138a05281bc
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Jul 18 08:12:07 2026 +1000
qa/common.bpftrace: bpftrace PMDA needs even longer to start on vm03
15sec was not enough, bump to 30sec and now qa/1721 is passing.
commit 81a89ff40dfc36bfcd2ef9716830466e5a57aeda
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Jul 18 07:44:33 2026 +1000
bpftrace PMDA: examples and QA
Following feedback from Viktor Malík (the bfptrace maintainer @
RedHat) over at https://github.com/performancecopilot/pcp/issues/2609
the examples and QA have been reworked.
1. a new script (Download) to download versions of these scripts from
github and apply the Andreas Gerstmayr transformation to produce
something the bpftrace PMDA can use
2. package a version of biolatency.bt and runqlat.bt for each version
of bpftrace that is known to github (currently 20 .. 26)
3. update qa/1721 to pick the right version of the *.bt script
4. update qa/1721 to expect either 4 or 5 tracepoints (not 3)
5. remade qa/1721.out
Thanks Viktor.
commit 59969c45212da8fd62bcbd36a060301f7704cdb6
Author: Sagar Sagar <sagar.sagar@oracle.com>
Date: Fri Jul 17 11:50:19 2026 +0000
pmcd: restrict control metric stores to root users
Require root credentials when writing privileged pmcd control metrics to prevent unauthorized runtime configuration changes.
commit 327acb76c6d38cc0035e6111a9b51b16e1d4bd6b
Author: Nathan Scott <nathans@redhat.com>
Date: Fri Jul 17 14:00:25 2026 +1000
selinux: add pcp-import policy module for local context recording tools
Add a new SELinux policy module (pcp-import) for PCP tools that operate
in PM_CONTEXT_LOCAL mode without pmcd — loading DSO PMDAs directly and
writing PCP archives via libpcp_import. This covers pcp-atop and
sysstat's sadc (with -O pcp), and provides a reusable pcp_import_t
domain for future import tools.
The pcp-import module is independent of the existing pcp-selinux
package (which covers pmcd/pmlogger/pmproxy/pmie) and works when only
pcp-libs is installed. The sysstat_t domain from the base targeted
policy is augmented via optional_policy when sysstat is installed.
Rename PCP_IMPORT_DIR to PCP_IMPORTRUN_DIR for clarity (/run/pmimport
status files) and add PCP_IMPORTLOG_DIR (/var/log, base directory for
import tool archives). pcp-atop uses PCP_IMPORTLOG_DIR/atop for its
daily archives.
New pcp-selinux-import RPM subpackage, weak-required by pcp-libs when
selinux-policy-targeted is installed.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
commit 4529a26eb4cb04c9359dd94dcd3e5e81c3f3a3a6
Author: Nathan Scott <nathans@redhat.com>
Date: Fri Jul 17 09:58:34 2026 +1000
chrony PMDA: review fixes, packaging, SELinux policy, and QA tests
Code fixes (pmdachrony.python):
- Broaden exception handling to catch OSError, ValueError, IndexError,
AssertionError, and TimeoutExpired in addition to CalledProcessError
- Add timeout=1 to subprocess.run() calls (well under pmcd 5s timeout)
- Remove unused PMDA_FETCH_NOVALUES import
- Fix typos: "refrence", "Resitual", "iInterval", "souces"
- Fix pylint: use enumerate() instead of range(len())
- Add CHRONYC env var override for chronyc path (enables QA testing)
- Add set_user("chrony") for chronyd socket access, guarded for
non-root and test contexts
- Pre-populate instance domain on init to avoid "unknown instance"
warning on first pmval fetch
- Fix metric units: use dimensionless pmUnits for identifiers, strings,
stratum, poll, reach, and ppm frequency values (not PM_COUNT_ONE)
- Fix semantics: sources.last_rx and sources.reach use PM_SEM_INSTANT
Man page (pmdachrony.1):
- Remove stale "Copyright (c) 2014 Red Hat" from template
- Add chronyc(1) and chronyd(8) to SEE ALSO
SELinux (pcp.te):
- Allow pcp_pmcd_t to execute chronyc_exec_t (optional policy)
Packaging:
- Add pcp-pmda-chrony to build/rpm/pcp.spec.in and redhat.spec
(package declaration, file manifest, package list, preun, files)
QA:
- New test 1685: deterministic dbpmda test with fake chronyc and
canned data using RFC 5737 documentation IPs (no PII)
- New test 1686: Install/Remove integration test via pmcd
- Add qa/chrony/ test data directory with fake chronyc script
- Add chrony to qa/GNUmakefile and qa/GNUmakefile.install SUBDIRS
- Add chrony to qa/common.filter (PMDA name, instance, PMNS filters)
- Add chrony entries to qa/group
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
commit 4ac53a1b138cc294b33dda24565999c763ec6a38
Merge: 36f9def6 cc1479ed
Author: Nathan Scott <nathans@redhat.com>
Date: Thu Jul 16 16:36:03 2026 +1000
Merge branch 'chrony' of github.com:jeffpc/pcp into jeffpc-chrony
commit 36f9def68e3b6333edd9407c91a03eaa1bae9e96
Merge: 7bd44703 59c9b221
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Jul 16 09:06:03 2026 +1000
Merge pull request #2656 from kmcdonell/wip
packaging (Debian and tarball) and multiarch path fixups (Debian)
commit 59c9b2213326e474eaf4558dc30ba7646ab933a3
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Jul 16 07:51:05 2026 +1000
build/tar/postinstall.tail: tweak test for ldconfig -m option
commit 8aacd877b688931fff574165610873197421c1fc
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Jul 16 07:24:31 2026 +1000
libpcp*/src/install-dev: coderabbitai-suggested fixups
1. one script and make others symlinks (hard links are not preserved by
git apparently)
2. harden the error checking in the script
commit 3b1019d7c9b977a2f0d9419558f327d204c266fb
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Jul 15 19:38:28 2026 +1000
debian packaging: fixups
- /run/pmimport installed via tmpfiles, not packaged
- pcp-dstat lintian changes
commit a8b0cf95d2a652ca96b9389e0625fb53e0082fdb
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Jul 15 14:30:31 2026 +1000
debian/control.pcp: fix Breaks: and Replaces: for libpcp-import2-dev
Needs to refer to libpcp-import1-dev.
commit 40e1ac32beeb94ab4f770aa20fa860ed56daaa91
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Jul 15 14:08:15 2026 +1000
debian/pcp-htop.install: cull bogus etc/pcp/htop/* entries
Correct usr/share/pcp/htop entries were already present.
commit de03719323c6d9050d74e0d066ee8183e920cba6
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Jul 15 14:04:31 2026 +1000
debian/pcp-export-zabbix-agent.install: match multipath renaming
The Debian packaging ecosystem sees the zbxpcp.so DSO's below
/usr/lib and wants to move 'em to the correct multipath directory.
Make the pathnames glob-match the renamed paths, same as was done
for all the libpcp<foo> libraries.
commit 903b5d3dd689c96552712cc0f88e50fe2001f006
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Jul 15 13:58:45 2026 +1000
Debian build: rework for multiarch changes
Revert parts of commit 10f01ad75.
Conditionally installing based on $DEB_HOST_MULTIARCH was wrong.
Install into $PCP_LIB_DIR (e.g. /usr/lib) and let the Debian build
ecosystem deal with the path renaming to install libraries below
$PCP_LIB_DIR/$DEB_HOST_MULTIARCH.
commit 60b58ef841cd9bbf521c34856015c2c30f03eea1
Merge: a15c03af 7bd44703
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Jul 15 12:10:23 2026 +1000
Merge branch 'main' of https://github.com/performancecopilot/pcp
commit a15c03af8faa042c840d40b5f5051db3a6efeca1
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Jul 15 10:47:17 2026 +1000
src/libpcp*/src/install-dev: rework
1. mv rather than cp, so we don't end up with turds in /usr/lib that are
not part of any PCP package
2. add -d (debug flag) to report key variable assignments
3. expand coverage to include pkgconfig files that are also not where
"sudo make install" puts them
Note: all the 9 files are hard links to the same script, so realy only
one set of changes here.
commit 8b4bb3edd33e2f8f62676400024bc2e7ab175f5c
Author: lmchilton <lauren.chilton26@gmail.com>
Date: Wed Jul 8 11:05:51 2026 -0400
New OpenTelemetry QG
commit 7bd44703feb840bd38f1a72ee49f08580e5d6f27
Author: Nathan Scott <nathans@redhat.com>
Date: Tue Jul 14 16:32:00 2026 +1000
build: drop /run and import.conf for pmimport debs
commit 103deb2a59a98198795cc1f4cd06f37ea26cc5d3
Author: Nathan Scott <nathans@redhat.com>
Date: Tue Jul 14 11:04:11 2026 +1000
ci/macos: pre-upgrade pkg-config to avoid brew bundle lock race
brew bundle runs parallel installs (HOMEBREW_DOWNLOAD_CONCURRENCY=6)
and the pkg-config upgrade races with python-setuptools install since
both need the pkgconf cellar path, causing a lock conflict. Upgrade
pkg-config before brew bundle so it's already current.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
commit 6d5e514b32c918a5e003ef5aa4f354b968778b2c
Merge: b8d356cd 230550e2
Author: Ken McDonell <kenj@kenj.id.au>
Date: Tue Jul 14 10:59:49 2026 +1000
Merge branch 'main' of https://github.com/performancecopilot/pcp
commit 230550e29370ad77d77fa71b7c7ce1593d457557
Author: Nathan Scott <nathans@redhat.com>
Date: Tue Jul 14 10:52:20 2026 +1000
ci/macos: fix brew bundle race and Homebrew 6.x tap trust warnings
The GitHub Actions macOS runner image has pre-installed third-party
taps (aws/tap, hashicorp/tap, azure/bicep) and background brew
upgrade processes that race with our brew bundle step.
Replace the fixed sleep with a wait loop for background brew
processes to finish, and untap unused third-party taps to avoid
Homebrew 6.x tap trust warnings (HOMEBREW_NO_REQUIRE_TAP_TRUST
is deprecated and will be removed).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
commit c04675a2aa2936fa8d8ae33ddb248d137ce5c6a2
Author: Nathan Scott <nathans@redhat.com>
Date: Tue Jul 14 10:25:18 2026 +1000
qa/statsd: fix test 1713 broken by pminfo -e flag change
The -e flag was repurposed from unused to --metadata-errors, which
enters verify mode and suppresses normal fetch output. Revert
07.py back to utils.print_metric() to match the expected output.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There are 4 open security issues in bookworm.
You can find information about how to handle these issues in the security team's documentation.
![[bug history graph]](https://qa.debian.org/data/bts/graphs/p/pcp.png){kind=link}