vcswatch reports that
this package seems to have new commits in its VCS but has
not yet updated debian/changelog. You should consider updating
the Debian changelog and uploading this new version into the archive.
Here are the relevant commit logs:
commit effc00474111bf5dff1297dd3c6811c1fdf6b6ca
Author: Florian Schlichting <fsfs@debian.org>
Date: Thu Mar 23 22:14:41 2023 +0100
use "." to concatenate strings, not "+" (fixes #288)
Unsupported operand types: string + string at /usr/share/davical/inc/caldav-ACL.php:146
commit 72b13cfc655668338b9df8df24ae674e968465aa
Author: Florian Schlichting <fsfs@debian.org>
Date: Mon Mar 13 22:18:04 2023 +0100
gitlab-ci.yml: add missing phpunit, awl to targets running debuild
we now require this for "make test"
commit 4301a795ac7a7636846bcc15348d96c68a1830fd
Author: Florian Schlichting <fsfs@debian.org>
Date: Mon Mar 13 21:56:13 2023 +0100
release davical 1.1.12
commit ab8953081944a3b6aadf53c6e874deb87a951a67
Author: Florian Schlichting <fsfs@debian.org>
Date: Mon Mar 13 21:56:13 2023 +0100
add Debian autopkgtests
commit 477425f3fe1575b9a5385b3397203378cd58c683
Author: Florian Schlichting <fsfs@debian.org>
Date: Mon Mar 13 21:56:13 2023 +0100
Fix phpunit tests ('Attempt to read property "rrule_loop_limit" on null') and add them to 'make test'
commit b40c96debb6a45e515038a491294f86669efbc5d
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Mon Feb 6 19:53:44 2023 +1300
If time-range is set, only return matching events.
Closes #280
commit 4a2db83b7cca9721599ca120bc60a02aea18689f
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Mon Feb 6 11:24:45 2023 +1300
Update ChangeLog
commit 15d01c8bed2d0f7bc201c896694ab383bd970162
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Mon Feb 6 00:15:32 2023 +1300
Store DTSTART and DTEND from user in shadow columns
We want to store the calculated dtstart and dtend in the database so we can
use SQL to fetch records. However, we also need what the user sent us so we
can allow prop-filters to be used as well.
So we store what the user sends us in dtstart_orig and dtend_orig and only
use for relevant prop-filter reports.
commit 5a739914963e78464e03631f6a1e2f9b93cdc23d
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Sun Feb 5 14:20:42 2023 +1300
DTSTART on VTODO is optional, don't force it to be set.
If we force setting DTSTART, then you can't use prop-filter to find VTODOs
with a DUE set and DTSTART unset. And, well, why should DTSTART be set to DUE?
This was introduced in 18150d702d91fa1a687801baa582d967e79fff8d .
commit badeca53c73002784415e006f6228ce450f60ac7
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Sun Feb 5 01:35:34 2023 +1300
Update tests that check for CLASS in the database.
We no longer force CLASS to be PUBLIC in the database if it isn't set.
commit 149ec3555f49a4bff7943f3f625d878b0f20a580
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Sun Feb 5 01:32:16 2023 +1300
CLASS is an optional field, don't set it to PUBLIC
As specified in RFC5545 the CLASS field is optional, and if it isn't present
is treated as PUBLIC. To allow a is-not-defined prop-filter to find
resources without CLASS set, we need to not store in the database. This
turns out to be okay, because to enforce privacy we always check to see if
it is PRIVATE or CONFIDENTIAL. We never check to see if it is PUBLIC.
Closes #284.
commit 4a380b12a2544952247387073ba9da4652f2741f
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Sat Feb 4 18:38:17 2023 +1300
Fixes to is-defined and is-not-defined prop-filter
Gosh, this was completely broken previously. A number of different scenarios now work.
I have used some of the state I've seen in a largish production database with the
presence of NULL and empty strings. I've assumed that empty string should be treated
as is-not-defined. Happy to be talked out of that.
Closes #281.
commit 7349944fbc01e00910bfddedc5282021f6824a22
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Sat Feb 4 17:11:03 2023 +1300
Remove change entry in file, that's what git history is for
commit 13c77fdcabe280e3e6e1687368bb527e2a8b49b0
Author: Piotr Filip <6465816-piotrfilip@users.noreply.gitlab.com>
Date: Wed Oct 19 13:45:45 2022 +0200
check owner when deleting
commit 4b7abbbd831403bf3c4f0f67857c87e1ec4ec0ca
Author: Florian Schlichting <fsfs@debian.org>
Date: Sun Feb 26 20:49:32 2023 +0100
drop default $position argument from BuildXMLTree everywhere (awl!22)
commit 8fbab49f0ddba24bb0c81db2c8cebdcc2dca5433
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Sat Feb 4 21:33:08 2023 +1300
Create unique constraints for tmp_password and role_member.
commit e3b5c331be4a4525e5728ffe336c628b59eb33fb
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Sat Feb 4 21:22:57 2023 +1300
Add a primary key to calendar_alarm table.
Also fixed a bug in scripts/refresh-alarms.php if there was an
alarm with a duplicate trigger.
This is part of the fix for #276.
commit 6819d6d7d159f0100330e469be7ca9c2776be9b4
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Sat Feb 4 20:26:21 2023 +1300
Add a primary_key to the addressbook_addresses_* tables
This is part of the fix for #276.
commit c3970f3be2e5018305d8536a35ccad7f27831065
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Tue Feb 7 00:45:45 2023 +1300
Fix RRULE for BYHOUR, BYMINUTE and BYSECOND
Closes #283.
commit 8444347b02bf9d94712461fd545dc6945254c167
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Mon Feb 6 19:42:36 2023 +1300
We no longer support PHP 5.1, assume that DateTime is available
commit 43996a32975becfdc2fdbd3693727434ee0c25a5
Author: Andrew Ruthven <puck@catalyst.net.nz>
Date: Fri Feb 18 21:54:35 2022 +1300
Create .in and .out calendars on principal creation.
Closes #227
commit 0041577fc83b3c21bf7e38a1546948d19a66255a
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Mon Dec 19 23:26:28 2022 +1300
Handle baseDNGroups being unset.
commit 444a098130b6a753492d6c5e737f6fc9bee90302
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Sat Feb 4 15:14:43 2023 +1300
Ensure that groups_nothing_done is defined
Closes #278.
commit f86eaef5b8ea98c961befdc77a78273e2d8fcd61
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Sat Feb 4 15:05:39 2023 +1300
Use dbg_error_log instead of dbg_log_array
Closes #277.
commit be60ec177820b8e6740372af7445ae8bbee8ada3
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Sat Feb 4 15:33:25 2023 +1300
Improve on SQL syntax fix to keep logging working, and add regression test.
Closes #279.
commit 6e6ff6b1156d5fa0691b5996cf8a5f191d89f227
Author: Tobias Brox <tobias@redpill-linpro.com>
Date: Sat Jan 28 08:56:38 2023 +0100
Fix SQL syntax error if is-not-defined is used as a prop-filter.
commit 533d407196b872e9e12d54cea26e74037503123a
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Sun Jan 8 12:10:05 2023 +1300
Update ChangeLog
commit 0762022453aa1a3accee852d705d11b50f6e84bb
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Sun Dec 18 13:49:52 2022 +1300
Depend on AWL 0.64 to get fixed memcache support
commit 0da12be223da5ad897ebf875006a690a91f3af12
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Sun Dec 18 02:10:09 2022 +1300
Stop caching bound collections.
This was causing binding/1038-PROPFIND-Depth-2 to fail as the getctag that
was found didn't match what was expected. Looking at how bound collections
are handled, there is a lot of metadata that we're missing.
Preferably we'd cache or otherwise restore that metadata, but I'm going
to leave that as a future enhancement. ;)
commit ad1be4b640b491973b0fad573e7def65a15fb6c4
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Sun Jan 8 12:08:44 2023 +1300
Add CI for memcache
commit 0cb7381c8818b4deb06c9163dbff6f795b7351d8
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Sat Dec 17 01:44:29 2022 +1300
Keep track of proxy information for a Collection when using memcached
The test regression-suite/0549-iCal-REPORT was failing due to us not
keeping track of the proxy information when storing/fetching collections
from the cache.
commit 7a3486563cb8fff8fc0788c11af348bf11c77595
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Sat Dec 17 00:20:43 2022 +1300
Only cache a Principal if we've actually loaded something.
commit 5db0622d6528d406fd390003d7fa70e07f7ae98c
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Fri Dec 16 23:58:24 2022 +1300
Provide example configuration on using memcache.
commit 0c2f55cd6635c80d2b7e41f6322b474e9323f135
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Sun Jan 8 12:11:42 2023 +1300
Update the ChangeLog for my fixes over the past week
commit 713f8dafdff9d053f38c34b5b651ed04e57a5f0a
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Tue Dec 20 00:21:31 2022 +1300
Copy the log artifacts into unique directories per test
commit a054d1639091e7edf67deab97efac16041a62495
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Mon Dec 19 23:07:27 2022 +1300
Mass tidy up of whitespace in sample config.
commit c9ac75173b30b13e73a2ec358fad13327f8cc04f
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Mon Dec 19 23:04:27 2022 +1300
Allow the tester to hit N or n to continue
commit 2791d7b8c38d739e84ef59257a394e6d32532b10
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Sun Jan 8 12:11:42 2023 +1300
Update the ChangeLog for my fixes over the past week
commit 6abf645d00efcae6b5a3c01237d0a8066a811cd2
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Fri Dec 30 17:41:11 2022 +1300
Fix minor typo
commit a323ba8dae7a9cf7254787f882e3524d168dd418
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Thu Dec 15 18:08:12 2022 +1300
Don't change the day of the month to 28, if it is > 28
Gosh. The logic was saying, if the modified date has a day of the
month > 28, change it to 28. Which is rather odd. Don't do that.
This closes #248. It also fixes a bug with FREQ=MONTHLY;BYMONTHDAY=-1
as it turns out.
commit 6e68c221e93ce19a07314f0fada4c97798970aa7
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Thu Dec 15 18:04:53 2022 +1300
Add more logging to investigate the 28th problem on issue #248
I reckon this is useful logging to have, keep it around.
commit 7d0e2f2435c4d16406679554f79a211084b84a79
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Thu Dec 15 09:49:49 2022 +1300
Test Free/Busy results for MONTHLY with BYMONTHDAY
Tests https://gitlab.com/davical-project/davical/-/issues/248
commit 64f47fd9e6fb75098dd4501133e1ccc3f15070e2
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Thu Dec 15 09:39:54 2022 +1300
Tests for MONTHLY recurrence where DTSTART is on the 29th of Feb
Each of the recurring events should also be on the 29th. Currently
these tests fail as the generated events are on the 28th. Oops.
commit 7b2fa34f7343beb84ce7c38d556d53ccadb8be5b
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Sat Dec 17 22:00:04 2022 +1300
Reenable N being a default
commit 45c74a628b35da35087ddd68c788c35283d2fbcf
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Sat Dec 17 14:54:48 2022 +1300
Improvements to run_regressions.sh options
* Add q to quit
* Loop if an invalid command is entered, instead of continuing
As part of this I converted the large if/elif/elif/.../fi to a case
statement, a bit easier to read.
commit 7a8c7b5b2596f1c6176db459e9a3611dc1db35ed
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Thu Dec 15 11:05:46 2022 +1300
Convert loop_limit to a config item
commit 513db6b8d19966c58c43fc85a98b212261a64bb5
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Wed Dec 14 20:24:41 2022 +1300
Remove a stray space
commit d93a5196b858e31d42d9ade3c4838036df65637c
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Wed Dec 14 20:22:49 2022 +1300
Increase loop limit for finding next instance for Recurrence Rules.
With complex rules, it make take more than 10 expansions to find the
next valid date. Increase this to 100, it doesn't slow things down too
much.
I've also added some additional error logging if this issue occurs
again.
Closes #268.
commit 0fdb3ff5585239ff7372254a87911bb99b3258a8
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Wed Dec 14 20:20:36 2022 +1300
Add more logging to try and find the root cause for issue 268
commit 3909ec52f13ae12a0e8e4276e6726245e07837c2
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Wed Dec 14 13:59:54 2022 +1300
Convert RRule debugging to use dbg_error_log
This stops the debugging from being sent to stdout, which goes to the client and
mucks up the test results.
commit 80102c270083c4c953b9201404f9ebcc9f01e123
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Wed Dec 14 10:27:02 2022 +1300
initial tests for issue 268
commit a5d19142bb5f1ed78cf5149f08301e8c746e5a9c
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Thu Dec 15 22:56:47 2022 +1300
Fix typo
commit 0750dd27a18a5efa96a933c1988f57bb75530787
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Thu Dec 15 15:09:17 2022 +1300
Another test result to update
commit 3c1d39ff8520f294bc0ef6c533b7e76c1f484423
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Wed Dec 14 23:58:49 2022 +1300
Ensure the test suite exists before operating on it.
I kept on making typos, so ended up with random directories, this should
stop that from happening in future.
commit fc09febad28b17b1dc76ac300d32d0ec27b0dca6
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Wed Dec 14 09:52:35 2022 +1300
Update tests now that we don't inherit the DB from previous directory
commit 692c20eec6a6767272b57b98582e07d5c298e63a
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Tue Jun 28 23:29:36 2022 +1200
Don't inherit DB from previous test set
commit f29af801160ac7f0e543781a492f339fd97ed8e9
Author: Piotr Filip <6465816-piotrfilip@users.noreply.gitlab.com>
Date: Wed Oct 19 12:15:13 2022 +0200
delete collection by id
commit abbb6e5e70c3ec96a74f1299f02c5989efe8041a
Author: Bill McGonigle <bill-gitlab.com-20170608@bfccomputing.com>
Date: Wed May 11 20:58:53 2022 +0000
support php_fpm under Apache 2.4 (missing PATH_INFO with Apache handler).
commit 7d2bbeb37c8dbfcb85b4f22be6609f2222d4e67d
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Tue Dec 13 12:41:39 2022 +1300
Update regression tests that hit index.php for new CSP
commit ffe5ed24adf23407b8f5e753a511794b3fab3701
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Tue Dec 13 11:44:39 2022 +1300
Add Content-Security-Policy header to sample Apache2 config files
We now support running with a strict self CSP, let's provide that!
commit 35641b099a1d7baa70d3c5313c377d0648966559
Author: Piotr Filip <6465816-piotrfilip@users.noreply.gitlab.com>
Date: Wed Oct 19 11:06:20 2022 +0200
refactor scripts to allow operation with Content-Security-Policy: script-src 'self'
commit 43bda7a5ba1518e455dd2618f799828f75e69775
Author: ruliane <ruliane+github@ruliane.net>
Date: Sat Oct 22 11:38:35 2022 +0000
Fix error when $icfg is not set.
commit 19ec6fd2fb06d79e6ca2ea5032f64585bd7e49e4
Author: ruliane <ruliane+github@ruliane.net>
Date: Sat Oct 22 11:41:05 2022 +0000
Fix PHP Notice: Undefined variable: body in /usr/share/davical/inc/iSchedule.php on line 435
commit a9d438dc0fc4c0949bfc4387e970fc9fe4d8a65a
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Sat Dec 10 14:13:08 2022 +1300
The PHP 8.2 container has deflate enabled in Apache2, disable it.
This is causing a test to fail because we're being sent a gzip compressed
result. My reading of the curl manpage says that it should be decompressed
by curl, but it isn't. Let's just disable the deflate module. Here is what
we're getting:
Displaying diff for test 0548-iCal-PROPFIND
=======================================
--- tests/regression-suite/0548-iCal-PROPFIND.result 2022-12-10 00:43:52.898403110 +0000
+++ tests/regression-suite/results/0548-iCal-PROPFIND 2022-12-10 00:45:11.378242838 +0000
@@ -1,1233 +1,12 @@
-HTTP/1.1 207 Multi-Status
+HTTP/1.1 200 OK
Date: Dow, 01 Jan 2000 00:00:00 GMT
DAV: 1, 2, 3, access-control, calendar-access, calendar-schedule
DAV: extended-mkcol, bind, addressbook, calendar-auto-schedule, calendar-proxy
-ETag: "ae8aac5229a8a5d9ee7c86100322162d"
-Content-Length: 28703
-Content-Type: text/xml; charset="utf-8"
+Content-Encoding: gzip
+Content-Length: 2042
+Content-Type: text/html; charset=UTF-8
commit 042237b05d84c7fef7867ed66530a3afc4e74ad7
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Sat Dec 10 03:44:24 2022 +1300
PHP 8.2 seems to set the timezone to UTC, always set Pacific/Auckland for testcases
Previously the logic only set Pacific/Auckland if the date.timezone setting
on the PHP ini files wasn't set. Let's just always set it if we're processing
the test suite.
commit 6ad794eae62ecb23195efa05eec4fedfd7b223d4
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Sat Dec 10 01:48:29 2022 +1300
freq_name is only used locally
This doesn't need to be an object field.
commit aab8ddfd3078506205c6dd6b5cd8531bb5678b1f
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Sat Dec 10 01:47:50 2022 +1300
Ensure that all fields are defined, not added dynamically.
PHP 8.2 deprecates dynmically adding properties. See:
https://php.watch/versions/8.2/dynamic-properties-deprecated
commit 46feee1ec7f5d7b46275acf5402579bed2d69239
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Sat Dec 10 01:10:25 2022 +1300
Stop copying all fields from the Principal object.
PHP 8.2 deprecates dynmically adding properties. See:
https://php.watch/versions/8.2/dynamic-properties-deprecated
This arbitary copying of all fields tickles these deprecation
warnings, and just below we copy exactly the fields we need.
I reckon this loop is redundant.
commit 8162b9f8506507c19125d82e8dc3bb2b98f15434
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Sat Dec 10 01:07:52 2022 +1300
Ensure that propfind for access is deterministic.
I noticed that the ordering of principals returned wasn't deterministic
for tests. Ensure it is.
commit c904ef555120756cd3358d66419dd6fb70a49b1f
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Fri Dec 9 23:47:42 2022 +1300
Debian Unstable no longer has bzip2 by default, use xz instead
commit 547c78c48f4237265820691898e9e4c7e1297cba
Author: Andrew Ruthven <andrew@etc.gen.nz>
Date: Fri Dec 9 23:47:21 2022 +1300
Debian Unstable has PostgreSQL 15 now
commit cc0d627a212672421427d4e9efd0c279f617cdc3
Author: Debian Janitor <janitor@jelmer.uk>
Date: Tue Oct 4 16:01:02 2022 +0000
Remove constraints unnecessary since buster (oldstable)
* Remove 1 maintscript entries from 1 files.
Changes-By: deb-scrub-obsolete
![[bug history graph]](https://qa.debian.org/data/bts/graphs/d/davical.png){kind=link}