vcswatch reports that
this package seems to have a new changelog entry (version
12.5~, distribution
unstable) and new commits
in its VCS. You should consider whether it's time to make
an upload.
Here are the relevant commit messages:
commit a6f9a4bbc8efa6a491c7556280e939265826cf61
Merge: 3b1f6bc 3ed70fb
Author: Sean Whitton <spwhitton@spwhitton.name>
Date: Sun Jan 19 21:58:24 2025 +0000
Merge branch 'changelog' into 'master'
Document 12.5 so far
See merge request dgit-team/dgit!100
commit 3ed70fbb2c8548c3fdbb0029033c256d6434e040
Author: Sean Whitton <spwhitton@spwhitton.name>
Date: Sun Jan 19 21:22:11 2025 +0000
Document 12.5 so far
Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>
commit 3b1f6bc8c5c43a7e295c20127e517c12749eabb7
Merge: 86c6f8a ff49712
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun Jan 19 21:16:29 2025 +0000
Merge branch 'tidy-poll' into 'master'
tests: t-poll-loop: Remove unused variable
See merge request dgit-team/dgit!99
commit ff49712d15336f09cc31d28c77447f2976e6b61b
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun Jan 19 20:20:59 2025 +0000
tests: t-poll-loop: Remove unused variable
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 86c6f8a88904332f6a61d1b91351c28d01591958
Merge: 3aff848 16cb36e
Author: Sean Whitton <spwhitton@spwhitton.name>
Date: Sun Jan 19 20:13:27 2025 +0000
Merge branch 't2u-i-2' into 'master'
Finish t2u-integration test
Closes #10
See merge request dgit-team/dgit!98
commit 3aff8489a966ab1e314a8a9ed815e71431027a83
Merge: 90d3345 b47f5ac
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun Jan 19 18:09:06 2025 +0000
Merge branch 't2u-i-1' into 'master'
t2-integration test: actually run t2usm
See merge request dgit-team/dgit!96
commit 16cb36ef49ce1e31913e01c6f55169d58296a5de
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun Jan 19 17:36:37 2025 +0000
tests: t2u: introduce T2U dependency alias
This reduces duplication (and may help avoid future flail with CI like
in !96).
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 205b61b8c4306f538c07884fe0b9ab319fc7d6d5
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun Jan 19 12:25:03 2025 +0000
tests: t2u-integration: Check authorising tag on dgit-repos
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 72156f8f50799dfebd4914c67df255a8a822bc23
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Fri Jan 17 23:49:35 2025 +0000
tests: t2u-integration: Run t-t2u-succeeded and t-pushed-good
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 7166a9a8b2a9da0ac2c8a2ba57ae50583af1b737
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun Jan 19 12:13:16 2025 +0000
tests: t2u-integration: Set $dep14tagref
This is what this is called elsewhere in the test suite. We can use
it ourselves, but t-t2u-succeeded will use it too.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 192d56250563ac6b54e5cf1fae6c1afb6c64f5b7
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun Jan 19 12:12:07 2025 +0000
tests: t2u-integration: Change $tag to $tagname
This is what this is called elsewhere in the test suite.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 9b9946877e3b7aa11fe83bec9359815a415aa347
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun Jan 19 12:30:19 2025 +0000
tests: t-t2u-succeeded: Replace use of t-output with just diff (2)
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 3ec38a2efcce2dbd98c33a8112abd6da836313a5
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Fri Jan 17 23:49:29 2025 +0000
tests: t-t2u-succeeded: Replace use of t-output with just diff (1)
Using temporary files rather than <( ) means an error report would
say what the discrepancy was about, and also leave the actual whole
files in $tmp for inspection.
Also, use diff -u.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit b47f5ac812377b38e979cad080c650f97d8450c7
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun Jan 19 11:40:08 2025 +0000
d-r-s t2u: Set $0 with expanded abbreviation
As per
https://salsa.debian.org/dgit-team/dgit/-/merge_requests/96#note_573605
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit e92e4a17f66321927b270f759b8284bdbfad244f
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun Jan 12 23:47:18 2025 +0000
tests: t2u-integration: Send a webook request and await Uploaded
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 3f0af4fb231aa545c65d6a3d493bad7892ddd4a7
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sat Jan 11 17:53:04 2025 +0000
d-r-s t2u: Avoid "chomp" on the git tag data
cmdoutput chomps.
This causes the tag data to mismatch when the real oracled sends
actual tag data. In tests this was masked by t-t2u-run-drs using
shell command substitution which also strips trailing newlines.
Obviously we mustn't peform a lossy transformation on tags.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 37f5faa72e11b2319ccd845eae307fecf155335b
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sat Jan 11 22:30:58 2025 +0000
d-r-s t2u: Set $0 to not dgit-repos-server when in t2u mode
This arranges that error messages (which end up emailed to someone)
don't expose the internal split between oracled and d-r-s.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit a5a3026f2eb3b4dcf0971e9fea495518b7d442e8
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun Jan 12 23:47:42 2025 +0000
tests: t2u-integration: Don't tell git to use simulated time
This test case uses real time. That avoids us having to simulate the
time for the manager, and it's fine because all the objects we make
are fresh.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 9c9d0e4930c9cde1e77a502341ea112136f248ac
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun Jan 12 23:45:41 2025 +0000
tests: t2u support: Split t-t2u-settings and t-t2u-setup-repo
settings doesn't depend on the package name etc. and can therefore be
called early - early enough to pass parameters to the Manager daemon.
(These new shell variables will be substituted into the Manager
daemon's configuration file in t2u-integration.)
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 6128ea0218876a35ddd7c3acc0b5c6b93a3b11a1
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Fri Jan 10 22:53:12 2025 +0000
tests: t2u-integration: Have oracled connect to real manager
And poll the manager until it connected.
(Also, save the initial Manager front page, without any workers.)
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 789cbd5ce259f3f19aee03c96e2c23b631575714
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Fri Jan 10 20:36:58 2025 +0000
tests: t2u support: Break apart t-t2u-start-t2u-oracled
We're going to want a version that doesn't mock the Manager.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 215a37cd64fdd4a7b31595cc263bda83fb0f362c
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun Jan 12 23:39:51 2025 +0000
tests: use t-poll-loop in t/t/debpolicy-dbretry
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 5d62605983271bd1bee70990fdf0bfcf111f4a8a
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun Jan 12 23:35:41 2025 +0000
tests: use t-poll-loop in t/t/mirror
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 7e07cde723b54f306c4fa1fca3a1595e901198d7
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun Jan 12 10:50:06 2025 +0000
tests: Provide general facility for polling in tests
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 90d334543b85635b4abad0ed0ef5be4f22647b1b
Merge: 636c8b4 eeaa480
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun Jan 19 12:29:14 2025 +0000
Merge branch 'push-built-vs-push-source' into 'master'
docs/usage: List push-built, rpush-source, not push
See merge request dgit-team/dgit!94
commit 636c8b4ed49a44348dd9861d74d9cb5d38166d75
Merge: 06087eb 6232fff
Author: Sean Whitton <spwhitton@spwhitton.name>
Date: Sun Jan 19 12:17:16 2025 +0000
Merge branch 'fingerprint-email' into 'master'
dgit-repos-server: t2u: Implement CCing the tag signing key's owner
Closes #23
See merge request dgit-team/dgit!93
commit eeaa48086ce378134da817206cefefbac9d78299
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun Jan 19 11:45:48 2025 +0000
dgit defcfg: Improve notes
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 6232fff541729dfc1574a9e4702561f5a45cfdd2
Author: Sean Whitton <spwhitton@spwhitton.name>
Date: Sun Jan 19 11:22:12 2025 +0000
d-r-s: Rename mail-names -> preferred-mail-domains
Per discussion here:
<https://salsa.debian.org/dgit-team/dgit/-/merge_requests/93#note_573261>.
Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>
commit a494e1f0d0be5c727190026b8ade2818de6aab9c
Author: Sean Whitton <spwhitton@spwhitton.name>
Date: Sat Jan 18 13:37:43 2025 +0000
d-r-s: maybe_cc_signer: Skip unusual e-mail addresses in UIDs
Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>
commit d8da04b232a9cc36cbf5c40fea0abee49a4e63d0
Author: Sean Whitton <spwhitton@spwhitton.name>
Date: Sat Jan 18 13:15:42 2025 +0000
d-r-s: maybe_cc_signer: Add comments on the extraction algorithm
Also cf.
<https://salsa.debian.org/dgit-team/dgit/-/merge_requests/93#note_573445>.
Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>
commit b7e3f05d64ad874d225e5ca8b89aa6dbd1de441f
Author: Sean Whitton <spwhitton@spwhitton.name>
Date: Sat Jan 18 11:05:25 2025 +0000
d-r-s: maybe_cc_signer: Print all the output we get from gpg
Suggested-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>
commit 275b54cdbbf1175a5ee56f502e903352a99a522c
Author: Sean Whitton <spwhitton@spwhitton.name>
Date: Sat Jan 18 10:51:40 2025 +0000
d-r-s: verifytag_start: Factor out return value construction
Suggested-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>
commit 9a42815122a3eaecd739680d078ec47d8b6d6823
Author: Sean Whitton <spwhitton@spwhitton.name>
Date: Sat Jan 18 10:48:50 2025 +0000
d-r-s: verifytag_start: More fully document possible return values
Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>
commit 40d90b7192f4cf68f4f4a6fa30fd58e3592756e8
Author: Sean Whitton <spwhitton@spwhitton.name>
Date: Sun Jan 12 16:57:20 2025 +0000
dgit-repos-server: t2u: Implement CCing the tag signing key's owner
Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>
commit 95fa7ddaf304c8e3f395da8a6607bcc5e5d86b42
Author: Sean Whitton <spwhitton@spwhitton.name>
Date: Sun Jan 12 15:45:18 2025 +0000
dgit-repos-server: Make t2u_email_copies global into an array (nfc)
Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>
commit 06087eb2d2fc7aee33b6a9c8ef25484e61da6a68
Merge: 1a19ea0 6474641
Author: Sean Whitton <spwhitton@spwhitton.name>
Date: Sun Jan 19 11:38:03 2025 +0000
Merge branch 'drs-gnupg-check' into 'master'
d-r-s: Print a warning if gnupg fails other than due to SIGPIPE
See merge request dgit-team/dgit!97
commit 647464125353f8231120240d75492099bccf1a7e
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun Jan 19 10:38:59 2025 +0000
d-r-s: Print a warning if gnupg fails other than due to SIGPIPE
See
https://salsa.debian.org/dgit-team/dgit/-/merge_requests/93#note_573672
https://salsa.debian.org/dgit-team/dgit/-/merge_requests/93#note_573673
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 1a19ea0e6f02140332d823240b51b8f40ee7724a
Merge: e3efc2a 9378292
Author: Sean Whitton <spwhitton@spwhitton.name>
Date: Sat Jan 18 17:34:50 2025 +0000
Merge branch 'sk-sn' into 'master'
git-debpush(1): Fix -sn vs. -sk
See merge request dgit-team/dgit!95
commit 937829249bf53aab27ae50759fc37e016b2f44cf
Author: Sean Whitton <spwhitton@spwhitton.name>
Date: Sat Jan 18 14:10:08 2025 +0000
git-debpush(1): Fix -sn vs. -sk
Closes: #1093216.
Reported-by: Ben Harris <bjh21@bjh21.me.uk>
Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>
commit ac919e887141c53b43611132d3c7594a2f93900a
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed Jan 15 18:46:33 2025 +0000
dgit defcfg: Add notes about updating things for push-source
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 2c0186639220ca27a789e28fce8609cdcb151be4
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed Jan 15 18:41:27 2025 +0000
dgit defcfg: Remove obsolete docs for dgit-tag-format
In 2799e120b5cfa0ff9f942304f86d8024753bbc70
dgit; dsc Dgit field handling: Properly resolve the commit in the dsc
new items were added, separating this comment from its referent,
perhaps because the comment was below rather than ahead of the
referent.
In 1c3c9da8343a02854b602d3d53694aacaec02db2
dgit: Drop support for old tag format
the config option was removed, including the line this comment
originally referred to, but because of the earlier mistake, the
comment was retained.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit ed0d0ce64ee3c24f54e919ab242a504c08108b03
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Mon Jan 13 09:09:59 2025 +0000
dgit usage message: Mention push-source, not push, and tidy
Also: mention rpush-source, not just push; put push-source ahead of
push-built.
Closes: #1092904
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 2a7f61cbafa52339492e177a8ab023c8e021d4b2
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Mon Jan 13 09:07:16 2025 +0000
dgit(1): List push-source|push-build, not push|push-built, in summary
Right now push gives a warning, by default.
Reported-by: Niels Thykier <niels@thykier.net>
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit e3efc2a82d026befac7ba994e7efccf614636005
Merge: df78061 6fb9ba9
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun Jan 12 16:25:56 2025 +0000
Merge branch 'tachi-master-patch-10273' into 'master'
dgit-maint-debrebase.7: fix example Salsa remote
See merge request dgit-team/dgit!90
commit f094b5803918efb7254c7b9a78f4feb8f4a41b7d
Author: Sean Whitton <spwhitton@spwhitton.name>
Date: Sun Jan 12 11:44:44 2025 +0000
d-r-s: verifytag_start: Include more information in the return value
These will be used for non-authentication purposes.
Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>
commit df7806147c1de2aad53cddabb5d559d2e5228adf
Merge: cb1e3c2 db1c966
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun Jan 12 12:22:48 2025 +0000
Merge branch 'autopkgtest-preserve-tmp' into 'master'
Race fixes and diagnostic and testing improvements
See merge request dgit-team/dgit!91
commit db1c9663e8b458a5d69c065b9aad9df349e3c5e5
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun Jan 12 10:53:16 2025 +0000
tag2upload-oracled: Document --retain-tmp in usage summary comment
As per
https://salsa.debian.org/dgit-team/dgit/-/merge_requests/91#note_570552
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit e896d34346815f945ea89b3a9ea0824138cc7ce3
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun Jan 12 10:51:16 2025 +0000
tag2upload-oracled: Coding style changes
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit cb1e3c2be5127c595cf2bf2662b632773dc1e674
Merge: 41d9267 2dfee50
Author: Sean Whitton <spwhitton@spwhitton.name>
Date: Sun Jan 12 11:02:10 2025 +0000
Merge branch 'mgtf-rb' into 'master'
mini-git-tag-fsck: Fix bytestring regexp syntax
See merge request dgit-team/dgit!92
commit 97585e4143f28b1dd28416d7c6730a74b0a86aeb
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sat Jan 11 23:09:18 2025 +0000
tests: t2u-ssh-for-t2u-oracled minor improvements
Print our own pid in the startup message.
Add some commented-out stderr prints I used for debugging this.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 64c6fab792c9c8fc0d80b928fb488c65a13e6c8b
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sat Jan 11 23:07:12 2025 +0000
tests: tag2upload-oracled: Don't kill oracled again
This pid is typically gone by then, and we don't want to kill random
pids.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit ead7dc3ab2fd6ebe4dc546c311c41e4b63939d37
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sat Jan 11 23:06:52 2025 +0000
tests: Break out t-dontkill-pid
We'll need this in a moment.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit a6db2b49e6f1765e67e6c4c9233c9b8053c56949
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sat Jan 11 17:16:09 2025 +0000
tests: t2u*: Bodge autopkgtest-virt-null so as to retain the tmp dir
This makes it much easier (for me, possible) to figure out what
happened if a test fails.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 2dfee508ff3d87c7dd69d38af7316fd62f9c7ea1
Author: Sean Whitton <spwhitton@spwhitton.name>
Date: Sun Jan 12 10:33:30 2025 +0000
mini-git-tag-fsck: Fix bytestring regexp syntax
Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>
commit b3235ebe2e54481776da7c30b2aa0de0608dea08
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sat Jan 11 17:11:13 2025 +0000
tag2upload-oracled: Provide --retain-tmp, and pass it in tests
This is not effective yet, because in our actual tests we use
autopkgtest-virt-null which also idempotently deletes this.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 32281ba414b5b50a80e161142eeee143b6d9a7ab
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sat Jan 11 21:59:57 2025 +0000
tag2upload-oracled: await the virt server on exit
This means we'll detect if it crashed during shutdown.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 411be12f11aec1bef4a36c8cdb2c4ae3554f73c1
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sat Jan 11 21:41:43 2025 +0000
tag2upload-oracled: Add descriptions to ProtoConn connections
Otherwise it's confusing - EOF on what?
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 2758275a404f4e558968e4c98d603614545be33a
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sat Jan 11 21:40:54 2025 +0000
ProtoConn: Facility for description in error (and debug) messages
We add this right at the end, only when we call printdebug or fail -
ie when we call things that don't take a ProtoConn.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 46e6f6a979fc8224273eba707b74ff4911247f5d
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sat Jan 11 21:33:41 2025 +0000
tag2upload-oracled: Report protoconn children wait statuses
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 84a27636798c2c5a687627d3c98102be6029939d
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sat Jan 11 21:22:06 2025 +0000
ProtoConn: Save pid and command (and provide accessors)
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit c787fc77d4763c4c64ecbf2b20e184a290793ca5
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sat Jan 11 20:56:26 2025 +0000
tag2upload-oracled: When a worker dies, print its wait status
This is in addition to any message it prints itself.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 0416c09717feb28fd7417451987943b1e8990f5e
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sat Jan 11 22:10:36 2025 +0000
tests: Rewrite t2u-ssh-for-t2u-oracled in perl
This uses the same approach, but now we can know that we don't kill
random other processes.
Without this, I was getting "No such process" showing up in test
output, which indicates that the test suite is killing random pids
even in normal operation.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit e841610705212881d3bb0df3d2c6ab22b4bdddfa
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sat Jan 11 20:57:26 2025 +0000
tag2upload-oracled: Do not expect "ok" in response to adt virt "quit"
At least autopkgtest-virt-null doesn't send it, contrary to the docs.
See #1092808.
We ought to wait for EOF and/or for the virt server to exit. But, we
have a race here, so fix that right now. We'll make this better shortly.
(Right now we almost always win the race because the virt server
typically spawns another rm -rf at this point, but we're changing
that.)
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 6fb9ba9d974b531f41d119234f9b06a7d095767c
Author: Andrea Pappacoda <andrea@pappacoda.it>
Date: Sat Jan 11 14:18:47 2025 +0000
dgit-maint-debrebase.7: fix example Salsa remote
ssh access to GitLab uses the "git" user, and the common Debian namespace
is spelled lowercase
Signed-off-by: Andrea Pappacoda <andrea@pappacoda.it>
commit 41d926736ad39149c1189e70b5aee1d09432e28a
Merge: 6639583 f59eb4a
Author: Sean Whitton <spwhitton@spwhitton.name>
Date: Sat Jan 11 08:02:13 2025 +0000
Merge branch 'git-tag-fields-2' into 'master'
dgit-repos-server: Set the Git-Tag-Tagger & Git-Tag-Info fields
Closes #33, #27, and #26
See merge request dgit-team/dgit!89
commit 663958321f5c340c59217c19e3c12e9d810e0066
Merge: efc4072 5c9148c
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Fri Jan 10 23:50:48 2025 +0000
Merge branch 'verify' into 'master'
Completely rework dgit-repos-server t2u mode
Closes #20, #9, and #8
See merge request dgit-team/dgit!86
commit f59eb4a5517ab354e5959d16edcc5b3ca085def6
Author: Sean Whitton <spwhitton@spwhitton.name>
Date: Fri Jan 10 18:05:58 2025 +0000
dgit(1): Fix sentence describing --expect-version
Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>
commit e5599df84cd4a6d4f1c9114d6b1d3d8858eca7bf
Author: Sean Whitton <spwhitton@spwhitton.name>
Date: Fri Jan 10 16:31:11 2025 +0000
changelog: Document 12.5 so far
Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>
commit 7ad76a38e63c75105f291801ab19fe8e1d09eb8a
Author: Sean Whitton <spwhitton@spwhitton.name>
Date: Fri Jan 10 16:31:03 2025 +0000
Update copyright years for dgit, d-r-s & tag2upload-oracled
Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>
commit 8229462b4229fa514691097d1d0e5075b6bec055
Author: Sean Whitton <spwhitton@spwhitton.name>
Date: Fri Jan 10 16:30:42 2025 +0000
tag2upload-oracled: Validate and log d-r-s protocol messages
Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>
commit 9b104072d3f7c61d2c75fdcf29646a3278e84533
Author: Sean Whitton <spwhitton@spwhitton.name>
Date: Fri Jan 10 15:53:58 2025 +0000
dgit-repos-server: Set the Git-Tag-Tagger & Git-Tag-Info fields
See TAG2UPLOAD-DESIGN.txt. Closes: #932753.
Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>
commit 5c9148c4dbb6643f29367c5cd65bfd3abc8964f2
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Fri Jan 10 11:44:12 2025 +0000
tests: t2u: Add test case for missing verify_finish call
As per
https://salsa.debian.org/dgit-team/dgit/-/merge_requests/86#note_568995
I have verified that with this test case, removing these lines
> # Check that the package is right for a DM upload, now that we know it
> verifytag_finish $verifytag_info;
from d-r-s causes this test case to fail, with the error being that
the package was uploaded - as would be expected.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 26402b8510f7b12dda08313a9aa987863bdc0da8
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Fri Jan 10 11:50:58 2025 +0000
tests: t2u: Run t-archive-process-incoming on 1.0-1
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 5294a5ab851652a3fe597fa612e730f32b1b0612
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Fri Jan 10 12:01:54 2025 +0000
tests: t-archive-process-incoming: allow overriding $v
We're about to want to move something earlier out of incoming, even
though we've already moved on to another version (setting v).
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit ef7c6783cb516e48ebea452cb4917d6a55ad14fa
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed Jan 8 19:19:22 2025 +0000
d-r-s: t2u: Use X-Debian-Tag2upload- for info email headers
See
https://salsa.debian.org/dgit-team/dgit/-/merge_requests/86#note_567835
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 36b49c87030b119be734626b386eaa221c103d3a
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed Jan 8 19:17:50 2025 +0000
d-r-s: t2u: Remove an otiose pair of quotes
As per
https://salsa.debian.org/dgit-team/dgit/-/merge_requests/86#note_568806
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit bc10cfbd736d0daa97ae13edff352658de9fb8e6
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed Jan 8 19:15:11 2025 +0000
d-r-s: Change "headline" terminology to "summary line"
As per
https://salsa.debian.org/dgit-team/dgit/-/merge_requests/86#note_567832
This replaces the intent behind
d-r-s: Use "headline" terminology to refer to the tag title line
which we now think is less clear. (But, this commit is not a revert.)
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 94a08d55f0869fe4b42cda6f65438cf614f91b90
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed Jan 8 19:05:45 2025 +0000
tag2upload-oracled: Remove an unused variable
This became unused in "t2u: Rework error handling in d-r-s".
As per
https://salsa.debian.org/dgit-team/dgit/-/merge_requests/86#note_567842
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 920cb8937b2a0f443418ef275a5b22d7d2b5d9dc
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Tue Jan 7 18:07:44 2025 +0000
t2u: d-r-s: Improve some user-facing messages
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 4f6d9b69c57f7836e9c52f81a9e8b42b132c844a
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed Jan 1 21:24:41 2025 +0000
d-r-s: t2u: Rename @dgitcmd to @cmd
This code used to be in a function which ran various commands. Now it
just does this. Using @cmd is clearer. For example, helps avoid
thinking that this is some kind of global that we might be adding to
or that other functions might use.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit b651e5fd19d8735e0e470a0600e4a4ffb5ab7669
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed Jan 1 21:18:55 2025 +0000
d-r-s: t2u: Remove an otiose check
$t2u_upstreamt can't be defined here. It comes from the tag, which we
are just starting parsing at this point.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit a3aaeee90be351ff80b492dd14257fa2504fa941
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed Jan 1 21:21:20 2025 +0000
d-r-s: t2u: Clarify dgit rpush-source invocation
Putting the rpush-source verb on its own line makes it stand out more,
which I think is clearer. This is where the principal work is done!
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit b8968968a6b6a5c21dd423e0fe75f0f557aea262
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed Jan 1 22:33:21 2025 +0000
d-r-s: t2u: Add doc comments to t2uv_runcmd and _cmdprefix
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 36124e449fbf3d029e9868650180219a3e57322e
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun Dec 29 18:46:03 2024 +0000
d-r-s: t2u: Write "rejected:" rather than "reject:" in emails
This is better grammar, I think.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 4d3a4d7a4960138ef76de82728475d56f970b717
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed Jan 1 21:29:20 2025 +0000
d-r-s: t2u: Improve some error messages
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 0ee444eba0471447b7e18da43c1888c76e22319c
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun Dec 29 23:55:01 2024 +0000
d-r-s: t2u: Add more useful email headers
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 7013995f0514e41ef967afb42ad998ec2303edea
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed Jan 1 23:03:25 2025 +0000
d-r-s: t2u: Send email when starting, and on success
This is most of dgit#23. But we do *not* yet email the email address
associated with the signing key.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 2b1c087890fd2322910a47afe5c52e5309e9adbc
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed Jan 1 22:41:02 2025 +0000
d-r-s: t2u: Remove some unhelpful defaulting
$distro is set on our command line. $version is set in
tag2upload_check_args. Both of these run before we try to send any
emails.
We don't unconditionallly need $package any more, since now the
Subject (which used to use this) is supplied by our caller.
Only include the X- header line if we have it, though.
Setting these global variables to default values was always a bit
shonky.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 814cc5b2f32a0c1ce56a19e1e8a416b75c2aad4a
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed Jan 1 23:28:40 2025 +0000
d-r-s: t2u: Have callers of t2u_send_email provide some info
We're going to call this in more circumstances, including when we
start a job, and on success. So a "failed" message is not always
appropriate.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 30cbb5c84013e2e31954788f40ffb8c2a325a879
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed Jan 1 20:16:40 2025 +0000
d-r-s: t2u: Abolish vestigial $quit
And merge tag2upload_parsetag2 into tag2upload_parsetag,
as planned.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 60ff5a86f80972bc76ebc264e5c09c86cff48228
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Fri Jan 10 14:45:01 2025 +0000
t2u: Rework error handling in d-r-s
* Change the order of events to the one we intend.
Now we verify the signature first (dgit#9).
* Have d-r-s provide the manager protocol response.
See b686522e8f1d. This is a change to the oracle-to-drs protocol,
so bump the version to --tag2upload5.
* Abolish overall.log. Logging is now done by the oracled.*.
* The message in the protocol response to the manager now contains
more helpful information - notably, whether email reports were sent.
Much internal rearrangement:
* Use a new $reject_hook to make it possible to call `reject` everywhere
(this sort-of-replaces the plumbed-through $quit closure, but its
functionality is rather different).
* Have each failure path provide the informational text in email reports.
In the tests:
* Capture the drs-generated protocol response, so we can examine it.
* Always run d-r-s with LC_MESSAGES=C. We don't intend to translate
this, and doing it that way simplifies some things.
* No longer expect d-r-s to crash. It's not supposed to.
We retain the $quit arguments for a moment, to avoid adding more noise
to the diff.
I don't know if logging of commands to the emails works properly.
I have filed dgit#32 for that.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit eebb9a7c0802b06b5e1ab9f4feedebbb283ddcdb
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed Jan 1 21:20:42 2025 +0000
d-r-s: t2u: Abolish ad-hoc scanning of the git tag
Previously, this code ran before parsetag, to try to procheck whether
this is a t2u tag at all. Now that is done much earlier, typically by
the Manager.
That the tag contains a please-upload request is still checked via
%need by other code in tag2upload_parsetag.
Get the tagger out of the parsed headers.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit cfcb6ff974f69b1774c4f7b6267b5312a57e46f4
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed Jan 1 19:28:40 2025 +0000
d-r-s: t2u: Simplify our git fetch
Don't clone the input tag with --depth=1 and then unshallow if
upstream is provided. Simply always clone the whole tree.
(It's not d-r-s's job to try to optimise this by some kind of shallow
clone; dgit might know how to do that, depending on the quilt mode,
but it doesn't offer an API for it.)
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 0400ebf9d4b3c450dd90f88bfcde4c3560b4114b
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed Jan 1 19:58:00 2025 +0000
d-r-s: t2u: Use t2u_add_to_report to progressively improve emails
Call t2u_add_to_report whenever we have more information or progress
to report. This replaces the information added at the end in
t2u_send_email.
Introduce a new function tag2upload_verifytag which does the email
reporting for signature verification. Do the reporting for the dm.txt
check in tag2upload_parsetag2, which will become part of
tag2upload_parsetag (but can't yet, because things aren't happening in
the right order).
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 5ca9d0e41647e5e8d4b20ab650be6c46675c4776
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed Jan 1 21:44:48 2025 +0000
d-r-s: t2u: Obtain the suite from the changelog, not the heading line
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 5efb9ff43d47d9d75b10982478d57844d27882a0
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed Jan 1 19:01:30 2025 +0000
d-r-s: t2u: Break apart tag2upload_prebuild
It is clearer to think of this as separate operations, even though
they'll remain consecutive even after all the reorganisation.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit a9e4886317209534b720c918fed8da536ec8075c
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed Jan 1 22:10:48 2025 +0000
d-r-s: New internal verifytag API
We are going to need to verify the signature on the tag, using our
keyrings, before we know which package the tag is supposedly for -
since the package is obtained by parsing the tag.
So we must split verifytag up into two pieces. The push receiver code
can just use verifytag, which retains the old behaviour.
The t2u code calls the pieces (including parsetag_split) separately:
We split that up now, and the ordering of events will be changed
later.
The tests remain untouched, since there is no behavioural change.
The principal test case for this code is drs-push-rejects.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 6f2ad20a2381739b851df3c5beb3f4f5c18ae538
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed Jan 1 22:06:15 2025 +0000
d-r-s: New internal parsetag API
The previous arrangements were quite bizarre, with various shared file
handles being left in various states halfway through the tag, etc.
Replace parsetag_start with parsetag_split (dismantles the tag into
plaintext and signature, and also splits off the message part).
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit 9e122d3c13289f27d831089976bda040b641df3b
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed Jan 1 22:01:04 2025 +0000
Behavioural change: d-r-s: Reject tags with no distro=
In d0c5d6629f42b2efa52fb48a5f24407ef18f86b2 in March 2015, we added a
`distro=` to the signed tags used as push instructions to dgit-repos.
This was released as part of dgit 0.30 which is necessary to use the
new dgit-repos server.
We don't need to support tags without distro= any more.
Make the check call `reject` rather than `die`. (This makes d-r-s
report it by email, in t2u mode, which seems correct.)
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
commit e45cc4de333aa6b061e3b62b190768e9d3a7bf49
Author: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed Jan 1 21:13:23 2025 +0000
d-r-s: t2u: Code motion to put functions in intended execution order
This is not the *current* execution order, yet.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>