commit eafdcccd865605852a7e73e5a0e1cec8a2784cd6
Merge: 71638cbf a721b865
Author: Theodore Ts'o <tytso@mit.edu>
Date: Tue Sep 13 02:44:45 2022 -0400
Merge branch 'maint' into debian/master
commit a721b865d97cef58d7bca3bd03c8190342da79e8
Author: Theodore Ts'o <tytso@mit.edu>
Date: Tue Sep 13 02:42:56 2022 -0400
debian: add release notes for 1.46.5-2 to the debian changelog
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 71638cbf42521b807115d9441d8fac95240ecbd8
Author: Theodore Ts'o <tytso@mit.edu>
Date: Mon Jan 3 23:48:50 2022 -0500
Update debian/changelog and debian/patches for the 1.46.5-2 release
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit ddb2abd2ba1dd03f85a22afe48c599a1025f2ab0
Merge: 6fd93c23 8535250a
Author: Theodore Ts'o <tytso@mit.edu>
Date: Mon Jan 3 23:46:19 2022 -0500
Merge branch 'maint' into debian/master
commit 6fd93c23a818c3c0a6f1485f6bb64cb5038cfa2f
Author: Theodore Ts'o <tytso@mit.edu>
Date: Thu Dec 30 10:43:49 2021 -0500
debian: suppress the no-debian-changes lintian warning
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit c39d661b4c4265a69716045327813c2e7851a727
Merge: b75b208f 704b18b9
Author: Theodore Ts'o <tytso@mit.edu>
Date: Thu Dec 30 01:00:07 2021 -0500
Merge tag 'v1.46.5' into debian/master
v1.46.5
commit b75b208ffbeb43edddf080e14f9f9a1e88f91f94
Author: Theodore Ts'o <tytso@mit.edu>
Date: Thu Aug 19 15:18:33 2021 -0400
debian/changelog: add missing section for 1.46.2-2
E2fsprogs 1.46.2-2 was uploaded during the release freeze, so the
changelog was assembled outside of the normal maint branch. Add it
now.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 5fc21e989b69306227dcd8b0137eb72c5b178c8b
Merge: f103b6d4 2dfad18d
Author: Theodore Ts'o <tytso@mit.edu>
Date: Wed Aug 18 23:02:08 2021 -0400
Merge tag 'v1.46.4' into debian/master
v1.46.4
commit f103b6d4221716e8cd8102fc10bad0352a6a452f
Author: Theodore Ts'o <tytso@mit.edu>
Date: Tue Jul 27 13:48:06 2021 -0400
Remove debian/patches for v1.46.3 release
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 0c0f49189893295a9ece42ee400fe3c4fd6d6dd9
Merge: 5697567d 496669a2
Author: Theodore Ts'o <tytso@mit.edu>
Date: Tue Jul 27 13:47:28 2021 -0400
Merge tag 'v1.46.3' into debian/master
v1.46.3
commit 5697567d7592522ba76381cde80dbda57246c1b4
Author: Theodore Ts'o <tytso@mit.edu>
Date: Mon Jun 7 07:29:43 2021 -0400
debian: update changelog and debian/patches for the 1.46.2-2 release
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 040cf161ae70c375218ca47ef7e4d3b37316df71
Author: Andreas Dilger <adilger@dilger.ca>
Date: Tue Mar 9 01:35:08 2021 -0700
e2image: add OPTIONS section to man page
Reorganize the e2image.8 man page so that the command-line options
are listed in a dedicated OPTIONS section, rather than being
interspersed among the text in the DESCRIPTION section. Otherwise,
it is difficult to determine which options are available, and to
find where each option is described.
Signed-off-by: Andreas Dilger <adilger@dilger.ca>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit c9b85b3453d54181cf0bb9beab4056ccff7d1733
Author: Alexander Kanavin <alex.kanavin@gmail.com>
Date: Fri Apr 30 23:45:56 2021 +0200
libext2fs: fix missing mutex unlock in an error path of the Unix I/O manager
Originally from https://github.com/tytso/e2fsprogs/pull/68
Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 8188d943e51290e7edce0b6e462021504afdf3e6
Author: Theodore Ts'o <tytso@mit.edu>
Date: Thu May 6 22:40:57 2021 -0400
e2fsck: fix unaligned accesses to ext4_fc_add_range and fc_raw_inode
These fast commit related structures can be unaligned on disk. So we
need to avoid accessing these structures directly, and first copy
them to memory which we know is appropriately aligned.
This fixes an e2fsck crash while running the j_recovery_fast_commit
regression test on a sparc64 system.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 440e465618f080b2742fccc3b6ae327e306aeab0
Author: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Date: Thu May 6 17:21:10 2021 -0700
e2fsck: fix unaligned accesses to ext4_fc_tl struct
Fast commit related struct ext4_fc_tl can be unaligned on disk. So,
while accessing that we should ensure that the pointers are
aligned. This patch fixes unaligned accesses to ext4_fc_tl and also
gets rid of macros fc_for_each_tl and ext4_fc_tag_val that may result
in unaligned accesses to struct ext4_fc_tl.
Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 40960a7118171498448870b26d1c867f92fa430e
Author: Theodore Ts'o <tytso@mit.edu>
Date: Mon May 3 15:37:33 2021 -0400
e2fsck: fix portability problems caused by unaligned accesses
The on-disk format for the ext4 journal can have unaigned 32-bit
integers. This can happen when replaying a journal using a obsolete
checksum format (which was never popularly used, since the v3 format
replaced v2 while the metadata checksum feature was being stablized),
and in the fast commit feature (which landed in the 5.10 kernel,
although it is not enabled by default).
This commit fixes the following regression tests on some platforms
(such as running 32-bit arm architectures on a 64-bit arm kernel):
j_recover_csum2_32bit, j_recover_csum2_64bit, j_recover_fast_commit.
https://github.com/tytso/e2fsprogs/issues/65
Addresses-Debian-Bug: #987641
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 2a1df88c55df686f4665ee11787c684f13cde2c4
Merge: e5e459c7 67f2b546
Author: Theodore Ts'o <tytso@mit.edu>
Date: Sun Feb 28 21:52:33 2021 -0500
Merge tag 'v1.46.2' into debian/master
v1.46.2
commit 67f2b54667e65cf5a478fcea8b85722be9ee6e8d
Author: Theodore Ts'o <tytso@mit.edu>
Date: Sun Feb 28 09:57:25 2021 -0500
Update release notes, etc., for the 1.46.2 release
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit d557b9659ba97e093f842dcc7e2cfe9a7022c674
Author: Theodore Ts'o <tytso@mit.edu>
Date: Sun Feb 28 18:52:20 2021 -0500
libext2fs: fix potential races in unix_io
When unix_io does not use pread/pread64 (which is the case the bounce
buffer is in use, either when Direct I/O is in use or the
IO_FLAG_FORCE_BOUNCE in enabled), there are races between the llseek
and and read or write system calls. Fix this by using the BOUNCE_MTX
so only one thread is using the file descriptor at a time.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit e1af249abafbf4b08c5b55cab6a0564170ce0f7d
Author: Theodore Ts'o <tytso@mit.edu>
Date: Sun Feb 28 09:12:47 2021 -0500
libext2s: fix unix_io with IO_FLAG_FORCE_BOUNCE flag set
The bounce read/write code would crash with a floating point exception
if alignment is set to 0.
Fixes: c001596110e8 ("libext2fs: fix unix_io's Direct I/O support")
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 8895443d2556c504753ca4d2c58386b55392dc7b
Author: Antonio Ceballos <aceballos@gmail.com>
Date: Sat Feb 27 10:24:06 2021 -0500
po: update es.po (from translationproject.org)
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit c001596110e834a85b01a47a20811b318cb3b9e4
Author: Theodore Ts'o <tytso@mit.edu>
Date: Fri Feb 26 17:41:06 2021 -0500
libext2fs: fix unix_io's Direct I/O support
The previous Direct I/O support worked on HDD's with 512 byte logical
sector sizes, and on FreeBSD which required 4k aligned memory buffers.
However, it was incomplete and was not correctly working on HDD's with
4k logical sector sizes (aka Advanced Format Disks).
Based on a patch from Alexey Lyashkov <alexey.lyashkov@hpe.com> but
rewritten to work with the latest e2fsprogs and to minimize changes to
make it easier to review.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reported-by: Artem Blagodarenko <artem.blagodarenko@gmail.com>
commit c176c240cbd12eca5de45df0d13f4b139ae15c3d
Author: Theodore Ts'o <tytso@mit.edu>
Date: Fri Feb 26 17:18:48 2021 -0500
iscan: fix the test program iscan so it builds again
The iscan program program isn't built by default, and was relying on
e2fsck's util.c, so it had suffered bitrot as e2fsck/util.c had
evolved. Fix it so that iscan builds correct.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 76a6c8788c79e4ba72dab691818cdae23e760e86
Author: Lukas Czerner <lczerner@redhat.com>
Date: Thu Feb 18 10:51:46 2021 +0100
mmp: do not use O_DIRECT when working with regular file
Currently the mmp block is read using O_DIRECT to avoid any caching that
may be done by the VM. However when working with regular files this
creates alignment issues when the device of the host file system has
sector size larger than the blocksize of the file system in the file
we're working with.
This can be reproduced with t_mmp_fail test when run on the device with
4k sector size because the mke2fs fails when trying to read the mmp
block.
Fix it by disabling O_DIRECT when working with regular files. I don't
think there is any risk of doing so since the file system layer, unlike
shared block device, should guarantee cache consistency.
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit bb2349c518bd6d59edac4148e4cd3373731b1d27
Author: Theodore Ts'o <tytso@mit.edu>
Date: Thu Feb 25 21:40:27 2021 -0500
resize2fs: prevent block bitmap warnings when doing extreme fs expansions
This commit fixes a bug where if a small file system is resized to
ridiculous sizes, such that the size of the resized block group
descriptor blocks exceed the original file system, and this would
result in resize2fs triggering a large number of scary warning
messages:
Illegal block number passed to ext2fs_test_block_bitmap #12440
for block bitmap for broken.img
This can be replicated via:
./misc/mke2fs broken.img -b 1024 -T default
truncate -s +1500G broken.img
./resize/resize2fs broken.img
Fortunately, aside from triggering these warning messages, the bug had
no other bad effects.
https://github.com/tytso/e2fsprogs/issues/60
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 37c2008f1356ba64132514346c1916f7ecc83ddb
Author: Theodore Ts'o <tytso@mit.edu>
Date: Thu Feb 25 17:26:07 2021 -0500
debugfs: fix rdump and ls to handle uids and gids > 65536 correctly
https://github.com/tytso/e2fsprogs/issues/63
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit d6d69857e79aa1e9d6736c9728ca28cebfad5ce0
Author: Theodore Ts'o <tytso@mit.edu>
Date: Thu Feb 25 12:39:01 2021 -0500
Remove superfluous break statements
https://github.com/tytso/e2fsprogs/pull/45
https://github.com/tytso/e2fsprogs/pull/46
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 1f4a5aba59f39a33a84152b5ae3ec0a5657b12a1
Author: Lennart Poettering <lennart@poettering.net>
Date: Thu Feb 25 12:33:35 2021 -0500
chattr/lsattr: expose FS_NOCOMP_FL (aka EXT2_NOCOMPR_FL)
This adds support for setting/querying the FS_NOCOMP_FL/EXT2_NOCOMPR_FL
file flag to chattr/lsattr. I picked the character "m" because it was
so far unused and all other characters that were more obvious candidates
were already taken.
The flag is available on btrfs, and with this patch it is possible to
manage it correctly.
Signed-off-by: Lennart Poettering <lennart@poettering.net>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 989a4189698c4efa53b521b6ad8236bbfc3452c3
Author: Zhiqiang Liu <liuzhiqiang26@huawei.com>
Date: Sat Feb 20 16:41:29 2021 +0800
debugfs: fix memory leak problem in read_list()
In read_list func, if strtoull() fails in while loop,
we will return the error code directly. Then, memory of
variable lst will be leaked without setting to *list.
Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
Signed-off-by: linfeilong <linfeilong@huawei.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit ed907b1df27111bb717e2aba7492547977c63049
Author: Theodore Ts'o <tytso@mit.edu>
Date: Wed Feb 24 00:08:07 2021 -0500
libe2p: remove nested #ifdefs in fgetflags.c and fsetflags.c
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 7e8d22814c41c375027a6183180af79a66d75e69
Author: Theodore Ts'o <tytso@mit.edu>
Date: Tue Feb 23 23:57:10 2021 -0500
debugfs: fix file descriptor leak on error path in do_logdump()
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 4537f8aa8020ab1099d58cf540d0ae518606cf15
Author: Theodore Ts'o <tytso@mit.edu>
Date: Tue Feb 23 22:03:59 2021 -0500
misc/Makefile.in: add rules to build static versions of lsattr and chattr
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 40ea4628ba1b55f8eba311f12399d039698dbeeb
Author: Theodore Ts'o <tytso@mit.edu>
Date: Tue Feb 23 21:25:46 2021 -0500
libe2p: skip unneeded lstat(2) in fgetflags() and fsetflags()
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 7fc56dd147fe7f1a4427f8caed10866e0255eea3
Author: Theodore Ts'o <tytso@mit.edu>
Date: Tue Feb 23 20:58:31 2021 -0500
debugfs: fix uninitialized variable es in do_logdump()
Fixes: d96064e9821a ("debugfs: simplify the do_logdump() function")
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit d96064e9821af2d5dbfae7e238dd4e8dac20d72f
Author: Theodore Ts'o <tytso@mit.edu>
Date: Tue Feb 23 16:19:00 2021 -0500
debugfs: simplify the do_logdump() function
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 03130cc27f08143e18cd17ec2677ace5ac22fdb0
Author: Theodore Ts'o <tytso@mit.edu>
Date: Tue Feb 23 16:02:42 2021 -0500
Add checks for fs->blocksize == 0 which could cause some crashes
This should never happeb, but some checks is useful, and also fixes
some Coverity warnings.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 61ec4fba1d81111403265031513e787486cca3f0
Author: Theodore Ts'o <tytso@mit.edu>
Date: Tue Feb 23 13:03:37 2021 -0500
e2fsck: fix miscellaneous clang warnings
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 5ba3e1644c44572a9822aaa417cb3da69778d216
Author: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Date: Tue Feb 23 09:41:56 2021 -0800
e2fsck: initialize variable before first use in fast commit replay
Initialize ext2fs_ex variable in ext4_fc_replay_scan() before first
use. Also make sure ext2fs_decode_extent() completely overwrites the
extent structure passed to it as argument to prevent potential future
bugs for the users of the function.
Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 11797844f48882506e1ca0b92e52b036391f3b32
Author: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Date: Tue Feb 23 09:41:55 2021 -0800
e2fsck: add fallthrough comment in fc replay switch case
During fast commit replay scan phase, in ext4_fc_replay_scan(), we
want to fallthrough in switch case for EXT4_FC_TAG_ADD_RANGE case. Add
a comment for that.
Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit c5ff455e42d2f2715fe3245fa8c63c87f05af97c
Author: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Date: Tue Feb 23 09:41:54 2021 -0800
ext2fs: don't ignore return value in ext2fs_count_blocks
Don't ignore return value of ext2fs_get_array() in
ext2fs_count_blocks().
Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 1e616535bc5e8e2edc10218f9a2db84efd9eb3c3
Author: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Date: Tue Feb 23 09:41:53 2021 -0800
e2fsck: don't ignore return values in e2fsck_rewrite_extent_tree
Don't ignore return values of library function calls in
e2fsck_rewrite_extent_tree.
Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 1dba260cef9a36d2a6a9131f877027f741d613e2
Author: Theodore Ts'o <tytso@mit.edu>
Date: Tue Feb 23 12:56:01 2021 -0500
create_inode: fix potential file descriptor leak on an error path
Addresses-Coverity-Bug: 1473307
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit bd36e7d14f5d84dabe7b3c1f997476f2912ba85f
Author: Andreas Dilger <adilger@whamcloud.com>
Date: Mon Feb 22 21:53:53 2021 -0500
misc: replace remaining loff_t with ext2_loff_t
Replace the remaining loff_t uses with ext2_loff_t, as
was done in patch 1df6a4555, since loff_t is a GCC'ism
and is not portable.
Signed-off-by: Andreas Dilger <adilger@whamcloud.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit da3b6c27d2bdcb7bf08db01572a041ac2f2e5032
Author: Akatsuki Rui <3736910+akiirui@users.noreply.github.com>
Date: Mon Feb 22 11:42:38 2021 -0500
chattr.1: improve attributes description to btrfs
- c: for btrfs, compression are conflicts with nodatacow and nodatasum
- C: for btrfs, nodatacow is conflict with compression
ref:
- https://btrfs.wiki.kernel.org/index.php/Manpage/btrfs(5)#MOUNT_OPTIONS
- https://www.spinics.net/lists/linux-btrfs/msg103219.html
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit bc50f5abd7697e6c1c396983c1a083d560b29bff
Author: Earl Chew <earl_chew@yahoo.com>
Date: Sat Feb 20 08:47:46 2021 -0800
create_inode: Find subdirectory in do_write_internal
Follow the example in do_mkdir_internal, and do_symlink_internal,
and find the correct parent directory if the destination
is not just a plain basename.
https://github.com/tytso/e2fsprogs/issues/61
Signed-off-by: Earl Chew <earl_chew@yahoo.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit ea82add307c4bc820423abc8acc2f155720cf914
Author: Theodore Ts'o <tytso@mit.edu>
Date: Tue Feb 16 00:30:24 2021 -0500
debugfs: fix dump_metadata_block() for block sizes > 8192
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 71f9bf7b08f2f7b632323719a4e69e94e0567a70
Author: Theodore Ts'o <tytso@mit.edu>
Date: Sun Feb 14 23:51:45 2021 -0500
libext2fs: fix crash when ext2fs_mmp_stop() is called before MMP is initialized
The fatal_error() function in e2fsck can call ext2fs_mmp_stop() on a
file system where MMP hasn't yet been initialized. When that happens,
instead of crashing, have ext2fs_mmp_stop() return success, since mmp
doesn't need to be stopped if it hasn't even been initialized yet.
Addresses-Debian-Bug: #696609
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit e3a13a47e6f215c5db5cb58f646b422d6330fc6a
Author: Theodore Ts'o <tytso@mit.edu>
Date: Sun Feb 14 10:37:00 2021 -0500
tune2fs: teach tune2fs to use a random value for "-c random"
Addresses-Debian-Bug: #926293
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit ff9b039b1f6c86b144686d5baf57dbce14998285
Author: Theodore Ts'o <tytso@mit.edu>
Date: Sat Feb 13 11:54:58 2021 -0500
debugfs: clamp journal s_maxlen value when dumping the journal log
Addresses-Coverity-Bug: 1432478
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 28e22540e24fd2a70b8adf805fad4961f5234d21
Author: Theodore Ts'o <tytso@mit.edu>
Date: Sat Feb 13 10:35:50 2021 -0500
debugfs: fix logdump on file systems with block sizes > 8192
Addresses-Coverity-Bug: 1472879
Addresses-Coverity-Bug: 1472880
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 462c424500a592723887b861f857650523bab359
Author: Theodore Ts'o <tytso@mit.edu>
Date: Fri Feb 12 21:43:00 2021 -0500
debugfs: fix memory allocation failures when parsing journal_write arguments
Fix double-free issues when parsing an invalid journal_write command,
such as: "journal_write -b 12 -b BAD -b 42".
Addresses-Coverity-Bug: 1464571
Addresses-Coverity-Bug: 1464575
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit eef68a593f7f1a1c60be6da670cc3c7abb7d013a
Author: Theodore Ts'o <tytso@mit.edu>
Date: Fri Feb 12 16:50:07 2021 -0500
debugfs: fix header checks in logdump
Fixes: bd9ac48c9200 ("debugfs: add journal header checks in logdump")
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 4d8169ad2aeb6d1c176c716887bdaa1762a14560
Author: Theodore Ts'o <tytso@mit.edu>
Date: Fri Feb 12 15:12:42 2021 -0500
e2fsck: fix error code return in e2fsck_read_extents()
Addresses-Coverity-Bug: 1472586
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 1b25ea248c2335d39968b770a95dda4eae6b6fa4
Author: Theodore Ts'o <tytso@mit.edu>
Date: Fri Feb 12 15:10:11 2021 -0500
libext2fs: fix incorrect error code return in ext2fs_add_jounral_inode3()
Addresses-Coverity-Bug: 1472255
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit bd9ac48c9200bbfb9964d31e33c6aacb26ce49ff
Author: Theodore Ts'o <tytso@mit.edu>
Date: Fri Feb 12 12:04:21 2021 -0500
debugfs: add journal header checks in logdump
Addresses-Coverity-Bug: 1431466
Addresses-Coverity-Bug: 1432478
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 10f9b11b76514794f0a868676327b8219c655364
Author: Theodore Ts'o <tytso@mit.edu>
Date: Fri Feb 12 11:53:23 2021 -0500
badblocks: add error checking for command-line arguments for -b and -c
Also remove a dead assignment (the value of try is overwritten after
the continue statement).
Addresses-Coverity-Bug: 1297515
Addresses-Coverity-Bug: 1464573
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 46fcf7087b557ad3ba18af4996a1cb9ded7c43b5
Author: Theodore Ts'o <tytso@mit.edu>
Date: Fri Feb 12 00:10:06 2021 -0500
ext2_fs.h: use the ext2fs_has_feature_64bits() instead of open coded check
This makes the code a bit cleaner and fixes a false positive warning by
Coverity. (CID #1464576)
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit ea41284998daf106f96112ae3d66226233e86f5a
Author: Theodore Ts'o <tytso@mit.edu>
Date: Thu Feb 11 23:47:32 2021 -0500
e2fsck: add error checking for ext2fs_extent_get_info()
This function can't actually fail today, but in the future it could
return an error, so it's better to add the appropriate error check.
Addresses-Coverity-Bug: #1464579
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 33b9a60c366da5df92d9c1b003aedaf1d0e2008a
Author: Theodore Ts'o <tytso@mit.edu>
Date: Thu Feb 11 10:55:21 2021 -0500
Fix clang warnings on architectures with a 64-bit long
On most systems where we compile e2fsprogs, the u64 type is an
unsigned long long. However, there are platforms (such as the
PowerPC) where a long 64-bits and so u64 is typedef'ed to be unsigned
long instead of a unsigned long long. Fix this by using explicit
casts in printf statements. For scanf calls, we need to receive the
value into a unsigned long long, and then assign it to a u64, after
doing range checks.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit fb874e6ff42bee3ee327afc2651483b83311b445
Author: Theodore Ts'o <tytso@mit.edu>
Date: Thu Feb 11 10:45:13 2021 -0500
mke2fs: fix resource leak on error path when creating inodes
Addresses-Coverity-Bug: 1472856
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit b79f56ce5d8bd95939e3e71986e9da3c50831b35
Author: Theodore Ts'o <tytso@mit.edu>
Date: Wed Feb 10 11:12:49 2021 -0500
tests: fix environmental dependency in m_rootdir_acl
The test script had a dependency on the group id for the "adm" group
being 4. Fixed by hard-coding the group id for the default acl for
the acl_dir directory.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit e5e459c77b3c1afba88e618c0998bab95bec43e4
Merge: c98caa6f df0fe7c9
Author: Theodore Ts'o <tytso@mit.edu>
Date: Tue Feb 9 18:47:24 2021 -0500
Merge tag 'v1.46.1' into debian/master
v1.46.1
commit df0fe7c9a34a9ad5184cb65e31e05a0b4744b954
Author: Theodore Ts'o <tytso@mit.edu>
Date: Tue Feb 9 17:50:25 2021 -0500
Update release notes, etc., for the 1.46.1 release
(Also update some inaccuracies in the 1.46.0 release.)
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit d50ffa90a4f0e3d66fcf92027b9185f13c683aac
Author: Yuri Chornoivan <yurchor@ukr.net>
Date: Tue Feb 9 17:37:28 2021 -0500
po: update uk.po (from translationproject.org)
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 66b6b4869b3d6902e26e3e5bbeb1761d44198ce3
Author: Göran Uddeborg <goeran@uddeborg.se>
Date: Tue Feb 9 17:37:28 2021 -0500
po: update sv.po (from translationproject.org)
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 4a9730000f0e7fc78806ad4a64dc4f296f8ed856
Author: Pedro Albuquerque <pmra@protonmail.com>
Date: Tue Feb 9 17:37:28 2021 -0500
po: update pt.po (from translationproject.org)
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 1f1b285c2cad4ac2f57884d4c2643f2f9b09a4c0
Author: Jakub Bogusz <qboosh@pld-linux.org>
Date: Tue Feb 9 17:37:28 2021 -0500
po: update pl.po (from translationproject.org)
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 1d4a6b2a1e7fb373e117aab143887a8d2e3946b5
Author: Sharuzzaman Ahmat Raslan <sharuzzaman@gmail.com>
Date: Tue Feb 9 17:37:28 2021 -0500
po: update ms.po (from translationproject.org)
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit a9c317cc50d86c6f4a41ba4d7826f9c2007165a0
Author: Samuel Thibault <samuel.thibault@ens-lyon.org>
Date: Tue Feb 9 17:37:28 2021 -0500
po: update fr.po (from translationproject.org)
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 77e1dd3fc07a42f9ec01cf9f121892099fee3d9b
Author: Petr Pisar <petr.pisar@atlas.cz>
Date: Tue Feb 9 17:37:28 2021 -0500
po: update cs.po (from translationproject.org)
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 67e6ae0a354057bdc2639896893196bea7a2f822
Author: Theodore Ts'o <tytso@mit.edu>
Date: Tue Feb 9 17:11:23 2021 -0500
mke2fs: fix a importing a directory with an ACL and inline data
If an inode which is copied into a file system using "mke2fs -d" has
an ACL (or extended attributes) and it is also using inline data, when
the extended attribute(s) are copied in, the inline data gets dropped due to a missing call to ext2fs_xattrs_read().
Addresses-Debian-Bug: #971014
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit b637c57d122f1694275fcd8974e68f7784b5c832
Author: Theodore Ts'o <tytso@mit.edu>
Date: Tue Feb 9 15:56:12 2021 -0500
debian: add build profiles noudeb and pkg.e2fsprogs.no-static
Addresses-Debian-Bug: #966686
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 8c9e2921ecb4f259cd86231c1e5008f72ca6b18a
Author: Theodore Ts'o <tytso@mit.edu>
Date: Tue Feb 9 15:54:12 2021 -0500
configure.ac: convert all help strings to use AS_HELP_STRING
Some help strings were using the deprecated AC_HELP_STRING, and others
were completely hard-coded.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 319b6c4f1cf8adf0dee53e88a93cc6055acfd3ce
Author: Theodore Ts'o <tytso@mit.edu>
Date: Tue Feb 9 15:27:51 2021 -0500
Provide and use sort_r() instead of qsort_r() for portability reasons
The qsort_r() function is specific to glibc. It is not present in the
musl C library. Worse, FreeBSD supports qsort_r, but with an
incompatible interface. So use sort_r() from commit c8c65c1e183d
from the git repository: https://github.com/noporpoise/sort_r
https://github.com/tytso/e2fsprogs/issues/58
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 4e95b372306167c51a5fc8d141eac3e1bcc75140
Author: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Date: Thu Feb 4 15:36:01 2021 -0800
e2fsck: endianness fixes for fast commit replay
There are a few places where the endianness conversion wasn't done
right. This patch fixes that. Verified that after this patch,
j_recover_fast_commit passes on big endian qemu VM.
root@debian-powerpc:~/e2fsprogs/tests# make j_recover_fast_commit
j_recover_fast_commit: : ok
Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 2fae964a0e3d68498a5accfd2fd0780352415660
Author: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Date: Thu Feb 4 15:35:59 2021 -0800
ext2fs: initialize handle to NULL in ext2fs_count_blks
Initialize the handle to NULL to ensure that in error cases,
ext2fs_free_mem can be called on it.
Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit f15b1aaf8f1241ac55057ec61a0d399147fc644b
Author: Andreas Dilger <adilger@whamcloud.com>
Date: Tue Feb 2 01:25:49 2021 -0700
e2fsck: fix check of directories over 4GB
If directories grow larger than 4GB in size with the large_dir
feature, e2fsck will consider them to be corrupted and clear
the high bits of the size.
Since it isn't very common to have directories this large, and
unlike sparse files that don't have ill effects if the size is
too large, an too-large directory will have all of the sparse
blocks filled in by e2fsck, so huge directories should still
be viewed with suspicion. Check for consistency between two of
the three among block count, inode size, and superblock large_dir
flag before deciding whether the directory inode should be fixed
or cleared, or if large_dir should be set in the superblock.
Update the f_recnect_bad test case to match new output.
Fixes: 49f28a06b738 ("e2fsck: allow to check >2GB sized directory")
Signed-off-by: Andreas Dilger <adilger@whamcloud.com>
Lustre-bug-id: https://jira.whamcloud.com/browse/LU-14345
Change-Id: I1b898cdab95d239ba1a7b37eb96255acadce7057
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit d9844883a1148d58844a345abbd35b63321d9eeb
Author: Theodore Ts'o <tytso@mit.edu>
Date: Sun Feb 7 23:27:56 2021 -0500
libext2fs: fix more compiler warnings
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 9f4e9fbbe23b54ccac7412f593704d5948e2007d
Author: Theodore Ts'o <tytso@mit.edu>
Date: Sun Feb 7 23:21:58 2021 -0500
libext2fs: fix segault when setting an xattr with an unknown prefix
Also avoid unnecessary calls to find_ea_index() by caching the short
name and name index in the ext2_attr structure.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit f41c7da2e4342bdc8e7e1a43416958bd874fc771
Author: Andreas Dilger <adilger@dilger.ca>
Date: Sun Jan 24 16:20:06 2021 -0700
misc: fix minor llvm warnings
Fix a couple minor type mismatch warnings.
Signed-off-by: Andreas Dilger <adilger@dilger.ca>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit ee2ee8343ee14f57759ea251e986e0cd390d6ba0
Author: Theodore Ts'o <tytso@mit.edu>
Date: Fri Jan 29 23:35:38 2021 -0500
debian: drop transitional packages
We renamed the libcomerr2, e2fslibs, and e2fslibs-dev packages to
match Debian package naming convetions in Debian 10 (Buster). Now
that Debian 11 (Bullseye) is about to be released, we no longer need
the transitional packages.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 24487a7fa64bfa92bea21be3ca8c155e5de7438f
Author: Theodore Ts'o <tytso@mit.edu>
Date: Fri Jan 29 22:28:31 2021 -0500
configure.ac: fix build failure on systems with pthreads && !fuse support
The configure script checks for pthread.h as part of double-checking
that the FUSE support works correctly, which implicitly defined
HAVE_PHREAD_H. If the FUSE libraries are not present (or fuse support
is explicitly disabled), this check doesn't happen and so
HAVE_PTHREAD_H is not defined, and this causes a build failure.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 2b0d66bbec7807597673b7e00f2d9ff04439c307
Author: Theodore Ts'o <tytso@mit.edu>
Date: Fri Jan 29 16:28:44 2021 -0500
Update release notes, etc., for the 1.46.0 release
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 30d07316e537281a831efd1b60294e72ce86c27c
Author: Theodore Ts'o <tytso@mit.edu>
Date: Fri Jan 29 14:45:44 2021 -0500
Update makefile dependencies
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 2eebc9949ca2904c8d36aad40a28bf5e36f4e53d
Author: Theodore Ts'o <tytso@mit.edu>
Date: Fri Jan 29 01:56:41 2021 -0500
Update debian/libext2fs2.symbols with the additions to the shared library
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit e678ab3970d03741cc16f8b9e2575af981f8f463
Merge: 35b67cab fa86b5c2
Author: Theodore Ts'o <tytso@mit.edu>
Date: Fri Jan 29 01:13:18 2021 -0500
Merge branch 'maint' into next
commit 35b67cab5c3ea4b7f32a6f516f058fe944aa9f4e
Author: Theodore Ts'o <tytso@mit.edu>
Date: Fri Jan 29 01:03:36 2021 -0500
e2fsck: drop use of sysctl(2)
Remove the use of the binary interface using the sysctl(2) system call
since sys/sysctl.h has been deprecated. We can find the total memory
available in the system using the POSIX standard sysconf(2) interface.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 3fb16e742420bf0a5bf9f4e0937b1336245a1011
Author: Theodore Ts'o <tytso@mit.edu>
Date: Thu Jan 28 23:16:46 2021 -0500
configure.ac: add substitution for @mkdir_p@ since po/Makefile.in.in uses it
Fixes: e598c29b4d38 ("Update gettext files to version 0.19.8")
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit c98caa6f1f0fb0894b9ce1a44b9cf67a37f2d8ab
Merge: f095488c fa86b5c2
Author: Theodore Ts'o <tytso@mit.edu>
Date: Fri Jan 29 00:54:39 2021 -0500
Merge tag 'v1.45.7' into debian/master
v1.45.7
commit fa86b5c2aa3f98824e3e717074db13b7802d65b7
Author: Theodore Ts'o <tytso@mit.edu>
Date: Fri Jan 29 00:27:17 2021 -0500
Update release notes, etc., for the 1.45.7 release
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 37226f12ba7e76e7495aa5f402d567e811cebd5e
Author: Мирослав Николић <miroslavnikolic@rocketmail.com>
Date: Thu Jan 28 14:27:00 2021 -0500
po: update sr.po (from translationproject.org)
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 43d9f902b88486ed255e1fdc475e613bca3872f8
Author: Benno Schulenberg <vertaling@coevern.nl>
Date: Thu Jan 28 14:27:00 2021 -0500
po: update nl.po (from translationproject.org)
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit d863dafb606030ab055a8d4f3cfa8eea119b7dce
Author: Sharuzzaman Ahmat Raslan <sharuzzaman@gmail.com>
Date: Thu Jan 28 14:27:00 2021 -0500
po: update ms.po (from translationproject.org)
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 5162872480f88972b432055d67079997c97d7a6c
Author: Theodore Ts'o <tytso@mit.edu>
Date: Thu Jan 28 14:21:09 2021 -0500
misc: fix a spelling nit in the mke2fs man page
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 7f69ca17570d2f7e1c1ef5a1ca6f416306bc1645
Author: Theodore Ts'o <tytso@mit.edu>
Date: Thu Jan 28 01:31:21 2021 -0500
Update Makefile dependencies for lib/e2p and lib/ext2fs
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
commit 6be3ce7a545d3b49199e65cdde709ad51d1be502
Merge: 3304da16 e1af9546
Author: Theodore Ts'o <tytso@mit.edu>
Date: Thu Jan 28 00:52:22 2021 -0500
Merge branch 'maint' into next
commit e1af9546e6a1572cbd7d8b70cf5344b5f7e2f51b
Author: Jiyong Park <jiyong@google.com>
Date: Tue Jan 5 14:43:46 2021 +0900
AOSP: Add assemble_cvd to com.android.virt
assemble_cvd directly or indirectly depends on these modules. To add
assemble_cvd to the com.anroid.virt APEX, these modules are marked as
being available to the APEX.
Google-Bug-Id: 174639526
Test: m com.android.virt
Change-Id: Ibc28d24abd358fb1f8608b3f3d6d06c2746f2d72
From AOSP commit: e70718ecae3cf1e2a26af800734130e003186e7e
commit 643ee34074b4f2c684557c12c55eb8b69c499622
Author: Yifan Hong <elsk@google.com>
Date: Wed Nov 18 18:52:13 2020 -0800
AOSP: tune2fs/resize2fs: make vendor_ramdisk_available.
The vendor_ramdisk variant is dynamic, unlike the ramdisk variant.
Test: builds
Google-Bug-Id: 173425293
Change-Id: I45547b5ea99aae98727121c038129844b7930ed6
From AOSP commit: 073ede3200afeffd82889cb61a71fa1947314476
commit 851d899646eb5fb41a88ec81b5d0db7082bec138
Author: David Anderson <dvander@google.com>
Date: Mon Nov 16 23:19:04 2020 -0800
AOSP: Make libext2_uuid and e2fsprogs headers vendor_ramdisk_available.
This is needed to build snapuserd into the vendor ramdisk.
Google-Bug-Id: 173463595
Test: snapuserd builds
Change-Id: I05d85357ebf47abd0d82e9c6211e854bdf0d5ae9
From AOSP commit: b28c0ef21cf8ebd172a07cfd09551af38366a5a7
commit d89e06515bc841e424ff4260841eddbba1eedab3
Author: Justin Yun <justinyun@google.com>
Date: Wed Nov 11 16:15:33 2020 +0900
AOSP: Add "product_available" to product available modules
"vendor_available" modules were available to product modules.
However, not all "vendor_available" modules are required to be
available to product modules. Some modules want to be available only
to product modules but not vendor modules.
To cover the requirement, we separate "product_available" from
"vendor_available".
"vendor_available" will not provide product available module.
Google-Bug-Id: 150902910
Test: build
Change-Id: I316da0d24bde8b6231114aa80841c59547691152
From AOSP commit: df51b0de40581f52c6515f8775ecd84dc4a50bb0
There is 1 open security issue in bullseye.
You can find information about how to handle this issue in the security team's documentation.
![[bug history graph]](https://qa.debian.org/data/bts/graphs/e/e2fsprogs.png){kind=link}