vcswatch reports that
this package seems to have new commits in its VCS but has
not yet updated debian/changelog. You should consider updating
the Debian changelog and uploading this new version into the archive.
Here are the relevant commit logs:
commit 9498420b102fb90f74a2c148e9a8a38545816cd1
Author: Andreas Henriksson <andreas@fatal.se>
Date: Mon May 3 12:26:04 2021 +0200
Update debian/changelog
commit 1289e48e664210e65978d61725299ffa6c85aead
Author: Andreas Henriksson <andreas@fatal.se>
Date: Mon May 3 12:41:25 2021 +0200
Update symbols for correct SOVERSION
This is caused by upstream fixing their SOVERSION in:
https://github.com/sbabic/libubootenv/commit/c91c150eabdc81ee2e30e09ae14b3a1c793a8148
This should have no practical impact on Debian, since:
- there are no reverse dependencies of libubootenv in the archive!
- both .so files point to same realpath
commit 50d598ca93a796624dd35fd76c5b52e2b1b673de
Merge: a1a3504 ba7564f
Author: Andreas Henriksson <andreas@fatal.se>
Date: Tue May 4 10:14:56 2021 +0200
Merge tag 'v0.3.2'
Fixes
-----
shared library: Link against zlib
Always fsync file writes
Treat '=' as an illegal character in variable names
libuboot_env: fix calculation of usable envsize
Correct initialisations in libuboot_configure
Force writing of environment if default is used
libuboot_env: correct length to usable env size length
libuboot_env_store: fix env double-null termination
uboot_env: fix infinite loop on short read (EOF)
commit ba7564f5006d09bec51058cf4f5ac90d4dc18b3c
Author: Stefano Babic <sbabic@denx.de>
Date: Sat May 1 12:24:30 2021 +0200
Prepare 0.3.2
Signed-off-by: Stefano Babic <sbabic@denx.de>
commit f4ab25ded1b92b9a260253ad3a9e8722b4f23797
Author: Reto Schneider <reto.schneider@husqvarnagroup.com>
Date: Tue Apr 27 13:22:38 2021 +0200
shared library: Link against zlib
Library is using crc32(), therefore needs to link against zlib.
Signed-off-by: Reto Schneider <reto.schneider@husqvarnagroup.com>
Reviewed-by: Stefano Babic <sbabic@denx.de>
commit e663439e3d39a4cdbddb7e818245a99c485fa965
Author: Brandon Maier <brandon.maier@rockwellcollins.com>
Date: Tue Mar 2 12:48:57 2021 -0600
Always fsync file writes
Currently fsync() only gets called at the end of fileprotect(), which
only occurs on mmcblk devices. I am storing a U-Boot environment inside
a fat32 filesystem, so the fsync() call does not get hit, and so the new
environment may be lost if power is lost.
Instead always fsync after the write has completed, regardless of the
device type.
Signed-off-by: Brandon Maier <brandon.maier@rockwellcollins.com>
Acked-by: Stefano Babic <sbabic@denx.de>
commit 80b7f316ee20db5985741e04ce9dc2aa3139bc92
Author: Brandon Maier <brandon.maier@rockwellcollins.com>
Date: Mon Mar 1 16:42:11 2021 -0600
Treat '=' as an illegal character in variable names
U-Boot's setenv command has treated '=' as an illegal character since
2006[1]. Per the original commit there is some form of backdoor when
doing commands like 'setenv ethaddr=', which it seems reasonable for us
to avoid.
For me, I have problems with users accidentally running `fw_setenv
var=value` (as it's a common idiom in shell scripting) and fw_setenv
prints no error as it thinks user wanted to delete a variable named
'var=value'.
Detect and return an error in libuboot_set_env(). Also detect in
fw_setenv() so we can print a user-friendly error message.
[1] https://source.denx.de/u-boot/u-boot/-/commit/471a7be7a042e95e440f5de969c9765214ae8d6e
Signed-off-by: Brandon Maier <brandon.maier@rockwellcollins.com>
Acked-by: Stefano Babic <sbabic@denx.de>
commit 950f541889063df1043a0227a9715a57080cbd35
Author: Sava Jakovljev <sava.jakovljev@teufel.de>
Date: Wed Dec 16 16:48:37 2020 +0100
libuboot_env: fix calculation of usable envsize
* Adjust calculated usable envsize in case redundand environment is used.
Signed-off-by: Sava Jakovljev <sava.jakovljev@teufel.de>
Acked-by: Stefano Babic <sbabic@denx.de>
commit fb880329796278bbed55853a6c126cbaa3d08f61
Author: Alex Kiernan <alexk@zuma.ai>
Date: Sun Jan 10 10:53:24 2021 +0000
Correct initialisations in libuboot_configure
libuboot_configure() fails to initialise dev->offset from the envdevs
structure and also doesn't setup ctx->size as happens in
libuboot_read_config(); use the same logic as exists there.
Signed-off-by: Alex Kiernan <alexk@zuma.ai>
Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
commit 20d1ec784eda20f8b5a09e9dd8b186b1a3626b14
Author: Wang Xin <xin.wang7@cn.bosch.com>
Date: Tue Dec 15 17:50:25 2020 +0100
Force writing of environment if default is used
Before commit ed1a53ec "Dont store to device if no value changes" it was
possible to fill an uninitialized or broken environment using the
command "fw_setenv -f <default-environment-file>". This was considered
to be a feature.
The problem occurs because fw_setenv will now skip writing the
environment in case no environment variables to be changed are passed to
fw_setenv.
This commit will fix this problem by always storing the environment if
loading the environment failed and a default environment was given.
Signed-off-by: Wang Xin <xin.wang7@cn.bosch.com>
Signed-off-by: Mark Jonas <mark.jonas@de.bosch.com>
Acked-by: Stefano Babic <sbabic@denx.de>
commit 5ca11bd9632073173f778f029780959db83317d5
Author: Manuel Dipolt <mdipolt@robart.cc>
Date: Wed Nov 25 17:41:42 2020 +0100
libuboot_env: correct length to usable env size length
ctx->size would be correct from start of struct / environment,
however usable environment payload starts from data header (offsetdata)
Signed-off-by: Manuel Dipolt <manuel.dipolt@robart.cc>
Acked-by: Stefano Babic <sbabic@denx.de>
commit cd4a8f1b894671eb4e809af814563d4b01835fae
Author: Sami Hartikainen <sami.hartikainen@teleste.com>
Date: Tue Oct 13 15:36:32 2020 +0300
libuboot_env_store: fix env double-null termination
Environment lines are terminated with a single null byte, followed
by another null byte to terminate the env itself. Fix termination
in case where flags need saving.
Signed-off-by: Sami Hartikainen <sami.hartikainen@teleste.com>
commit 95101640b28501bcc1971db30115905c2320fafa
Author: Christian Storm <christian.storm@siemens.com>
Date: Tue Oct 13 08:35:23 2020 +0200
uboot_env: fix infinite loop on short read (EOF)
If the U-Boot environment configuration file fw_env.config happens
to have specified a length larger than the actual file's size, the
result is an infinite loop. Hence, check read()'s return value for
being 0, meaning EOF, and return an error.
Signed-off-by: Christian Storm <christian.storm@siemens.com>
Acked-by: Stefano Babic <sbabic@denx.de>
commit 824551ac77bab1d0f7ae34d7a7c77b155240e754
Author: Stefano Babic <sbabic@denx.de>
Date: Fri Sep 4 22:05:39 2020 +0200
Prepare 0.3.1
This contains fixes for environment on UBI volumes or I2C Eprom.
Signed-off-by: Stefano Babic <sbabic@denx.de>
commit ca6aaa1659314371b35922cd0b4350d6fa9410ad
Author: Adrian Bunk <bunk@stusta.de>
Date: Thu Sep 3 12:06:44 2020 +0300
Fix file reading/writing when the environment is in EEPROM
Trying to use fw_printenv/fw_setenv with
/sys/bus/i2c/devices/0-0050/eeprom always fails for me:
$ fw_printenv
Cannot read environment, using default
Cannot read default environment from file
$
The problem is that fileread() and filewrite() in src/uboot_env.c
read/write once, and callers treat it as error if they did read/write
fewer bytes than requested.
In C it is not an error if fewer bytes get read/written than requested,
the caller is supposed to retry with the remaining bytes until everything
is done or an error occurs.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
commit a031dea2bf42c37f7e2e9c515952efc412563e2a
Author: S. Lockwood-Childs <sjl@vctlabs.com>
Date: Thu Aug 20 01:28:43 2020 -0700
Fix regression in UBI volume support
Running realpath() directly on the name parsed from the env config file
fails in the special case of UBI volume syntax, e.g.
/dev/ubi0:env
^^^------ UBI volume name
That special case with UBI volume name is handled by ubi_update_name(),
which doesn't happen early enough for normalizing the device path.
With above example, libuboot_read_config() would attempt to normalize
"/dev/ubi0:env" which does not exist.
Separate out the path normalization into a helper function that splits
off any volume part (e.g. ":env") before trying to normalize the path,
then appends the volume part to the normalized path.
Signed-off-by: S. Lockwood-Childs <sjl@vctlabs.com>
commit c91c150eabdc81ee2e30e09ae14b3a1c793a8148
Author: Stefano Babic <sbabic@denx.de>
Date: Sun Aug 16 18:21:02 2020 +0200
Define SOVERSION to indicate API version
Signed-off-by: Stefano Babic <sbabic@denx.de>
Suggested-by: Sami Hartikainen <oktetti@gmail.com>
![[bug history graph]](https://qa.debian.org/data/bts/graphs/libu/libubootenv.png){kind=link}