commit 29ebe17fe83de94e9353e15e3ff6165440523424
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Aug 12 18:26:57 2020 -0700
Use the new centralized streaming tar unpacker for the Control index.
Gbp-Dch: ignore
commit 22e99e6e30cd181b4dfbb4d233f577a5658f321c
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Aug 12 17:37:56 2020 -0700
Use the new centralized streaming tar unpacker for the Installed index.
Gbp-Dch: ignore
commit 43d566011e63b84877d877e92f604a64a6869f9d
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Aug 12 17:14:31 2020 -0700
Provide a centralized facility to create an index from a streamed tar file.
These routines are performance sensitive and error-prone. This commit makes
a trusted implementation available for reuse in other indices, such as
Control or Orig.
The code is currently written with IO::Async. It may be replaced with other
routines or IPC framework in the near future.
Gbp-Dch: ignore
commit de21b79bbbddd20a98ef59d7703d6aea096ab7cb
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Aug 13 10:12:27 2020 -0700
Merge the routines Group::unpack and Group::process.
Resolves some long-standing code dislocations that occurred or became
apparent when the Unpacker was merged into Group.
Uses Processable::Fields::Files instead of parsing dsc, changes and
buildinfo files manually.
Brings the routines ->init and ->unpack in the instantiated subclasses for
each kind of Processable closer together (from a code path perspective).
Uses lazy instantiation for some attributes instead of explicit caching.
Gbp-Dch: ignore
commit c9b24e049af713084c6643aeafd77ad2511fc4ee
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Aug 13 09:48:10 2020 -0700
Fix the unpacker chdir bug.
Cures an annoying little bug (actually, two) that made it necessary to
insulate the unpacking from clean up with protective chdir() statements.
The offending routines in the unpacker returned under some conditions before
their saved directories could be restored.
Gbp-Dch: ignore
commit ebda3b90e259c4b79b8dd1353dce29437a5cfc1f
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Aug 13 06:02:14 2020 -0700
Merge Processable::Source::Diffstat into Processable::Diffstat.
Left over from when collections were separate. Also eliminates a needless
parsing of the dsc.
Gbp-Dch: ignore
commit 4b878e14d9758f7b44210ae65fc26acd30c67dc6
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Aug 12 20:55:07 2020 -0700
Un-deprecate /etc/lintianrc; remove file on upgrade and ship in doc/examples. (Closes: #968326)
Due to a rewrite of how configuration files were handled, the file
/etc/lintianrc was no longer read. The manual page mentioned that the
location became obsolete in version 2.5.12, released in April of 2013.
After consultation, the location /etc/lintianrc was un-deprecated. The XDG
location in /etc/xdg is less well-known. It was also unclear to the author
how XDG_CONFIG_DIRS could be considered.
Stops shipping a sample config file in /etc and places the file in
/usr/share/docs/lintian/examples instead.
On upgrade, removes /etc/lintianrc if the file was unchanged and installed
by a version prior to 2.90.0. The use of rm_conffile was based on dbus.
In the manual page, removes the deprecation comments and suggests the
user-based XDG location. States that files are searched in the order listed.
Corrects the order with respect to XDG_DIR/lintian/lintianrc, which was
actually preferred over ~/.lintianrc.
Thanks to Simon McVittie, Bastian Blank and others for providing guidance
and specific pointers, especially to dpkg-maintscript-helper(1).
Thanks to Joao Eriberto Mota Filho for reporting this issue! Please reopen
the bug if it was closed in error.
commit 1843a07faead279e05ff22082df7c372c61404bf
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Aug 12 17:02:22 2020 -0700
Move tests for non-existing unpack errors to the checks issuing the related tags.
The tests were placed in the index collection code, but there they triggered
additional file operations (removal), They were also duplicated in several
places. Moves them to a central place for better maintenance.
As a side note, the file tests -s and -z always return false for files that
do not exist.
The error mechanism is described here, but probably widely ignored:
https://perldoc.perl.org/functions/-X.html
Gbp-Dch: ignore
commit efc0b41d3e6b9878b5175ff183fc2dca332e4da7
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Aug 12 14:12:39 2020 -0700
In Index::Patched, use IPC::Run3 instead of IO::Async.
Part of a longer commit chain to avoid mystery bugs in Lintian proper.
Gbp-Dch: ignore
commit ac7f967a036e3e6167abb605d0550c838667c06d
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Aug 12 08:20:55 2020 -0700
In Index::Orig, use IPC::Run3 instead of IO::Async.
Part of a longer commit chain to avoid mystery bugs in Lintian proper.
Gbp-Dch: ignore
commit 5d4f56a671f427b5a1313fac87addc06764dc955
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Aug 12 10:52:06 2020 -0700
Move to all executables not meant for shipping to ./private.
For a brief while, some programs from t/bin were shipped to users in ./bin.
End users did not need them, and could potentially be confused by their
presence.
Those programs can now be found in the source tree in ./private and are no
longer shipped.
commit db6a8805f4ad5d4b0fb74f1710024e9579b9d588
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Aug 12 11:53:11 2020 -0700
Drop .pl extension from generate-profiles; use advanced Deb822 facilities.
According to policy 10.4, the script's name should not include the .pl
suffix. It was removed here.
Additional build prerequisites are not required for the full Deb822
facilities. The script is mentioned in d/rules, but it does not run
automatically.
Otherwise, modules such as Moo and List::Compare would be required.
Gbp-Dch: ignore
commit 934bd3f5b1ed244319fdbc4afdc46d8bb263d402
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Aug 12 12:05:46 2020 -0700
Use fixed Lintian POD; no longer needs to be generated; drop script.
The generating script extracted information from check declaration files
that fell out of use some time ago. Drops the generation script.
Renames the *.pod.in to *.pod and uses the file directly.
Gbp-Dch: ignore
commit 131c1b6ca6f854ec91d69b164fc9580f594df701
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Aug 12 12:08:20 2020 -0700
Revert previous commit; minimize use of Lintian modules in build process.
Upon inspection, safe_qx was not required for the 'git describe' operation.
Uses Perl's regular qx{} operator instead without compromise in security.
Reverts the previous commit 6e299877 and again removes libipc-run3-perl from
Depends in d/control. Provides a better and simpler solution.
This commit avoids the complications that would arise from managing complex
(but hardly necessary) build prerequisites in d/control.
commit 6e2998775807cdf6ea11cb70b2312b32e5b16404
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Aug 12 11:01:20 2020 -0700
Add libipc-run3-perl to Build-Depends in d/control.
Should fix the build failure in Gitlab CI.
commit 4d81a26ce41242be06dfe35bdf2b0227dec7581f
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Aug 12 10:13:48 2020 -0700
Use matching Lintian modules for all private utilities.
These programs were unable to locate Lintian's non-public modules reliably.
They often used installed versions, which worked fine when running from the
source tree. That was their primary mode of operation.
Now these scripts should find the Lintian modules automatically. Some are
dated and have not been used recently. Only some scripts were tested for
correct operation.
This should fix a pipeline failure on Gitlab.
Gbp-Dch: ignore
commit da06b95398fc878fdf2dc21f3b7fe1a98fea8cb3
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Wed Aug 12 08:14:22 2020 -0700
Further reduce reliance on IO::Async in Lintian proper and run-time utilities.
The Lintian executable has too many checks and draws on too many third-party
modules to allow the general use of IO::Async. The module works great in the
test suite but in Lintian proper it contributed to mysterious bugs.
The mystery bugs occurred most likely because some modules spawned processes
with methods other than IO::Async. That caused conflicts because IO::Async
replaces the SIGCHLD handler.
A decision was therefore made to reduce the reliance on IO::Async in Lintian
proper. In many cases, IPC::Run3 was sufficient.
The complex operations when indices are created from tar files may have to
be implemented with more basic components such as IO::Handle and IPC::Open3.
Gbp-Dch: ignore
commit 12e1e6b7521dac78b0fbd88eda561ae5002fbaa9
Author: Andrius Merkys <merkys@debian.org>
Date: Wed Aug 12 02:58:59 2020 -0400
Fix typo in breakout-link.desc.
commit 007460739c67e0c799dd025a4a922e9647f4df5d
Author: Felix Lechner <felix.lechner@lease-up.com>
Date: Thu Aug 6 09:18:40 2020 -0700
Announce left-over processes before exiting.
Most of the time, left over processes are done already and merely have an
unreaped exit status (so-called zombies). In that case, the table is not
very interesting.
Compared to the previous code, this code also provides greater details for
processes that are still running, although that should never occur during
normal operation.
Gbp-Dch: ignore
commit 426f70fc35c2177ae09a2c1b98f4eef46139e111
Author: Chris Lamb <lamby@debian.org>
Date: Mon Aug 10 11:01:29 2020 +0100
Open new changelog entry.
Gbp-Dch: ignore
Automatic checks made by the Debian l10n team found some issues with the translations contained in this package. You should check the l10n status report for more information.
Issues can be things such as missing translations, problematic translated strings, outdated PO files, unknown languages, etc.
![[bug history graph]](https://qa.debian.org/data/bts/graphs/l/lintian.png){kind=link}