There are 10 open security issues in bookworm.
There are 9 open security issues in bullseye.
commit 33595723891cd07f4e9ca40880cbfced98d07182
Merge: fdd30b63 cad8c4f4
Author: Ken McDonell <kenj@kenj.id.au>
Date: Tue Nov 17 07:52:17 2026 +1100
Merge pull request #2789 from kmcdonell/wip
Rework /proc/cpuinfo parsing for Linux PMDA
commit cad8c4f458327b41f53b011fffee1734f8ded870
Author: Ken McDonell <kenj@kenj.id.au>
Date: Tue Nov 17 07:38:52 2026 +1100
linux PMDA: rework non-parallel generation of arm_cpuinfo.? files
commit c69e696fbccd722a9d655a3e5ad897dc6f9ab0ba
Merge: 039635c3 b961aad6
Author: Ken McDonell <kenj@kenj.id.au>
Date: Tue Nov 17 06:59:16 2026 +1100
Merge branch 'wip'
commit 039635c32e558754f56caa9f1f3ac4bda1e91978
Author: Ken McDonell <kenj@kenj.id.au>
Date: Tue Nov 17 06:57:50 2026 +1100
linux PMDA: tidy up some of the arm_cpuinfo* and proc_cpuinfo* changes
Small improvements based on @coderabbitai feedback in the context
of PR #2789.
commit b961aad654a8b401d14f1aaddebf5bc371b0272a
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon Nov 16 21:35:43 2026 +1100
qa/admin/post-setup: handle Time zone: and Timezone: for timedatectl status
commit c699342a07a8fb0a4099ed1a032a4eecf978494f
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon Nov 16 21:32:58 2026 +1100
qa/admin/pcp-daily: can't run mac-deb and mac-fed on bozo
commit 383340e4bfc402608e0fdb0213680ac3f5f4f363
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon Nov 16 21:31:01 2026 +1100
qa/src/fakeuname.c: drop domainname ... it is not portable
commit e011606baf3ca8f5f5e8d312155791744bf584c2
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon Nov 16 21:30:12 2026 +1100
qa/admin/pcp-daily: tweak utm vm handling
commit ffa44122d16ebb768804be5ddf43f018f87fe74b
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon Nov 16 17:53:19 2026 +1100
qa/admin/pcp-daily: add warning if not run from base of repo and -g special case cannot be done
commit 0ef5e39967cb2819f2dda32fba204e293f8ecc84
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon Nov 16 16:56:31 2026 +1100
qa/885: fix $debug setting for all data cases
commit bda3fd9e471ae5f5b5c4379f277640acdff61206
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon Nov 16 16:54:23 2026 +1100
qa/1743: valgrind dual for qa/1741
commit 4a26ad70c7f4cff8fae6c3c9d0633a21e571964d
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon Nov 16 14:54:03 2026 +1100
linux PMDA: refactor /proc/cpuinfo parsing
Add architecture-dependent parsing and rework order of
checks for each cpuinfo line.
Additional diagnostics with -Dappl9.
New qa/1741 that is like qa/885, but tries to reconcile PCP values
for vendor, model, model_name, ... against lscpu(1) -s output.
Resolves https://github.com/performancecopilot/pcp/issues/2470
commit b52d4807af3139cbd565abc8f821c16e8254ae19
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon Nov 16 13:29:00 2026 +1100
qa/885: and linux/cpuinfo-* files
- rename some files to allow architecture to be embedded in the
name ... used in concert with uname() wrapper to force linux
PMDA to use the correct architecture-dependent method(s) when
parsing cpuinfo files
- additional cpuinfo files from Christian Horn
commit 8a22f7f958c5d97962a0eecee30ae5a404e54313
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon Nov 16 13:25:44 2026 +1100
qa/src/fakeuname.c: uname() wrapper DSO for use with LD_PRELOAD
Allows utsname fields to be selective clobbered to support QA, e.g.
FAKEUNAME_MACHINE=aarch64 LD_PRELOAD=.../src/fakeuname.so will allow apps
(like the linux PMDA) to think they're running on aarch64.
commit c9fd901f86c1bd300685bbcae4236fd61bce2e93
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Nov 14 21:25:15 2026 +1100
src/pmdas/linux/GNUmakefile: fix parallel make race associated with mk.arm_cpuinfo
commit e1b6869a3e2d67a9e2618135ba3c740ccfe37a81
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Nov 12 07:46:44 2026 +1100
admin/post-setup: tweak for (old) timedatectl(1) on CentOS 7
commit 7b3bc8dc62a79c6fe2efd3298b611f9fad08762f
Merge: b4362a98 fdd30b63
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Nov 12 06:51:51 2026 +1100
Merge branch 'main' of https://github.com/performancecopilot/pcp
commit b4362a984210cf551a4f346a1c163c636d410dda
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Nov 12 06:50:28 2026 +1100
linux PMDA: more refinements for hinv.cpu metrics on arm64
commit 5470b9fb3f50806b59872dc2071b359e3e06ad7b
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Nov 12 06:47:08 2026 +1100
qa/admin/package-lists/OpenIndiana+2026.10+i86pc: new package list
commit fdd30b634c13570bb9679b34b871a59291380998
Author: kurik <jkurik@redhat.com>
Date: Wed Nov 11 15:51:29 2026 +0100
fix: Leftovers after removing RPMs (#2786)
* build: install parent directories for docs, icons and bpftrace examples
Several directories were only ever created implicitly by install-sh
when a leaf directory was installed. Because install-sh only records
explicitly created directories in $DIST_MANIFEST, these parents were
never listed in any RPM and so were left behind after package removal:
/usr/share/doc/pcp-doc
/usr/share/pcp-gui
/usr/share/pcp/pmdas
/usr/share/pcp/pmdas/bpftrace
Create them with the -d option first so they are owned by a package,
following the pattern already used elsewhere in the tree.
This addresses the remaining 'missing from our makefiles' cases from
https://github.com/performancecopilot/pcp/issues/2229
commit 1dd9baa68bda558c9987c5c3d380e4f3916a76ce
Merge: 596d3d90 632bcfd1
Author: Nathan Scott <nathans@redhat.com>
Date: Wed Nov 11 10:37:17 2026 +1100
Merge branch 'fix/atop-service-acct-uaf'
commit 27592f4325520c92e24de9d9e6ba340620bdc92d
Author: Ken McDonell <kenj@kenj.id.au>
Date: Tue Nov 10 14:35:47 2026 +1100
vendor/github.com/util-linux/sys-utils: rename and update
Was vendor/github.com/util-linux but the extra sys-utils directory
better matches the github path.
Improve refresh-me to allow additional files to be included
easily as required.
Add lscpu.h.
commit 632bcfd1cf1e4d6a2d62055640aaac92a717369c
Author: Nathan Scott <nathans@redhat.com>
Date: Sun Nov 8 10:40:46 2026 +1100
atop, selinux: fix service-stop handling and pacct unlink denial
Two gaps found while reviewing the previous commits:
- atop-daily.service restarts atop.service unconditionally. Now that
the timer outlives the service (Wants rather than BindsTo), the daily
maintenance run would start atop again after an administrator had
deliberately stopped it. Use try-restart so a stopped service stays
stopped.
- pcp_import_t was allowed to add and remove names in pcp_var_lib_t and
to create and setattr the private accounting file, but not to unlink
that file. Unlinking needs both remove_name on the directory and
unlink on the file itself, so close_pacct_file() still triggered an
AVC and left $PCP_VAR_DIR/pmcd/pacct behind after accounting stopped.
Grant file unlink as well.
Signed-off-by: Nathan Scott <nathans@redhat.com>
commit 4a2245f18261d07719c2f162c432bc7ee7b73497
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sun Nov 8 08:04:06 2026 +1100
scripts/start: better separation of stdout and stderr
commit e942223f7dac621612873fbf05a8ceeb1729e821
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sun Nov 8 07:56:57 2026 +1100
vendor/github.com/util-linux/lscpu-arm.c: new vendor'd file
Since there is no API for getting CPU identity info, we're going to base
our code for aarch64 (aka arm64) in the linux lscpu(1) code.
The refresh-me script in the same directory will update our copy if the
github version changes.
The plan is to slice-n-dice this code over in the PCP linux PMDA build to
support better hinv.cpu.model and hinv.cpu.vendor metric values.
commit 2e765976c23d682007a82fb1e0e70619605d3a75
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sun Nov 8 07:21:41 2026 +1100
qa/1738 and qa/1965: exercise novalue() and novalue(meta=...) in both tests
commit f27cd47987fa788a467238b049f6db22065e8877
Merge: 76de01ff 596d3d90
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sun Nov 8 07:18:55 2026 +1100
Merge branch 'main' of https://github.com/performancecopilot/pcp
commit 596d3d90a161e4682b3a237f9d7486aeee44c785
Merge: 9a98a0b3 71473a80
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sun Nov 8 07:11:55 2026 +1100
Merge pull request #2780 from kmcdonell/wip
QA, small code refinements and fix for issue #2779
commit 71473a8096e8375d7480e5a4ee43fcf425fe7164
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Nov 7 16:44:29 2026 +1100
qa/1339: changes suggested by @coderabbitai
- quoting
- saving and reporting stderr for failing commands
commit ca5978481cea2ca59a80617ecf57c950395fe3fa
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Nov 7 16:43:07 2026 +1100
scripts/start: rework
Drop the whole "where is the base of your gir tree" pile of steaming ...
go back to only known and trusted places for pcp.conf and common.check.
Clean up some other quoting and exit status issues.
commit 368f03d5b55c8bd956c7a87d17090391711c1392
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Nov 7 16:18:43 2026 +1100
src/libpcp/src/derive_fetch.c: another (obscure) corner case with ternary op and novalue()
In the context of PR #2780, @coderrabitai culled this one out of thin air:
guard ? novalue(meta=metric) : metric
and asserted this would SEGV.
New qa/1965 (and the valgrind dual qa/1966) showed this assertion to be
true.
Fixed by some extra logic in eval_expr() to guard against the
novalue(meta=metric) case where the expression N_NOVALUE node has a pmDesc
and if the metric has an indom, then desc.indom is not PM_INDOM_NULL but
this node in the expression tree will never have any instances ... so
force the instance enumeration onto the other operand node.
commit ef11e53e861785c6ab93a787cfb7250b073e143c
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Nov 7 16:17:28 2026 +1100
src/libpcp/src/tz.c: tweak logic, comment on Solaris TODO for TZ= quoting
Based on suggestions from @coderabbitai in the context of PR #2779.
commit 76de01ff52ae3aa37b60497f03bfde282ee402c9
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Nov 7 08:20:51 2026 +1100
qa/new: check that groups provided are defined in the group file
commit 35ae720e3e1f4f5afcb27c6eb4b301337319dbf5
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Nov 7 08:00:24 2026 +1100
qa/admin/pcp-daily: changes for UTM VMs on Mac
There was lots of hard-coded virsh stuff in here (e.g to check the status
of a VM, start a VM, stop a VM) that had to be made conditional and augmented
by the utm equivalent functionality.
The Macbook in the QA Farm is now running PCP QA on Debian and Fedora VMs.
Scratch another itch as well: to run a group of QA tests required
$ pcp-daily -q -g '-g somegroup'
and the -g -g bit had always bugged me and frewquently bitten me when the
second -g was not specified (this syntax exists for a good reason, e.g.
-g "1-10 -x foo -g bar"), but now -g somegroup is a shorthand alias for
-g '-g somegroup'.
commit 9fc806c8e08a91b7fda498155dcc5f5cb3718dcd
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Nov 7 07:58:40 2026 +1100
qa/admin/post-setup: changes for UTM VMs on Mac
These ones do not have bridged networks, so all of the networking
setup is done when the VM is built ... needed to add conditional
control to skip big chunks of the work if it is not required.
commit 3560d3bc017fb4f64c24c89a52f7ec3747100c36
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Nov 7 07:57:57 2026 +1100
qa/admin/package-lists/Fedora+44+aarch64: package list updates
commit 86a91990b2c438c187b9aebf910fda491ae2441c
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Nov 7 07:48:32 2026 +1100
src/libpcp/src/derive_fetch.c: fix for ternary expr with novalue()
Resolves https://github.com/performancecopilot/pcp/issues/2779
Also new qa: 1738 and 1739
commit 066029a2cc760b8854eb70ece8a2f4ed50b30527
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Nov 7 07:34:25 2026 +1100
man/man1/pcpintro.1: fix indentation for -s block
commit eb6f7c9484c93230922ddaf837660698ddf2c937
Author: Ken McDonell <kenj@kenj.id.au>
Date: Fri Nov 6 06:56:34 2026 +1100
src/libpcp/src/lock.c: change lock in SetupDebug()
As reported in Coverity CID 505912 there was a lock inversion between
pmflush() holding lock_util and then aquiring __pmLock_extcall via
SetupDebug() which is called from __pmInitLocks() which is called
from __pmProcessAddArg().
Change the locking in SetupDebug() to use the existing local and
low-level lock lock_lock.
commit b6b0368412996ac147f21fb5784aed0982fb1ec5
Author: Ken McDonell <kenj@kenj.id.au>
Date: Fri Nov 6 06:36:28 2026 +1100
src/python/pmapi.c: plug small memory leak
in setOptionHost(), __pmAddOptHost() strdup's the host argument so
free(host) needed on the success path.
Fixes Coverity CID 506007
commit 079204264424c5ee9e91b0cdb9473b4d0508a696
Merge: d82fc5d6 9a98a0b3
Author: Ken McDonell <kenj@kenj.id.au>
Date: Fri Nov 6 06:11:07 2026 +1100
Merge branch 'main' of https://github.com/performancecopilot/pcp
commit d82fc5d6d88089518cc7b4e729d15ab836980023
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Nov 5 22:00:18 2026 +1100
src/libpcp/src/tz.c: Solaris change use /etc/default/init instead of /etc/TIMEZONE
The latter is a symlink to the former.
commit 9a98a0b36c8f94382f0748d7b08c025e34f9f8c0
Merge: aacfff8c 876d72ff
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Nov 5 21:53:03 2026 +1100
Merge pull request #2777 from kmcdonell/main
Post-Halloween Mystery Bag
commit a738fb2fede5606271af525bb39ce9e93a65a303
Author: Nathan Scott <nathans@redhat.com>
Date: Thu Nov 5 18:43:21 2026 +1100
qa: suppress benign acct(NULL) valgrind report
pmda_proc disables process accounting using acct(NULL), which is the
documented way to turn it off, but valgrind's syscall parameter checker
reports the NULL filename pointer as unaddressable:
Syscall param acct(filename) points to unaddressable byte(s)
at 0x4B4FB0C: acct (in /usr/lib64/libc.so.6)
by 0x59A4FD3: close_pacct_file (acct.c:296)
by 0x59A8E03: reopen_pacct_file (acct.c:415)
by 0x59A8E03: acct_store (acct.c:818)
Suppress this known-benign case so qa/2009 can check for real invalid
accesses in the acct(5) expiry garbage collection path.
Signed-off-by: Nathan Scott <nathans@redhat.com>
commit 7a4ec15b73748785d749743e0e18541ba259f470
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Nov 5 17:42:05 2026 +1100
src/libpcp/src/tz.c: strip at first whitespace (not just \n) in __pmZoneinfo()
In the Solaris case, when parsing a TZ= line from /etc/TIMEZONE.
commit 98043638619ca063fb8ddc99d27c7c90340b4f3d
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Nov 5 17:34:06 2026 +1100
src/libpcp_pmda/src/pduroot.c: save errno before calling pmNotifyErr()
In __pmdaRecvRootPDUStartReq() and __pmdaRecvRootPDUStart().
commit 78dc0603fa6d11c3fe6d0f2b40b7cc5d4356cb7d
Author: Nathan Scott <nathans@redhat.com>
Date: Thu Nov 5 16:52:09 2026 +1100
selinux: fix pcp_import_t denials for pacct and RPC metrics
Runtime AVCs reported from pcp-atop running in the pcp_import_t domain:
avc: denied { add_name } for comm="pcp-atop" name="pacct"
tcontext=system_u:object_r:pcp_var_lib_t:s0 tclass=dir
avc: denied { search } for comm="pcp-atop" name="rpc"
tcontext=system_u:object_r:sysctl_rpc_t:s0 tclass=dir
The first is pmda_proc setting up private process accounting: it
creates and truncates $PCP_VAR_DIR/pmcd/pacct and unlinks it again
when accounting is stopped. The existing pcp_var_lib_t directory
"write" allow does not imply add_name/remove_name, and the file
create and setattr checks (O_TRUNC) were also missing, so grant the
full set explicitly.
The second comes from the linux PMDA reading /proc/net/rpc/nfs and
/proc/net/rpc/nfsd, which are labelled sysctl_rpc_t rather than
sysctl_net_t. Add the kernel_read_rpc_sysctls() interface for
pcp_import_t, and for sysstat_t too since sadc exercises the same
local-context DSO PMDA code path.
Signed-off-by: Nathan Scott <nathans@redhat.com>
commit 86b640502a2f6682f6cd094b969eb4bb7813acf4
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Nov 5 15:55:57 2026 +1100
src/libpcp_pmda/src/open.c: use wide options to ps(1) in openBSD desperate diagnostic in __pmdaOpenSocket()
commit f34200bcd7d22f0d07cc9e91c355cf4b8a970fff
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Nov 5 15:54:33 2026 +1100
scripts/start: better logic to find pcp.conf and common.check
commit c121a8d1bc8be710b3c7c57483992b5e61ae7e9f
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Nov 5 15:38:16 2026 +1100
qa/admin/install-packages: handle Solaris version of pkg(1)
install does not have a -y option.
commit a8c2282ac83f3406902d7ea1021d6a7d3b08bffb
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Nov 5 15:37:27 2026 +1100
qa/1339: guard against $PCP_RUN_DIR/pmcd.pid missing or empty
commit bb9105a566e4598a2e6b16af94f1efdc71caaabc
Author: Nathan Scott <nathans@redhat.com>
Date: Thu Nov 5 13:27:43 2026 +1100
atop: fix service shutdown and pmda_proc acct use-after-free
Fix several independent problems that made "systemctl status atop"
report failure and could crash pcp-atop when it fell back to a local
context:
- pmda_proc: free_entry() dereferenced node->data after __pmHashDel()
had already freed the hash node, a use-after-free in acct expiry GC.
Save the data pointer before deleting the node.
- pcp-atop: cleanstop() takes an exit code, but was installed directly
as the SIGHUP/SIGTERM handler, so normal shutdown exited with the
signal number (15) and systemd marked the service failed. Use
wrapper handlers that exit 0.
- pcp-atop: photosyst() returns MRESET on a failed fetch, including
normal end-of-archive and transient pmcd loss. Do not treat this as
fatal in generic mode; exit 0 at archive end and retry otherwise.
- pcp-atop: check fetch_metrics() results in acctproc, gpucom, ifprop
and netproc so a failed fetch is not used as a valid pmResult.
- systemd: remove the circular BindsTo between atop.service and
atop-daily.timer; use Wants so the timer starts with the service but
survives a service stop.
QA:
- qa/2006: replay an archive past its end and verify a clean exit.
- qa/2007: verify timer startup, clean stop result and timer state.
- qa/2009: new valgrind/dbpmda test for the acct GC use-after-free.
Signed-off-by: Nathan Scott <nathans@redhat.com>
commit 876d72ffaa0bf1d41bd4a4a234f5c790625317af
Merge: 4fbd59d1 27f1a4bd
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Nov 5 08:15:18 2026 +1100
Merge branch 'main' of https://github.com/kmcdonell/pcp
commit 4fbd59d18cadcffd9d25780661b025ded7823c93
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Nov 5 08:03:18 2026 +1100
src/libpcp/src/util.c: extend buffer for "append pid" link name in logreopen()
commit 00795990cc09a1f9dd6624a201fbe483e06564eb
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Nov 5 07:56:04 2026 +1100
src/libpcp_pmda/src/open.c: report bind error before OpenBSD desperate diagnostics
In __pmdaOpenSocket(). Spotted by @coderabbitai.
commit 70537b94303aa1c90c81b7ba785ef5af61935528
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Nov 5 07:51:06 2026 +1100
qa/admin/post-setup: assorted Solaris fixups
Mostly networking ... separate static IP addr setup from default route
setup.
commit 377d370a23020231f1ae84f9a04f07dc1aa7a40d
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Nov 5 07:32:56 2026 +1100
qa/admin/post-setup: rearrange some code blocks
Make sure platform and packaging variables are set before
they are used.
commit 3521fb6c5b0d66ff6da6f899a7c83927ded39398
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Nov 5 07:20:01 2026 +1100
qa/603: revert No route mapping from last commit
Taking @coderabbitai's suggestion here. After PR #2777 is done
I'll cycle back and re-investigate this one failing on OpenSolaris
(vm29).
commit 9447daeba4e30f0c0481506d1c0c10c56d81ab0d
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Nov 5 07:17:08 2026 +1100
qa/admin/post-setup: rework logic for serial console login on Solaris
Needed to seperate setting up the console-login:terma svc from
enabling the same svc.
commit 30bb5cde78cee193eb292d71503a3998f7d23d03
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Nov 5 06:24:45 2026 +1100
src/libpcp/src/util.c: logreopen() tweaks
- guard against strdup() failing in OpenBSD desperate diagnostic block
- improve locking for one-trip initialization of append_pid
commit d69ff6f7a35d7105b2fe657e7dd5fd7d4a3e1e22
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Nov 5 06:20:14 2026 +1100
src/pmieconf/rules.c: fix free-then-return in read_all_rules()
Not return-then-free!
commit 4adb47ba43f49ce29ba4e3541655ae0d0e7bb5ca
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Nov 5 06:12:30 2026 +1100
src/libpcp/src/tz.c: fclose for /etc/TIMEZONE in __pmZoneinfo before return
commit 3a230934802e8aaf61dee81bf8318756ceb12c6a
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu Nov 5 06:10:05 2026 +1100
src/libpcp_pmda/src/pduroot.c: fix diagnostics in __pmdaRecvRootPDUStartReq()
Message prefix should be __pmdaRecvRootPDUStartReq not __pmdaSendRootPDUStartReq
(cut-n-paste error).
commit 27f1a4bdc4ecb7bd44edfa7af0cc4cbd807c64c7
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Nov 4 21:37:05 2026 +1100
Update src/libpcp/src/util.c
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
commit ffbdba0b0346aaaf7d504749fc16d3ce01766c3d
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Nov 4 21:34:08 2026 +1100
Update man/man1/pcpintro.1
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
commit e4e0def96d17dca05751bd7a357cccdd1c370073
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Nov 4 21:29:36 2026 +1100
qa/1339: use $PCP_RUN_DIR instead of /var/run/pcp
commit 5a00f1b9beeabb0596a2f8f1583bbe3ff25579c7
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Nov 4 21:24:31 2026 +1100
qa/admin/post-setup: reinstate check for duplicate connections from nmcli(1)
commit 1b9c19ed39d0f62c65ffe9c3f5937176bc84f664
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Nov 4 17:09:58 2026 +1100
scripts/start: also need _systemctl_status() from qa/common.check
commit d677765502c2fd89f25fc86e0f82a0270466858e
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Nov 4 16:55:53 2026 +1100
scripts/start: set $sts on success before exit
commit fa2b4b11be2b2ed22f641f8e396ae86ce4e84887
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Nov 4 16:51:52 2026 +1100
scripts.start et al: several changes
Change from hard links to symlinks (the former are lost by git).
Ensure probe for systemctl from qa/common.check that is outside
_service() is included here.
commit f35b12461f9103537b135fa26097986c01a03a30
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Nov 4 16:30:22 2026 +1100
Update src/libpcp_pmda/src/root.c
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
commit 2752574546c6940d9bdc04507ae1775d9bf0ab3b
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Nov 4 16:18:53 2026 +1100
Update man/man1/pcpintro.1
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
commit 77fa89d33775803192bf5bf04e859ccc4aa0c9e0
Merge: 2dd5b239 aacfff8c
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Nov 4 14:55:03 2026 +1100
Merge branch 'main' of https://github.com/performancecopilot/pcp
commit 2dd5b2391f4e1277c3748bc8b603198ccaeccdf0
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Nov 4 14:42:49 2026 +1100
qa/603: refactor for OpenIndiana (vm29)
Several oddities surfaced on this platform. Refactor works here and on Linux.
commit 180e6bc04e6b6e5e2facb781ba27402eb2d3efcf
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Nov 4 14:41:57 2026 +1100
qa/common.check: remove a remaining $seq.full ...
Should be $seq_full, always.
commit 6abcf50112c80abf846a365cc8082c9dec32e1d8
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Nov 4 14:40:51 2026 +1100
qa/510: additional diagnostics to 510.full
commit ff54cd20c6f13c7f91966d5dd673a9cfc4fd9e7b
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Nov 4 14:40:02 2026 +1100
qa/590: the C compiler is not necessarily cc
Use $PCP_CC_PROG instead.
Broke on OpenIndiana (vm29).
commit a4595c4aad193325cf5321a0dbb0243e6fcb02b3
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Nov 4 14:38:14 2026 +1100
qa/063 and qa/069: the C compiler is not necessarily cc
Use $PCP_CC_PROG instead.
Broke on OpenIndiana (vm29).
commit e1edcfbe3931f04c054d6dfd52f787a6e0af0ea3
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Nov 4 14:20:31 2026 +1100
src/libpcp/src/tz.c: add zoneinfo method for Solaris-style
Timezone is hidden in /etc/TIMEZONE on these platforms, on a TZ=Foo/Bar
line.
Fixes the pmcd.zoneinfo metric value and a handful of QA failures on
OpenIndiana (vm29).
commit 297c60be11879a17c6af0d0ad67891de34a79be9
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed Nov 4 14:16:51 2026 +1100
scripts: add convenience shell wrappers for QA _service() function
This itch has only been there for 30 years.
Intended for developers ... so for example,
$ restart pmcd
works on EVERY platform.
start, stop, restart and status are all hard links to the same
script.
commit aacfff8cc9c41da0ead787ee3ca780a0cb9adf32
Author: William Cohen <wcohen@redhat.com>
Date: Mon Nov 2 15:48:12 2026 -0500
qa: Properly free allocated memory in interp_bug3.c
Observed test 1583 failing due to memory leaks in interp_bug3.c:
[82%] 1583 - output mismatch (see 1583.out.bad)
5a6,15
> 160 bytes in 1 blocks are definitely lost in loss record 60 of 72
> at 0x486C826: malloc (vg_replace_malloc.c:447)
> by 0x4002787: main (interp_bug3.c:199)
> {
> <insert_a_suppression_name_here>
> Memcheck:Leak
> match-leak-kinds: definite
> fun:malloc
> fun:main
> }
7c17
< definitely lost: 0 bytes in 0 blocks
---
> definitely lost: 160 bytes in 1 blocks
9c19
< ERROR SUMMARY: 0 errors from 0 contexts ...
---
> ERROR SUMMARY: 1 errors from 1 contexts ...
Check local PMCD is still alive ...
Added a matching call to free the memory allocated in main just before
it is exited to eliminate the memory leak reported by valgrind.
commit 4eb252f44a9054ebf5aba1f30d877a4c75791ca6
Merge: d6de16a4 407329f9
Author: Ken McDonell <kenj@kenj.id.au>
Date: Tue Nov 3 12:03:30 2026 +1100
Merge branch 'main' of https://github.com/performancecopilot/pcp
commit d6de16a4f24e62f52587d08e181fa6fa4244da28
Author: Ken McDonell <kenj@kenj.id.au>
Date: Tue Nov 3 12:01:54 2026 +1100
qa/1429: tweak filter
Had potential filter snarfoo when run on the first 3 days of any month.
Don't ask.
commit 5b8c0dd03c8200825ce0ca6b2b1b290b636ec055
Author: Ken McDonell <kenj@kenj.id.au>
Date: Tue Nov 3 12:01:20 2026 +1100
qa/1339: additional diagnostics for the socket+root-PMDA saga
commit 0ef1d4c70d1fa5fc1b3a8ef52a614935468013ac
Author: Ken McDonell <kenj@kenj.id.au>
Date: Tue Nov 3 11:59:52 2026 +1100
src/libpcp_pmda/src/root.c: more on the socket+root-PMDA saga
Added additional diagostics (with -Dlibpmda guard) to report (previously
silent) failures in:
pmdaRootProcessStart()
commit 56494422bd816b26f99deecca12a2582c0a98cf3
Author: Ken McDonell <kenj@kenj.id.au>
Date: Tue Nov 3 11:50:33 2026 +1100
src/libpcp_pmda/src/pduroot.c: more on the socket+root-PMDA saga
Added additional diagostics (with -Dlibpmda guard) to report (previously
silent) failures in:
__pmdaSendRootPDUStartReq()
__pmdaRecvRootPDUStartReq()
__pmdaRootPDUStart()
And the *critical* fix in __pmdaSendRootPDUStart() to not use msg_control
when either infd < 0 or outfd < 0 ... *not* doing this led to a malformed
struct msghdr being passed to sendmsg() which on OpenBSD (vm29) caused the
hand-off from pmcd to the root PMDA to fail for the sample PMDA, and the
fallback left the sample PMDA as a child of pmcd, not the root PMDA, so
the sample PMDA was not killed off and the second attempt to install it
with -i 54321 failed because the old sample PMDA was still using the port.
All other platforms apparently have less-picky checking below sendmsg() so
this issue had been undetected since it was introduced in Dec 2014!!
commit 882dd8894c19a43bdfffcc28679580aaf292ebb8
Author: Ken McDonell <kenj@kenj.id.au>
Date: Tue Nov 3 11:47:29 2026 +1100
src/libpcp_pmda/src/open.c: additional OpenBSD-only diagnostics
More of the socket+root-PMDA, this time chasing why binding to port 54321
for the sample PMDA with -i fails in qa/1339 but only after qa/283 is run.
Turns out this was only a symptom ... the root cause lies with the root
(excuse the pun) PMDA ... more commits coming on this front.
commit f4ad3552914a051d5303e9f0004bd3a07b0dfbfc
Author: Ken McDonell <kenj@kenj.id.au>
Date: Tue Nov 3 08:55:36 2026 +1100
src/pmcd/pmcd.defaults: expose $PCP_LOGS_APPEND_PID handle
Commented out (of course).
commit bdc1da50e86dfdebe1d62b26cfa7cec8e6878543
Author: Ken McDonell <kenj@kenj.id.au>
Date: Tue Nov 3 08:52:01 2026 +1100
src/pmcd/src/config.c: additional -Dappl6 diagnostics
Calls to a number of routines had no diagnostics on their failure
paths, specifically calls to:
pmdaRootConnect()
pmdaRootProcessStart()
CreateRootAgentPOSIX()
And a couple of diagnostics had the wrong (appl4) guard.
All on the path to tracking down the socket+root-PMDA problem
on OpenBSD.
commit 9ff89e6ccef37dfbf6311354d10531f54497b95e
Author: Ken McDonell <kenj@kenj.id.au>
Date: Tue Nov 3 08:50:21 2026 +1100
src/pmcd/src/dofetch.c: fix compiler warning on OpenBSD
commit d37046f8ae10038a92ce46ab0e4a0db83a32abf1
Author: Ken McDonell <kenj@kenj.id.au>
Date: Tue Nov 3 08:14:51 2026 +1100
libpcp: add $PCP_LOGS_APPEND_PID - append <pid> to linked file for pmOpenLog
In chasing a socket and pmda root problem on OpenBSD (vm27) I needed the
complete history of pmcd and pmda log files ... the *.log and *.log.prev
scheme is not detailed enough if these files churn frequently in a single
QA test.
When this environment variable is set, every fopen() in pmOpenLog()
also creates a hard link using the same file name with a <pid> appended
the links persist for ever and so provide a complete history for triage.
The code change is confined to pmOpenLog() in src/libpcp/src/util.c but
spilled out into check-statics (for the one-trip guard for the getenv())
and the man pages.
There is also some re-organization of the order of environment variable
entries in the pcpintro.1 man page that was picked up in passing.
commit 407329f90725c7542d9eff40424e13f4080941d1
Author: Nathan Scott <nathans@redhat.com>
Date: Sat Oct 31 13:48:20 2026 +1100
build/ci: handle redis/valkey conflict on newer Ubuntu runners
Newer Ubuntu releases (24.04+, and now ubuntu-latest 26.04) can install
both redis-server and valkey-server. Both default to port 6379, so only
whichever package starts first during apt-get install is actually running;
the other one fails to start.
Previously redis-server invariably won that race, so the explicit
'systemctl start redis' worked. On the Ubuntu 26.04 runner image valkey
starts first, so the redis-server unit is left failed and the QA init
step aborts the job before any tests run.
Start valkey first and fall back to redis, matching the preference QA
already uses when both are installed.
Signed-off-by: Nathan Scott <nathans@redhat.com>
commit 00c0fb2f49e9eedde624f5270ee449523cd7127d
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Oct 31 07:45:39 2026 +1100
qa/admin scripts: rework after OpenIndiana forced re-install on vm29
Lots of things missing from post-setup because the VM setup on vm29
was previously done by hand and pre-dated post-setup.
Small tweaks and extensions to check-vm.
commit 5aa3a2d5c45567862fbf2cc765b7137ce2ffe135
Author: Ken McDonell <kenj@kenj.id.au>
Date: Tue Oct 27 07:27:28 2026 +1100
libpcp, libpcp3 and libpcp_pmda: improve cast for __pmSetSockOpt arg
int one; ..., (char *)&one is misleading, it should be (void *)&one
This is not the cause of the qa/1339 failure on vm27 (amd64 OpenBSD 7.8)
with this signature:
__pmdaOpenSocket(,54321,2): bind: Address already in use
but with these changes in place grind 1339 ran for 14 hours without
failing ... but when I ran it again *after* qa 283 the failure
seems solid.
Added diagnostics on the failure path pro tem to try and debug this.
commit 1846e834b1e909b404b3d253bce57ca1f70045e7
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon Oct 26 16:24:33 2026 +1100
qa/admin/pcp-daily: fix botched Solaris package install line
Was pkgadd'ing pcp twice which royally screwed with pmcd.conf.
commit 82cf4cf6e9db7216854a6cfb0c7676ea79733b44
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon Oct 26 14:46:32 2026 +1100
Revert "qa/1339: _notrun on OpenBSD"
This reverts commit 10e33da997c549467f30990a3e2d550d9b19b2cb.
Triaging the root causes on OpenBSD some more.
commit 10e33da997c549467f30990a3e2d550d9b19b2cb
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sun Oct 25 07:00:37 2026 +1100
qa/1339: _notrun on OpenBSD
This one has been lurking forever ... there is something about the probing
and use of a TCP/IP port here that fails 100% of the time on (apparently
all versions of) OpenBSD with this in pmcd's log
pmdasample(96990) Critical: __pmdaOpenSocket(,54321,2): bind: Address already in use
Since the test passes everywhere else, skip it on OpenBSD.
commit 71a50cf5c8e7d918ce01969403a325637bc2b6de
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat Oct 24 18:44:23 2026 +1100
src/pmieconf/rules.c: clean up memory leaks on error paths
Probably never seen, because errors => exit for pmieconf, but
Coverity noticed and CIDs 454664 and 454667 have been lurking
for a long time.
(new) qa/1736 and the valgriand dual qa/1737 exercise the
error paths in question.
commit 791edf838b2ea39b18952cc0212b0d236489570a
Merge: c42b90f5 fe4b6e81
Author: Ken McDonell <kenj@kenj.id.au>
Date: Fri Oct 23 09:26:58 2026 +1100
Merge pull request #2772 from kmcdonell/wip
Refactor _get_primary_logger_pid()
commit fe4b6e8161efd70466ba8205e964272f7828bca1
Author: Ken McDonell <kenj@kenj.id.au>
Date: Fri Oct 23 07:07:49 2026 +1100
qa fixups after _get_primary_logger_pid() changes
- update qa/COOKBOOK.md description
- tweak filter for qa/1429
There are 6 open security issues in trixie.
You can find information about how to handle these issues in the security team's documentation.