commit 9a33d15ead181f3e72b9c83ab95ccd64f2b4ed8a
Author: Jan Kurik <jkurik@redhat.com>
Date: Thu May 28 20:52:22 2026 +0200
qa: cover ubuntu2604 differences in some test
qa/1429 - fix mkdir error message:
ubuntu2604 uses uutils coreutils which returns different error message
when mkdir command fails for a permission reason.
fix _filesize()
On Fedora/RHEL (and older distros), stat prints 'Size' while on Ubuntu
26.04 stat prints 'size'. The fix covers this difference and fixes
various tests using the stat command to get file size.
commit 5e79534d59b8ebdab834fb6add2bcf361e436627
Merge: 16e17fa2 a664c5a3
Author: Ken McDonell <kenj@kenj.id.au>
Date: Fri May 29 17:19:01 2026 +1000
Merge pull request #2598 from kmcdonell/units
add extra units to pmUnits
commit 16e17fa201ed8e89124ec3529fb073920d6faf23
Author: Jan Kurik <jkurik@redhat.com>
Date: Thu May 28 06:46:28 2026 +0200
libpcp_web: accept NaN/Inf in series_pmAtomValue_conv_str on float/double
The first-character digit check rejected pmAtomStr_r() output like "nan"
from 0.0/0.0 on s390x (positive quiet NaN), breaking pmseries division
tests 1886 and 1906.
For some reason the FPU on s390x returns NaN with sign bit clear which
is different from most of the other architectures which return negative
NaN (sign bit set). Both ways are allowed by IEEE 754 which states only
that Nan should be returned (no sign defined).
commit 673f3b4a3d34b9ebeb5b64ee495aeee39c4ec117
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu May 28 21:23:38 2026 +1000
qa/338 and qa/1473: fix fmt usage broken in earlier commit
Started to fail on Ubuntu 26.04 ... thanks to Jan for spotting the
problem.
commit dc26b9fb461e799a7b9edd0f88d61e6a8b825245
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu May 28 17:11:40 2026 +1000
qa/admin/package-lists/Ubuntu+26.04+x86_64: add zabbix-agent
commit a664c5a38ec42224a9a8eef93614524558a03ec4
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu May 28 14:08:04 2026 +1000
pmrep: extra units changes via src/python/pcp/pmconfig.py
Thanks to Marko for this patch.
Also a new qa/1668.
commit 0e4eb642c2112c2c369954135a01453103c38a81
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu May 28 10:02:16 2026 +1000
src/libpcp_web/src/query.c: small extra units tweak
@coderabbitai pointed out that for division the
extra-unit/sec and 1/extra-unit cases were NQR.
commit 2ebc27588291f5f068a66f7890920653e4e1bbac
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu May 28 08:44:08 2026 +1000
extra units: more minor fixups from @coderabbitai suggestions
Also fixes prior error ... the existing scaleCount is signed,
not unsigned.
commit 0746f00004ed6e08abbb4eb641b70683cb70689d
Author: Jan Kurik <jkurik@redhat.com>
Date: Wed May 27 05:28:32 2026 +0200
ci: add Fedora 44 and Ubuntu 26.04 to GitHub automation
Add platform definitions, QA package lists, and workflow matrix entries
for fedora44-container, ubuntu2604-container, and ubuntu2604. Map
ubuntu2604 releases to the resolute codename for Packagecloud uploads.
Drop obsolete suggestion-mode from .pylintrc for pylint 4.x. Stop using
deprecated argparse.FileType in the lmsensors PMDA. Use
/usr/lib/systemd/systemd as PID 1 on Ubuntu 26.04 where /usr/bin/systemd
is no longer shipped. Fix Ubuntu 26.04 package list Perl and ICU names.
Report OSError when the lmsensors inject file cannot be read.
Co-authored-by: Cursor <cursoragent@cursor.com>
commit a1ca90cd106f2fc6cb1f8d3f42a3987c8c467b36
Merge: 5fabaaba d653a7e1
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed May 27 16:12:59 2026 +1000
Merge branch 'main' into units
Conflicts:
qa/1426
Take change from main branch.
commit d653a7e182a8b5ba12f8729f1e61523e6c007feb
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed May 27 15:07:55 2026 +1000
Makepkgs: revert dh_auto_configure change
We cannot use dh_auto_configure in the early part of the source
code packaging ... go back to using ./configure directly.
commit d65a9f0ddda077c025e36e4fa5bef6ecb9c10441
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed May 27 13:41:18 2026 +1000
qa/988: permissions and remake
Same test files, same fix needed (as previously applied to qa/987).
commit 17c5b86b8995dce5095b47828601316b5c154869
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed May 27 13:35:19 2026 +1000
qa/1426: tweak filter to dodge Debian Multilib path
commit 24cfa916bc2d36475a987644be0f5f7b0b2cffac
Merge: 8bc11083 da237643
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed May 27 13:05:11 2026 +1000
Merge branch 'main' of ../pcp
commit da2376438b96fe180dcbf92ae7f33e7b16e01709
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed May 27 13:03:55 2026 +1000
debian/pcp-testsuite.lintian: Multilib strikes again
One more place where there is a path that depends on Multilib.
commit 2dd2f5cd07d18d671b4235afe48a407b83cb1d8a
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed May 27 11:25:38 2026 +1000
qa/987: fix permissions and other problems
The tarballs this test uses have been created by various people
over time and they do not share the same ownerships and permissions.
The net result is that the test with the latest
qa/linux/xfs-root-003.tgz is failing on all the machines in the
QA Farm.
- half because of one variant of the permissions issue
- half because dodging the first permissions issue exposes a second
permissions issue that shows the committed 987.out is bad ... lots of
values are available but 987.out shows No values
Fix the script (big chmod hammer) and remake 987.out.
commit 5fabaaba86bedc20423b3380e45a6011b268ccd5
Author: Ken McDonell <kenj@kenj.id.au>
Date: Tue May 26 16:55:11 2026 +1000
src/collectl2pcp/GNUmakefile: avoid pmdesc rebuild and execution
This is for developers only and not part of the product build.
commit 95cb1be5942532faf6a0597d9c068a4beb7bc506
Author: Ken McDonell <kenj@kenj.id.au>
Date: Tue May 26 16:18:54 2026 +1000
src/pmlogrewrite/lex.l: match MiXeDcAsE macro names for extraScale
Thanks to @coderabbitai for spotting this.
commit 4439cc135f7a7a3f63131507aa49b9e7b727b102
Author: Ken McDonell <kenj@kenj.id.au>
Date: Tue May 26 15:38:51 2026 +1000
src/pmie/src/dstruct.c: fix wrong field name used in test
Caught by @coderabbitai.
commit 626957ebafceb6976306d753b1bcfc0203c4c4c6
Author: Ken McDonell <kenj@kenj.id.au>
Date: Tue May 26 14:02:11 2026 +1000
qa: remakes after recent small code changes
commit 8bc1108330271a1c947ff997ee221d1ae815a635
Author: Nathan Scott <nathans@redhat.com>
Date: Tue May 26 12:48:28 2026 +1000
docs: bump version and changelogs for next planned release
commit 80f7ff1ccdf66a013be8a58120c187bfc9063a01
Author: Ken McDonell <kenj@kenj.id.au>
Date: Tue May 26 10:27:04 2026 +1000
miscellaneous fixes: on @coderabbitai suggestions for PR #2598.
Some are cosmetic, some are grammar and spelling, some are errors
in the sample PMDA calculations for extra units and some are minor
tweaks in code places touched by the extra units changes.
commit d51845a2daf31e1a30e391a0082d4544daa94882
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon May 25 08:24:36 2026 +1000
src/libpcp_import/src/import.c: avoid accidental sharing of static
Rename "units" to "extrunits" in pmiExtraUnits() to avoid collision
with static of same name in pmiUnits().
Problem identified by @coderabbitai as part of PR #2598.
commit ea5252e9d27b8598e45ab5db0d9dbf0d5a1093f9
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon May 25 07:39:56 2026 +1000
qa/new: fix interaction between -r and -R
Based on per @coderabbitai suggestion for PR #2598.
commit e21c41bbb6e8a3461a2e59362efe0a20a65ca72b
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon May 25 07:11:22 2026 +1000
Makepkgs & qa/admin/myconfigure: use dh_auto_configure when available
For Debian builds this means
$ qa/admin/myconfigure
leaves the source tree in a state where
$ sudo make install
works for all the src/libpcp* directories because the Multilib path
below /usr/lib will be used to match the place the libraries are
installed by dpkg.
For Makepkgs this is pretty much a no-op, other than it will not
undo changes made by qa/admin/myconfigure.
commit 307948ac2950edc7f165d7078b3e71b7e42ec9e8
Merge: 6b086696 3c60b37e
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon May 25 06:54:08 2026 +1000
Merge branch 'main' into units
commit 6b086696a7841625fbe8ed860191f4abc1015adf
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat May 23 19:17:37 2026 +1000
src/pmdas/statsd: fix botched change (unrelated to) extra units
commit 60c39559977eaf0865e0a4a62598f4eddb4b43d5
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat May 23 18:22:10 2026 +1000
src/collectl: revert coderabbitai suggestion
It was just plain wrong.
commit 4242a8f7282cb1287531ffcb7842ab08204c7991
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat May 23 16:33:03 2026 +1000
fix spelling: farenheit is one h short ... thanks coderabbitai
commit 9febac9470ef46f70a22981c3efc1daff2ecb822
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat May 23 15:49:39 2026 +1000
extra units: fixes from coderabbitai for PR #2598
- qa/common.check
- src/collectl2pcp/GNUmakefile
- src/libpcp/src/extraunits.c
commit 34fc4ef6f33164bbea94b234a1c84202eb34ae70
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat May 23 11:03:50 2026 +1000
src/collectl2pcp/pmdesc.c: fix from coderabbitai
commit 1ace97c75a7555ed9237ba64c908ae66ba781629
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat May 23 09:05:18 2026 +1000
src/pmdas/statsd/src/pmdastatsd.c: fix from coderabbitai
commit 419eb0835ce36827e862154f37202855c1671bc8
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat May 23 07:06:19 2026 +1000
qa/pdudata: update some configs
Make uses of units() match changes to qa/src/pdu-gadget.c, namely
8 parameters instead of 6.
commit 3d9b480f7ba04c504a5eb9d8fd1bc7e960f8b2ff
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat May 23 07:05:14 2026 +1000
qa/369.out & qa/1418.out: remade after pmiExtraUnits added
commit f5f97002e5997c4067c92a7a3d2b45aa86e817f5
Author: Ken McDonell <kenj@kenj.id.au>
Date: Fri May 22 16:31:44 2026 +1000
extra units: small tweaks for the Python interface layer
commit f23cbeda8611276ea46c382624ed69b7225620d3
Merge: e5a43d97 fa63a305
Author: Ken McDonell <kenj@kenj.id.au>
Date: Fri May 22 15:09:08 2026 +1000
Merge branch 'main' into units
commit e5a43d9713844b1019bcf9134b2a494d9fafb719
Author: Ken McDonell <kenj@kenj.id.au>
Date: Fri May 22 14:58:57 2026 +1000
extra units: last round of significant changes
- add __pmExtraUnitsShortStr() to libpcp for use by libpcp_qmc
- libpcp_qmc changes in qmc_desc.cpp
- libppcp_web changes
src/libpcp_web/src/query.c
src/libpcp_web/src/query_parser.y.in
- add pmiExtraUnits() for Perl LogImport module
- add mmv_extraunits() and extra unit #defines for Perl MMV module
- add pmda_extraunits() and extra unit #defines for Perl PMDA module
- fix/extend perl PMDA module unit tests
src/perl/PMDA/cvalue.c
src/perl/PMDA/test.pl
- small tweaks for src/python/pcp/pmconfig.py
- teach some qa apps about extra units
qa/src/multictx.c
qa/src/pdu-gadget.c
commit b01db90b9ebcefb3a4ee165366bfa3e664afd65f
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu May 21 16:06:36 2026 +1000
libpcp: tidy up extra units seamntic checks for derived metrics
Allow a little more latitude for division and propagate the
extra units correctly for multiplication and division.
commit 9c648feddf967655d1f2f4c26b09c14aeaedc1d2
Author: Ken McDonell <kenj@kenj.id.au>
Date: Thu May 21 07:02:19 2026 +1000
qa/common.filter: add the summary PMDA to the "optional" ones to be filtered out
commit 6957da79117e0168f4ba8b16b4263e1dde031446
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed May 20 17:48:29 2026 +1000
libpcp: extra units changes for derived metrics
Limited support for metrics with "extra" units in derived metrics.
No autorescaling (although rescale() works) and for * and / the use
of extra units for *both* units is not allowed, otherwise the existing
constraints on dimension matching are extended to extra units.
commit b1e93c07e7744da664719cddd28290cd98dae289
Merge: 7713cee6 1f4bcc34
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed May 20 06:47:26 2026 +1000
Merge branch 'main' into units
commit 7713cee66149ed5b1eb72ccca6cc0fda97cbfcca
Author: Ken McDonell <kenj@kenj.id.au>
Date: Tue May 19 16:29:16 2026 +1000
pmie & qa: small fixups
- remove dead code from src/pmie/src/syntax.c
- fix qa/new so that -R does not mangle the group file with
duplicate lines and "lost" groups for unreserved tests
- repair qa/group from damage as described above
commit e63dacf63862a42481d39e6cb20df981e3c8dcef
Author: Ken McDonell <kenj@kenj.id.au>
Date: Tue May 19 14:55:15 2026 +1000
pmie and summary PMDA: extra units changes
- pmie propagation of pmUnits in expression trees was seriously broken,
and had not been noticed because pmie does not check pmUnits for
compatibility of operands in expressions (another good reason to
prefer derived metrics over pmie expressions) ... the fixes here address
the obvious issues and in particular safe handling of extra units and
correct metadata for the default metrics exported from the summary PMDA
(which runs pmie in "secret agent" mode)
- revise default expressions for the summary PMDA metrics
summary.netif.packets and summary.netif.busy to consistently consider
only active network interfaces, and tweak the help text to better
match the semantics of the expressions used
- new qa/1665 and qa/1666 to exercise pmUnits handling for pmie
and the summary PMDA
- fix incorrect pmUnits fiddling for QA's broken PMDA
- fix incorrect pmUnits fiddling in qa/src/pducheck.c
- fix leftover fallout from pminfo -e and sample PMDA pmns changes with
some QA remakes
- qa/1426: rework to use modern network.tcp "drops" metrics rather than
_notrun when the Irix metrics are not available
- make _triage_wait_point() look for $here/$seq.wait by default, so it
works when a QA test has cd'd away from $here ... update COOKBOOK.md
to match
- assorted extra unit QA remakes and fixups, some from earlier changes
that had not been exposed to a full QA run with all the pmUnits
changes to date
commit 782c07f211bd7fe31f6dc0f6745ce19699d03f91
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sat May 16 08:29:42 2026 +1000
pmie: extra units changes
pmie plays loose and fast with the metadata, so there is very little
checking of pmUnits compatibility in expressions => not much needs to
be changed here (in fact main change is removing some dead code).
commit 95a5ee73efed9e874b3a53c04a4160283947f894
Author: Ken McDonell <kenj@kenj.id.au>
Date: Fri May 15 10:31:22 2026 +1000
qa/group: unreserve 1664
commit 20007ffe6915f47432e1eac80b63ebc06b5b12ab
Merge: beb377a2 509a6bb1
Author: Ken McDonell <kenj@kenj.id.au>
Date: Fri May 15 10:30:55 2026 +1000
Merge branch 'main' into units
commit beb377a291b4c462c4e8b0bef1dcecb8e2527bb3
Merge: 993d2ed2 e96dd233
Author: Ken McDonell <kenj@kenj.id.au>
Date: Fri May 15 08:13:22 2026 +1000
Merge branch 'main' into units
Conflicts:
qa/group
commit 993d2ed2c72a59451db4bda41798043287cff654
Author: Ken McDonell <kenj@kenj.id.au>
Date: Fri May 15 08:06:40 2026 +1000
extra units: next round of changes
- PM_UNITS_... renamed PM_UNIT_... so we're using the singular form
for macros, pmUnits field names ... library routines tend to use
ExtraUnits in the routine names because the "Units" routines already
existed and they typically relate to operations on a pmUnits struct
(where the name is pluralised)
- fix the 4:4 to 5:3 bit field split for .extraUnit and .extraScale
in the ! HAVE_BITFIELDS_LTOR alternate block (the sizes were round
the wrong way)
- upgrade the Str and Parse routines to accept extra units in the
dividend (.extraUnit > 0) or the divisor (.extraUnit < 0) which is
starting to make use of the extra bits and signedness of .extraUnit;
also extend qa/670 to exercise the related new code
- remade the qa/extra archive after fixing the change from a 4:4 to
5:3 bit field split for .extraUnit and .extraScale
- pmConvScale() now understands extra units and this required a new
table-driven __pmConvExtraScale() in src/libpcp/src/extraunits.c
to hide the "extra" units semantics from pmConvScale() and avoid
the nested switch mess that bidirectional N x M conversion would
otherwise require
- document pmiExtraUnits()
- update the pmLookupDesc(3) man page to provide the definitive
description of extra units ... this man page is cross-referenced from
many other man pages dealing the pmUnits
- additional man page changes for all of the above
- add pmunits "group" to qa/group and update all entries for QA tests
that dink with pmUnits
- extend qa/src/grind_conv.c to accept both a 6-tuple (classical)
and 8-tuple (classical + extra units) specification for both input
and output pmUnits
commit b374284537b35efa0fe9a313027f6a2ee7134d27
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon May 11 11:12:37 2026 +1000
extra units: refactor the formatting and parsing routines in libpcp
commit 4dca8b9e8b1adf5ddbe4310f887590c573ab7a35
Merge: f94ada2f ba25e7c6
Author: Ken McDonell <kenj@kenj.id.au>
Date: Sun May 10 13:49:25 2026 +1000
Merge branch 'main' into units
commit f94ada2f7eca1110c3633cac67c6c23b98b42d1b
Merge: a57488db a84906ae
Author: Ken McDonell <kenj@internode.on.net>
Date: Sun May 10 13:31:52 2026 +1000
Merge branch 'main' into units
commit a57488db6c0e36e00e4c92386be00c789e2c5d32
Author: Ken McDonell <kenj@kenj.id.au>
Date: Fri May 8 01:26:22 2026 +1000
extra units changes for pmlogrewrite
- new EXTRAUNITS option in METRIC clause that accepts units
as an 8-tuple (not a 6-tuple as for the UNITS option)
- change sample.temperature.centigrade => sample.temperature.celsius
to match international agreement in 1948.
- man page
- assorted qa changes and extensions
Please ente `r the commit message for your changes. Lines starting
commit e1434967bdae5d9f010d89386f20b4552ced2607
Merge: f8ea8790 2ee8a58a
Author: Ken McDonell <kenj@kenj.id.au>
Date: Wed May 6 19:46:22 2026 +1000
Merge branch 'main' into units
commit f8ea8790fe26b0627974cccefaf2323df2765021
Author: Ken McDonell <kenj@kenj.id.au>
Date: Tue May 5 15:01:15 2026 +1000
qa/archives/extra: small new archive with sample metrics having extra units
commit dc2316079f216390caafac7a3fe29421966c794a
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon May 4 09:05:06 2026 +1000
libpcp_import: add support for extra units in pmUnits
commit 8e0c507c7b74e9faefb181ac7d9651db9a34614e
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon May 4 06:27:10 2026 +1000
collectl2pcp: extra units changes
- update pmdesc.c to ...
+ only emit initializers for dimension and scale when dimension
is non-zero
+ emit extraUnit and extrScale initializers if required
- regenerate metrics.c (makefile updates to re-enable rule) which
has briefer pmUnits and some additional metrics (the PMNS has
moved on since Mark last generated metrics.c)
commit 04663d0db08314997ffe0b164965046953141aac
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon May 4 00:29:59 2026 +1000
scripts/man-spell: fixup
previous change to allow checking of markdown files introduced a typo
that broke the script for all troff source man pages.
commit 90f92ff166b5dfaf7e24c12cb928f3ee02582a79
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon May 4 00:29:38 2026 +1000
src/collectl2pcp/pmdesc.c: changes for extra units
commit 37581bd26251137bb23fb156ce2001b2eda37443
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon May 4 00:28:33 2026 +1000
src/pmlogger/src/checks.c: extra units
Need to check the additional fields when testing for a change in
the metadata.
commit 68048172d1d16a0673a08df992ed9a151ae33932
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon May 4 00:26:42 2026 +1000
src/perl/PMDA/cvalue.c: extra units changes
No support in the Perl APIs at this stage, but this change is
needed to ensure the extra fields in the pmUnits are correctly
set to zero.
commit 081ed211d22efc7ebcb0b00f52290130b64b0be9
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon May 4 00:25:44 2026 +1000
qa/src/endian.c: changes for extra units
commit 9636dda70d525a01fdb17081ec74e3736cef9e4f
Author: Ken McDonell <kenj@kenj.id.au>
Date: Mon May 4 00:24:08 2026 +1000
qa/510: small tweak for lock file diagnostic
There are 4 open security issues in bookworm.
You can find information about how to handle these issues in the security team's documentation.