commit 56e587db47ba44f5ed68ca445dcbd4c4c89f6132
Merge: 797e688 536bda1
Author: onlyjob <onlyjob@debian.org>
Date: Fri Jan 31 01:35:35 2025 +0000
Merge branch 'improve-smartd-runner' into 'master'
smartd-runner: various improvements
See merge request debian/smartmontools!6
commit 797e688fb6874dc28f86f41df4a435f9eb315483
Merge: 13dd5f7 6c8aeb5
Author: onlyjob <onlyjob@debian.org>
Date: Fri Jan 31 00:37:29 2025 +0000
Merge branch 'improve-10mail' into 'master'
run.d/10mail: various improvements
See merge request debian/smartmontools!5
commit 536bda132654a97fb903fc905d19a209c8aad4c3
Author: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>
Date: Sat Nov 19 02:21:04 2022 +0100
smartd-runner: no longer invoke scripts with positional parameters
There is no need to create a temporary file (which causes unnecessary IO) or to
invoke the scripts in `/etc/smartmontools/run.d` with the positional parameters
as all that information is available in `smartd`’s `SMARTD_*`-family of
environment variables.
The previous solution had also omitted any further email addresses that were
specified via smartd`’s `-m` option.
Signed-off-by: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>
commit 13dd5f756a7398d08bd45875d91f9636404fcc85
Author: Dmitry Smirnov <onlyjob@member.fsf.org>
Date: Tue Dec 5 17:50:40 2023 +1100
rules: corrected removal of redundant "smartd.service" file.
(That very file is installed as "smartmontools.service").
commit e006c2bdedd437c78652893543450b89b14d54e0
Author: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>
Date: Sat Nov 19 02:10:08 2022 +0100
smartd-runner: use sh instead of bash
`bash` is not needed here as no bashisms are used, and `dash`, which typically
provides `sh` in Debian is faster.
Signed-off-by: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>
commit 6c8aeb5f50e3e198c15e889f42b88ed84b358ac6
Author: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>
Date: Sat Nov 19 02:05:49 2022 +0100
run.d/10mail: send mails separately to each address
This is for privacy reasons. Typically only very few mails should be sent out,
so the overhead of this is negligible.
Signed-off-by: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>
commit 4366c89082d3515c93235e6de9523d8716a1ed06
Author: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>
Date: Sat Nov 19 01:59:45 2022 +0100
run.d/10mail: use smartd’s SMARTD_* variables
Instead of the positional parameters set by `smartd-runner`, use the environment
variables set by `smartd` itself.
This also fixes a bug which causes this script to not send mail to all specified
recipients, when more than one was given, as `smartd-runner` only exports its
positional parameters 1 to 3, which were `-s`, `<some mail subject line>`, `<the
first mail address from smartd.conf’s -m parameter value>`.
It also avoids the need to read some temporary file (thereby causing unnecessary
IO).
Signed-off-by: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>
commit 8c8cd4afe28e080e30a84a854b2a543d1e99432f
Author: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>
Date: Sat Nov 19 01:49:46 2022 +0100
run.d/10mail: improve check for mailx
• Print the error message to standard error (smartd recognises both and it seems
be a more natura fit than standard output).
• `mailx` is a virtual package, provided by both, `bsd-mailx` and `mailutils`,
so it doesn’t make sense to list it and the latter.
• Further minor improvements.
Signed-off-by: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>
commit c9e32d084e677e17e2deb93765e099184c859943
Author: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>
Date: Sat Nov 19 01:47:48 2022 +0100
run.d/10mail: use sh instead of bash
`bash` is not needed here as no bashisms are used, and `dash`, which typically
provides `sh` in Debian is faster.
Signed-off-by: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>
Among the 6 debian patches available in version 7.4-2 of the package, we noticed the following issues:
![[bug history graph]](https://qa.debian.org/data/bts/graphs/s/smartmontools.png){kind=link}