vcswatch reports that
this package seems to have new commits in its VCS but has
not yet updated debian/changelog. You should consider updating
the Debian changelog and uploading this new version into the archive.
Here are the relevant commit logs:
commit db398e3096825b1fb0d01160715596355369f331
Author: Andre Noll <maan@tuebingen.mpg.de>
Date: Sun Jun 16 13:06:44 2019 +0200
Add a few sample epigrams and the fortunes package.
This adds a single file containing ~200 tagged epigrams in English
language. The debian/control file is extended to provide the new
"tfortunes" package which ships this data file. The new package is
Recommended: by the tfortune package but tfortune works without it
if epigrams are provided locally.
The debian/copyright file also needs to be adjusted because the
epigrams are under the public domain while the source code remains
GPLv3.
The epigrams were created by running
tfortune -- print -atx pub
on the author's epigram database with "pub" being a tag expression
that filters out epigrams not suitable for public exposure.
Suggested-by: Adam Borowski <kilobyte@angband.pl>
v2 -> v3
~~~~~~~~
Apply fixes provided by Adam Borowski:
* Fix bogus date in debian/changelog (s/Mon/Tue)
* Make the data package Arch:all, since it is truly arch-independent
* Add Multi-Arch header to debian/control
v1 -> v2
~~~~~~~~
Incorporate feedback from Adam Borowski:
* Fix typo in description of the tfortunes package
* Update debian/changelog and increase debian version number
commit 008017ce1e1d6cf19f62451ac84b11520b80b748
Author: Andre Noll <maan@tuebingen.mpg.de>
Date: Sun Jun 16 13:46:45 2019 +0200
Fall back to system-wide epigram directory.
If the per-user directory can not be opened, we currently print an
error message and exit. As pointed out by Adam Borowski, this is not
especially user-friendly.
This commit teaches tfortune to look in a second, system-wide location
in this case. This location can be controlled with the --datadir
option of configure. The man page is updated accordingly.
commit 1e2f1e61cf6865df93fda61fa4808132afb72725
Author: Andre Noll <maan@tuebingen.mpg.de>
Date: Sun Jun 16 14:04:44 2019 +0200
Make errors from regfile_iter_new() non-fatal.
The callers of the regfile iter API already handle the case of no
epigrams or tag expressions just fine. In particular, the stats
command can still print meaningful output if the tag expression
directory does not exist, which is a perfectly valid setup.
This patch modifies regfile_iter_new() to no longer abort but merely
print a log message and return NULL if opendir() fails. The various
accessors of the regfile iter API have to be adjusted to deal with
NULL pointers but no changes to tfortune.c are required.
commit 0c39a7e8f0393d0c97cbecca10590afce51abb8f
Author: Andre Noll <maan@tuebingen.mpg.de>
Date: Tue Jun 18 19:45:30 2019 +0200
com_stats(): Fix memory leak.
We currently leak one allocation per tag. Not a big deal since
"stats" is a short-running subcommand. But at least valgrind no
longer complains.
commit 2d331c0d507cb64fa7fd449582fdc0c144cce9c4
Author: Andre Noll <maan@tuebingen.mpg.de>
Date: Tue Jun 18 19:07:24 2019 +0200
com_stats(): Work around bogus gcc warning.
For some versions of gcc (7.4.0, 8.3.0, and 8.3.0-7 as shipped with
Debian-11, but not gcc-7.4.0-1ubuntu1~18.04.1), the previous patch
introduced the following warning:
tfortune.c:912:3: warning: 'lh_stats' may be used uninitialized in this function [-Wmaybe-uninitialized]
free(lh_stats);
^~~~~~~~~~~~~~
We only assign to lh_stats when --verbose is given, and only free the
memory if --verbose is given. Apparently gcc has started to believe
that the value of the "verbose" boolean variable might change, which is
impossible. Therefore, the warning is believed to be a false positive.
However, gcc has a point: There is no need to check for --verbose
twice, as a single branch is sufficient. This not only gets rid of
the warning but also makes the boolean variable pointless and removes
more lines than it adds.
commit 278b70e25a37bae191066c4e08f96fd8624f31e4
Author: Andre Noll <maan@tuebingen.mpg.de>
Date: Mon Jun 17 13:27:36 2019 +0200
com_stats(): Avoid division by zero.
If no epigrams are defined yet, the arguments to printf() contain
a division by zero which results in output like:
average number of epigrams per file -nan
average number of tags per epigram. -nan
average number of tag recurrence... -nan
This is not a wrong per se, but it seems to be safer to special case
this and print zero.
commit 18c4c002c310e9ffa47bad14c967d9e4c02d8d2a
Author: Andre Noll <maan@tuebingen.mpg.de>
Date: Mon May 20 16:58:20 2019 +0200
Add infrastructure to build debian packages.
This commit adds the usual files below debian/ so that debian source
and binary packages can be made with a command like
dpkg-buildpackage
The debian/rules file relies on dh but overrides the dh_auto_configure
and the dh_autoreconf targets. The default recipe for dh_auto_configure
results in warnings because tfortune's configure does not implement
some of the options which dh appends to the configure command. The
override for autoreconf is needed because the default recipe would
remove our configure wrapper and replace it with the generated script.
This has been tested on debian-9, debian-10 and debian-11. On all
systems, lintian(1) reports no warnings and no errors.
v3 -> v4
~~~~~~~~
* Fix Bug ID in debian/changelog (pointed out by Adam Borowski)
v2 -> v3
~~~~~~~~
* Switch to a simple debian/rules file as suggested by Alexis Murzeau
and Adam Borowski.
v1 -> v2
~~~~~~~~
Incorporate feedback from Adam Borowski:
* Use dh_installchangelogs instead of open-coding it
* Use gzip -n to avoid rendering the build non-reproducible
* Fix the installation path of debian/copyright by running dh_install,
* Create md5sums file
commit 6eb50bc388c544da7898f21f76a947c6dece09e2
Author: Andre Noll <maan@tuebingen.mpg.de>
Date: Tue Jun 4 16:22:05 2019 +0200
Makefile: Avoid warning when config.mak is not present.
Without the leading dash, make(1) complains if, for example,
make config.mak
is run on a pristine tree. The dash instructs make(1) to not emit
a warning if the file to include does not exist or cannot be remade.
commit 59673140b56375e802392331fec7cb4ab42d0ddd
Author: Andre Noll <maan@tuebingen.mpg.de>
Date: Fri May 31 20:23:02 2019 +0200
Run gzip with -n.
It is generally a good idea to not save the local file name and
timestamp in the compressed file, as this thwarts reproducible builds.
Suggested-by: Adam Borowski <kilobyte@angband.pl>
commit 2aa67575353d6b4e5a8411c69d96fabe80af41fc
Author: Andre Noll <maan@tuebingen.mpg.de>
Date: Wed May 22 15:56:31 2019 +0200
New make targets: exe, build-arch, man and build-indep.
It's good practice to provide separate make targets for generating
arch-dependent files (e.g., executables) and for arch-independent files
(e.g., manual pages). Currently there is only one file of either type
which gets installed by the make target, but this might change.
commit d48e676ab44873c402acbafc5d7602fdee6a05fb
Author: Andre Noll <maan@tuebingen.mpg.de>
Date: Tue May 21 00:09:51 2019 +0200
make distclean: Remove also configure.sh.
All derived files should be removed by the distclean target.
commit 54b9de32d887856379b9874335d4d59740eb111e
Author: Andre Noll <maan@tuebingen.mpg.de>
Date: Tue May 21 11:54:25 2019 +0200
Install man pages in compressed form.
This is generally a good idea since all versions of man(1) support
at least gzip-compressed manual pages.
commit ac2fb50196128ab8cb687b3e7f746be4ab46a935
Author: Andre Noll <maan@tuebingen.mpg.de>
Date: Mon May 20 19:09:30 2019 +0200
Install man page in section 6.
The manual page of the standard fortune program is part of section 6
(Games Manuals), so the tfortune man page should be installed there
as well rather than in section 1.
commit 6f18187fadd61f42a8e207342b27f17d9b1b9f77
Author: Andre Noll <maan@tuebingen.mpg.de>
Date: Sun Feb 17 12:39:40 2019 +0100
Avoid duplication in version, README, man page.
URLs and the email address are currently spread out over multiple
files. This commit cleans up the mess by defining everything in
Makefile and adjusting other places to use the information from there.
We use the opportunity to add a link to the author's home page.
version-gen.sh is made generic, i.e., it does not refer to tfortune
any more.
commit 6275dd846813572558b81d96fe04da9a26a73306
Author: Andre Noll <maan@tuebingen.mpg.de>
Date: Sun Jan 20 22:01:35 2019 +0100
Fix --basedir completion.
Silly braino.
commit 6946e3b25fb2028e20e3593e5bc2658cd3632f78
Author: Andre Noll <maan@tuebingen.mpg.de>
Date: Sun Jan 20 00:17:36 2019 +0100
Update copyright year.
commit dfec53e2395536c9f4d62961d561eee656d79c04
Author: Andre Noll <maan@tuebingen.mpg.de>
Date: Sun May 13 19:23:33 2018 +0200
com_help(): Fix comma placement.
We never want to print a comma at the beginning of the line.
commit 7acb033860d1e186999e799617be76d32aeb45e8
Author: Andre Noll <maan@tuebingen.mpg.de>
Date: Sun May 13 17:27:07 2018 +0200
epi_iter_new(): Use xrealloc().
This way we get proper error checking.
commit b4aae30257e0822ee2229cd761d8c50a8d54748e
Author: Andre Noll <maan@tuebingen.mpg.de>
Date: Sun May 13 12:51:00 2018 +0200
txt2ast(): Mark iovec structure as const.
The function does not modify the fields of "tx".
![[bug history graph]](https://qa.debian.org/data/bts/graphs/t/tfortune.png){kind=link}