vcswatch reports that
this package seems to have new commits in its VCS but has
not yet updated debian/changelog. You should consider updating
the Debian changelog and uploading this new version into the archive.
Here are the relevant commit logs:
commit b48895186f18cbe6e9b82dca3490132fc2777077
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Fri Sep 13 00:08:38 2019 +0200
Update changelog
commit 8dd81338b9751ad6ec0e67d004e35cec73f1288d
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Fri Sep 13 00:07:25 2019 +0200
debian/po/templates.pot: Update
commit 8961691fa2dae1f3d1f56d1bb80b0cb083e32736
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Thu Sep 12 16:07:08 2019 +0200
Update changelog
commit fcd160914fe8a255a89f0094a558838c43961456
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Thu Sep 12 14:14:37 2019 +0200
Update changelog
commit 389151c3ff0f4912f176a1979c8cb14fd9f444fb
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Thu Sep 12 13:34:50 2019 +0200
Refresh patches
commit 154177e460bb183f655fd9f869ef5cc5f0ecb2d8
Merge: 4d21f2d334 8b8890d6ff
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Thu Sep 12 13:20:52 2019 +0200
Update upstream source from tag 'upstream/3.0.4'
Update to upstream version '3.0.4'
with Debian dir d43fb2cba0a346dd5c283d8c4bd1061624879848
commit 4d21f2d33430229c693cf2999e50939a0eaf6cea
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Sun Sep 8 22:30:10 2019 +0200
debian/templates: Fix README.Debian's path
Also note that the package needs to be installed to find it.
Thanks: Justin B Rye for the help in phrasing on debian-l10n-english
Closes: #939770
commit e687cc231218ce5d4b1a34dcdba49f03d4f874df
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Sun Aug 18 15:35:03 2019 +0200
Update changelog
commit 05f6b750e21c26a216b5672fc9fed3fc3e106b9f
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Sun Aug 18 15:32:53 2019 +0200
Ignore failing tests on architectures where Lua tests are failing
commit 8319d83122b227c3ff4d3832f5db7f8ece4ff05d
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Sat Jul 27 22:52:45 2019 +0200
Update symbols files
commit 5864657aefc16605f106c76347a2835283e8eade
Author: Peter Wu <peter@lekensteyn.nl>
Date: Sat Jul 27 14:39:38 2019 +0100
debian/rules: reduce log spam from asn1 target
There are 3694 warnings for one of the following two messages:
UserWarning: The same field names for different types. Explicit field renaming is recommended.
UserWarning: The same type names for different types. Explicit type renaming is recommended.
Both warnings are accompanied by some context. Since the packager is
unlikely going to address these issues, and CI systems struggle with the
size of the generated logs, disable this subset of warnings. The output
of `ninja asn1` shrinks from 28191 lines (2.4MiB) to 483 lines (32KiB).
Change-Id: I44e9e1ab40f2255136fb1440e3bde2ccc9e55295
commit dfb513a9be734b096470481b31f04674f1998c7f
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Sat Jul 27 21:43:50 2019 +0200
Update changelog
commit ea981e1a222f0218d5bfdea0dc71259c9db85fdb
Merge: e3fd46fa0d b65ae229f4
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Sat Jul 27 20:32:32 2019 +0200
Merge branch 'debian/experimental' into debian/master
commit b65ae229f4a6b06f2c119d8878ee8c80a7721d7a
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Sat Jul 27 19:51:41 2019 +0200
Update changelog
commit 0c55d68d0cfdc3b4333965a61ff585e187a9bb33
Merge: ba3b3e28a7 0bb5265e25
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Sat Jul 27 19:41:07 2019 +0200
Update upstream source from tag 'upstream/3.0.3'
Update to upstream version '3.0.3'
with Debian dir 97f8b57c77bbb5ad26a26d2adcf2495002af80ff
commit ba3b3e28a75e565d56e7a0b889f6c3e006d35bdc
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Thu Jul 25 16:50:11 2019 +0200
Make wireshark depend on the same version of wireshark-qt
commit e3fd46fa0d3690b495e4cc1cc74272ad29740141
Merge: 4f80b27fcc e38e122f92
Author: Balint Reczey <rbalint@debian.org>
Date: Sat Jul 20 21:23:18 2019 +0000
Merge branch 'use-dpkg-divert' into 'debian/master'
Fix permission change in case of local diversions
See merge request debian/wireshark!3
commit e38e122f922c984d3f566b1820dccf0742981c78
Author: Topi Miettinen <toiwoton@gmail.com>
Date: Sat Jul 20 11:46:51 2019 +0300
Fix permission change in case of local diversions
/usr/bin/dumpcap may be locally diverted to somewhere else, so let's
query dpkg-divert for the current location.
Signed-off-by: Topi Miettinen <toiwoton@gmail.com>
commit 4f80b27fcce698d94d1ad0056ae04fe7f2f28eec
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Wed Jul 17 23:28:07 2019 +0200
Update changelog
commit 153abd04897c4e6a174479eb427c370c367638dd
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Mon Jul 15 21:38:16 2019 +0200
debian/gitlab-ci.yml: User minimal reference configuration
commit c8bed115d064131ac7dc47786769f1ba3a41e697
Merge: 8ba05bd239 5224160371
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Wed Jul 17 23:19:19 2019 +0200
Update upstream source from tag 'upstream/2.6.10'
Update to upstream version '2.6.10'
with Debian dir 93d4dd4f7fa45518e6e4aacf6097499f2417ce2c
commit 5224160371483490916fdb4667a532b4c1b74ede
Merge: a5a1ca6c88 7ba4efc47f
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Wed Jul 17 23:18:05 2019 +0200
New upstream version 2.6.10
commit 7ba4efc47fe9953615c751b7758edcaa5c23e332
Author: Gerald Combs <gerald@wireshark.org>
Date: Wed Jul 17 10:36:25 2019 -0700
Build 2.6.10.
Change-Id: Ic4d2011da5e95c298a5d5dbd3e1ac35dd1292783
Reviewed-on: https://code.wireshark.org/review/33988
Reviewed-by: Gerald Combs <gerald@wireshark.org>
commit 8fc0148955c9ea8df887adef475b6441c25038bb
Author: Gerald Combs <gerald@wireshark.org>
Date: Tue Jul 16 12:18:22 2019 -0700
Prep for 2.6.10.
Change-Id: I2e127978058e848d3011c3fa399702c99f9df91f
Reviewed-on: https://code.wireshark.org/review/33968
Reviewed-by: Gerald Combs <gerald@wireshark.org>
commit c8b0b5a4d27e21a0aad44a6ea2350b29c626edd6
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Mon Jul 15 21:38:16 2019 +0200
debian/gitlab-ci.yml: User minimal reference configuration
commit 987275392208b78a2330ebc34225759a43ce47cb
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Mon Jul 15 21:01:34 2019 +0200
Report upstream and package version instead of git revision
commit c95428aee0c7c089f4083965fa8c6741e7f761ef
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Mon Jul 15 20:40:16 2019 +0200
Don't update version with tools/make-version.pl
commit 9424c8963692a218b555fb4a6454535658671ca2
Author: Stig Bjørlykke <stig@bjorlykke.org>
Date: Sun Jul 14 21:33:52 2019 +0200
Qt: Check for NULL pointer in profile->reference
Check for NULL pointer before using profile->reference in strcmp()
because this will give a crash. Doing a copy profile from a new profile
will set the reference to NULL in get_profile_parent().
Use an unambiguously profile reference value NULL as profile->reference
when creating a new profile to align with when copy from a new profile.
Change-Id: Id61d5138ac8723e7c7ebad4d2252cf659c7569d4
Reviewed-on: https://code.wireshark.org/review/33937
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
(cherry picked from commit 5ad368fd1888963a1714d1ad36ab09219feaa926)
Reviewed-on: https://code.wireshark.org/review/33953
commit 8088747f11a37ca12f9afd8f57b30c348401a2ac
Author: Guy Harris <guy@alum.mit.edu>
Date: Mon Jul 15 01:22:33 2019 -0700
Clean up indentation.
Change-Id: I072ae41e48583ed52679cc58fb3b65e7654bf3ab
Reviewed-on: https://code.wireshark.org/review/33947
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit 151159ad90f6561974dd4639f2a7df4a8b99cb0d)
Reviewed-on: https://code.wireshark.org/review/33949
commit 5a6196025d99c4077949d85eca4479445e8335c0
Author: Guy Harris <guy@alum.mit.edu>
Date: Mon Jul 15 01:01:25 2019 -0700
Fix whitespace.
Change-Id: Ic30151ee08d4561740f8a27ca5f57c695dd0e19b
Reviewed-on: https://code.wireshark.org/review/33943
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit 1d4d43c2d88e039986b2b966caf2118cba2caa17)
Reviewed-on: https://code.wireshark.org/review/33945
commit 152b16b5ee9eb83fa2fbdd9f48fbce29304898e1
Author: Peter Wu <peter@lekensteyn.nl>
Date: Mon Jul 8 11:21:56 2019 +0200
gitlab-ci: use opensuse/leap:42.3 image.
The former official image has been deprecated in favor of the
opensuse/leap one.
Change-Id: If926b93bf32e6a72b3299abe0d5e34b0418d7b14
Reviewed-on: https://code.wireshark.org/review/33878
Reviewed-by: Dario Lombardo <lomato@gmail.com>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
commit 6ea87c4faad210cba37c6bd7088807431c33e253
Author: Gerald Combs <gerald@wireshark.org>
Date: Sun Jul 14 08:48:09 2019 +0000
[Automatic update for 2019-07-14]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: I4f8803ec89172b2154db12973b908fe9279ef482
Reviewed-on: https://code.wireshark.org/review/33931
Reviewed-by: Gerald Combs <gerald@wireshark.org>
commit df01e4d5bc144b344c148df4960035017040790b
Author: Peter Wu <peter@lekensteyn.nl>
Date: Sun Jul 7 13:18:06 2019 +0200
dumpcap: fix uninitialized memory read on dumpcap -d errors
Reproduce with: dumpcap -pdf bad
Change-Id: I8c1f80c9d88262bc57651e886740083ea8e6ad52
Fixes: 4d6cb744df ("Add a "-d" flag to dumpcap")
Reviewed-on: https://code.wireshark.org/review/33863
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
(cherry picked from commit 1f527124444eca32623d1b7a5303afd7b46e322e)
Reviewed-on: https://code.wireshark.org/review/33868
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
commit 56d67051923247ac3f990b6729cba96059be04b1
Author: Gerald Combs <gerald@wireshark.org>
Date: Sun Jul 7 08:46:44 2019 +0000
[Automatic update for 2019-07-07]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: I26adeb9c1585db53a9734e8e0b04cbe1a55add79
Reviewed-on: https://code.wireshark.org/review/33861
Reviewed-by: Gerald Combs <gerald@wireshark.org>
commit 000cc11d8fe96a3e0bf164d367c85d2d046a5943
Author: Peter Wu <peter@lekensteyn.nl>
Date: Wed Jul 3 12:11:20 2019 +0200
Qt: fix QIcon crash on exit on Ubuntu 16.04 with Qt 5.5.1
The icon used by DisplayFilterCombo is not cleaned up when MainWindow is
destroyed, so Qt cleans it up on program exit. Due to another Qt bug
(https://bugreports.qt.io/browse/QTBUG-50829, fixed in Qt 5.8.0), the
QIconEngine plugin that backs the QIcon was unloaded before the cleanup
was complete. As a result, calling the QIcon destructor would result in
calling the unmapped QIconEngine destructor code, leading to a
segmentation fault.
master-3.0 and later are not affected since a similar fix was added via
v2.9.0rc0-2728-gabfe9572bd.
Bug: 15241
Change-Id: Ie6bd8e645a2c754d6b57290e7084eaa324696253
Fixes: v2.6.2rc0-170-g3a0da5fbb2 ("Qt: Create the main display filter combo sooner.")
Reviewed-on: https://code.wireshark.org/review/33828
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
commit 6ed140178dce0ef595e303fa445c668323326c0c
Author: Guy Harris <guy@alum.mit.edu>
Date: Mon Jul 1 12:27:12 2019 -0700
Pass the correct value to ascendlex_destroy().
It takes a yyscan_t as an argument, not a pointer to a yyscan_t; a
yyscan_t is a pointer to the scanner state. (A pointer to it is passed
to the init routine so that it can be set to point to the allocated
state, not because it's a structure itself.)
Change-Id: If80ca1caaa07d8a966df8d07f989b722869ac58b
Reviewed-on: https://code.wireshark.org/review/33814
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit 58cc932d2f3d7dcb55685c32a02bb7e8fec81b82)
Reviewed-on: https://code.wireshark.org/review/33816
commit 20179f4bd8bcf9e5ab57ec4e79690f37c29c5552
Author: Maksim Salau <maksim.salau@gmail.com>
Date: Thu Jun 27 21:19:33 2019 +0300
wiretap: ascend: Destroy lexer state after parsing
Lexer private structure is initialized but never destroyed or reused.
Change-Id: I61d43b4cb14a2d3b3706267eb393e4562adb00f9
Reviewed-on: https://code.wireshark.org/review/33809
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit bd5ba2ba7a6aa3fdc12d48bf9f84c2fe5f784dbb)
Reviewed-on: https://code.wireshark.org/review/33812
commit 85ed58bf2eccd85104abbfccde8064ac19c5b15d
Author: Pascal Quantin <pascal@wireshark.org>
Date: Mon Jul 1 18:57:43 2019 +0200
MAC LTE: implement 3GPP 36.321 CR 1450
The NB-IoT DPR MAC CE is not included in the L field of the CCCH MAC CE.
Change-Id: I497176dfc722f0080e544bbc73845cfce2064e2d
Reviewed-on: https://code.wireshark.org/review/33805
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
(cherry picked from commit 3f7e6f5a7d8866d8f3f4a1ca18a7db360eab5216)
Reviewed-on: https://code.wireshark.org/review/33807
commit 1c43f8bd2e5696d1c10b3be06c716a69068daea2
Author: Guy Harris <guy@alum.mit.edu>
Date: Mon Jul 1 00:12:40 2019 -0700
Distinguish "Interface went down" from "Interface disappeared".
Have separate errors for "the interface went down" on Linux and "the
interface no longer exists" on *BSD/Darwin/Windows.
Change-Id: I1951c647e88eb7ebeb20a72d9e03a2072168c8e5
Reviewed-on: https://code.wireshark.org/review/33794
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit 37ff9dacb9e27bdf7b6b296bebad11694c6ba167)
Reviewed-on: https://code.wireshark.org/review/33796
commit c3eaf80b0e226532eb921738024a68c0de1b1a2d
Author: Guy Harris <guy@alum.mit.edu>
Date: Sun Jun 30 19:29:21 2019 -0700
Libpcap may now say "The interface disappeared" if it did.
A recent change to libpcap means that the error message if an interface
disappears (e.g., removing a hot-pluggable device, or shutting down a
PPP connection that was dynamically set up) is "The interface
disappeared" rather than "The interface went down" - on FreeBSD,
DragonFly BSD, OpenBSD, and Darwin-based OSes, capturing continues with
no error if the interface is configured down, but either ENXIO or EIO
(depending on the OS) is delivered if the interface disappears.
Treat that error as another one to show the user without the "report
this to the Wireshark developers" note.
Change-Id: I477d87957ce30a52385f07f4b47a7824e3fca2c7
Reviewed-on: https://code.wireshark.org/review/33790
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit 8a4ce74ac9a3be8c752c1b405349d6083f76e657)
Reviewed-on: https://code.wireshark.org/review/33792
commit 10b0b3eb47fd7f77932c60d1a6dbd3ca2bc911b7
Author: Guy Harris <guy@alum.mit.edu>
Date: Sun Jun 30 15:58:22 2019 -0700
Update a comment, and shuffle tests.
Linux isn't the only platform where libpcap may return "The interface
went down".
Put the test for "The interface went down" first.
Change-Id: I5241f0744bd12eb5e090b8e1717268bdf8392ea7
Reviewed-on: https://code.wireshark.org/review/33785
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit 03517b692b8b5cb934675da282d2452157b1aba3)
Reviewed-on: https://code.wireshark.org/review/33788
commit bedeee579e2746455777eda48610d3d8f156a572
Author: Gerald Combs <gerald@wireshark.org>
Date: Sun Jun 30 08:50:31 2019 +0000
[Automatic update for 2019-06-30]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: Ibbad0e075a58b4a6af43bc098029114c0a8f9dcd
Reviewed-on: https://code.wireshark.org/review/33778
Reviewed-by: Gerald Combs <gerald@wireshark.org>
commit 0793039013c77855cbb537cdc23ea1a68fe8cac6
Author: Guy Harris <guy@alum.mit.edu>
Date: Wed Jun 26 13:08:51 2019 -0700
With -T, change the packet's encapsulation type as well.
Bug: 15873
Change-Id: I8d36b0fba42481b5e27e9ad9643d3603486c3645
Reviewed-on: https://code.wireshark.org/review/33745
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit dc7b757c914761b5114954d1573aca0f6d03baae)
Reviewed-on: https://code.wireshark.org/review/33747
commit 7e90aed666e809c0db5de9d1816802a7dcea28d9
Author: Dario Lombardo <lomato@gmail.com>
Date: Mon Jun 24 23:36:15 2019 +0200
asn1: don't increment a buffer beyond its end.
Bug: 15870
Change-Id: I04cbb822f0e77c8e0ac8513e3a5c13116920ca6e
Reviewed-on: https://code.wireshark.org/review/33731
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
(cherry picked from commit 45a3d0787f3c9f6f5fb5b53a8c29771b3f28e406)
Reviewed-on: https://code.wireshark.org/review/33736
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Reviewed-by: Gerald Combs <gerald@wireshark.org>
commit eb1e1794ef0480358e1b2c7c83ee4c0f5df9b6fd
Author: Gerald Combs <gerald@wireshark.org>
Date: Sun Jun 23 08:49:00 2019 +0000
[Automatic update for 2019-06-23]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: I8f736d1236f8836809592779a2d90a134132335f
Reviewed-on: https://code.wireshark.org/review/33716
Reviewed-by: Gerald Combs <gerald@wireshark.org>
commit b873bddfa4cece3d1641793997ef6f5e5981d35f
Author: Guy Harris <guy@alum.mit.edu>
Date: Wed Jun 19 16:57:40 2019 -0700
Fix error message for an unknown pcapng version number.
We were using fields in the pcapng_t that weren't set yet to report the
version number in question; use the variables we were checking.
Change-Id: Ib03bafe62d8c7b1aa54b2ef22640e3b00722142a
Ping-Bug: 15862
Reviewed-on: https://code.wireshark.org/review/33671
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit d6472862c5a21b82986fd6f56730c49a886fe2f5)
Reviewed-on: https://code.wireshark.org/review/33673
commit 5cf5bee8c9188c25bce77c4f2b8165590e159bf2
Author: Dario Lombardo <lomato@gmail.com>
Date: Wed Jun 19 14:15:34 2019 +0200
sshdump: fix bug in --remote-sudo.
Fix documentation as well.
Bug: 15845
Change-Id: I1b4e50c21887afa6a60b76de6cc169a1d0b5067a
Reviewed-on: https://code.wireshark.org/review/33658
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
(cherry picked from commit ed34c3de14fbaed36ce3243668b28af411dfb085)
Reviewed-on: https://code.wireshark.org/review/33663
commit a74c875e138197c5d34165abd20dde70db69f012
Author: Pascal Quantin <pascal@wireshark.org>
Date: Tue Jun 18 20:21:00 2019 +0200
GSM RLC/MAC: fix dissection of SI Message List IE
Change-Id: Ia3a4255ecd78e480135bbbbeccd9c0268c105400
Reviewed-on: https://code.wireshark.org/review/33648
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Reviewed-on: https://code.wireshark.org/review/33650
commit 9860ad94271653b71322def0dfdf32502e4f9559
Author: Gerald Combs <gerald@wireshark.org>
Date: Sun Jun 16 08:52:47 2019 +0000
[Automatic update for 2019-06-16]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: I1ec0e3558be17ee05dca3eb99679e4b1f547ddb9
Reviewed-on: https://code.wireshark.org/review/33618
Reviewed-by: Gerald Combs <gerald@wireshark.org>
commit 714640a07db6bfee83ed3316b70bafd8b092c8a5
Author: Pascal Quantin <pascal@wireshark.org>
Date: Wed Jun 12 22:46:57 2019 +0200
Qt: fix 'open protocol preferences' shortcut for protocol subtrees
Bug: 15836
Change-Id: If0a1b6fbb7a2cf7b73ef91c07a6f1b180fc030a5
Reviewed-on: https://code.wireshark.org/review/33570
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
(cherry picked from commit fb0d1ee24edeed29baac1bdb053d1553580d431c)
Reviewed-on: https://code.wireshark.org/review/33577
commit 673f80b754ad9662de184996b3c0dd2b41d0dd15
Author: Dario Lombardo <lomato@gmail.com>
Date: Sat Jun 8 22:59:20 2019 +0200
tshark/tfshark: fix error message.
Bug: 15825
Change-Id: Iec8dff38dd89e3947f3fe7053e38101c3ad7b1b2
Reviewed-on: https://code.wireshark.org/review/33523
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78@netscape.net>
(cherry picked from commit 5f105526af2a5023d9dab1f2a1fb912ea3922bf0)
Reviewed-on: https://code.wireshark.org/review/33532
Petri-Dish: Michael Mann <mmann78@netscape.net>
commit 13fda79077da6e61eeaa5e7f3ff1d47ab73e7cd7
Author: Gerald Combs <gerald@wireshark.org>
Date: Sun Jun 9 08:52:58 2019 +0000
[Automatic update for 2019-06-09]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: Ie3f1cfe971e19dba8de6950d0874c0426d76849e
Reviewed-on: https://code.wireshark.org/review/33528
Reviewed-by: Gerald Combs <gerald@wireshark.org>
commit 8e4ce399dc5e2d887b8de017e007edeb0b57e66b
Author: Guy Harris <guy@alum.mit.edu>
Date: Tue Jun 4 15:54:42 2019 -0700
Don't assume padding is present at the end of UNIX Info2.
Check whether the byte count includes the padding before skipping it; it
may not be present (at least not if this is at the end of the byte
parameters).
Change-Id: I4385a4713cb6813a6e8519005288d6ef5a28f028
Reviewed-on: https://code.wireshark.org/review/33493
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit 338ce1b67217e5e5f9ee81540748e34766fd85c2)
Reviewed-on: https://code.wireshark.org/review/33495
commit 3aca4dc4ea98f9a135b41e316b2fd6deb068f99c
Author: Guy Harris <guy@alum.mit.edu>
Date: Tue Jun 4 15:14:30 2019 -0700
Fix the dissection of Find First2 Query EA Info information.
The file name doesn't appear to be padded, and may have a 1-byte null
terminator (yes, 1 byte, according to MS-CIFS) at the end, not included
in the file name length.
Change-Id: I8510434b3b5aec092290697c336924d6ff6be763
Reviewed-on: https://code.wireshark.org/review/33486
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit 782c4e496bc6d3610f504b06690e7848abd4453a)
Reviewed-on: https://code.wireshark.org/review/33491
commit 79f6042ce11faa5a7d117411014f003bb2a9340b
Author: Guy Harris <guy@alum.mit.edu>
Date: Tue Jun 4 14:27:12 2019 -0700
Handle some weirdness with the primary domain field in NegProt replies.
Sometimes there appears to be an extra byte before that field; try to
catch some of those cases.
Expand comments discussing various weirdness with that field, including
a note that clients might not pay any attention to it, so maybe we just
have buggy servers talking to clients that don't care about those
particular bugs.
Change-Id: I4d35d2e2c475d4da37debedfed31b891e6f3cfa8
Reviewed-on: https://code.wireshark.org/review/33481
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit 021e994293449ac263b0b234660847e27363a660)
Reviewed-on: https://code.wireshark.org/review/33488
commit 0a1e45a3b630dfb2f1b626e84d606515da477228
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Tue Jun 4 19:11:12 2019 +0200
Update changelog
commit 6ea1e8c8187cf47ef3f68db289c14d914b0e6c33
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Wed Jun 5 00:08:52 2019 +0200
Update symbols
commit 49d510ff3a1c4abfde8c0a81f05a5b67d3b10906
Author: Guy Harris <guy@alum.mit.edu>
Date: Tue Jun 4 14:44:19 2019 -0700
Fix the dissection of create temporary file responses.
According to MS-CIFS:
1) the file name is not one of those "buffer format followed by
a string" fields, it's just a string, so there's no buffer
format field;
2) it's always in ASCII, so ignore the "Unicode strings" flag.
Note that, for the *request*, the *directory* name isn't claimed to
always be ASCII, so honor the "Unicode strings" flag there.
Change-Id: I495b7be8257d941ccf4b45126a44d25cf0ab2c12
Reviewed-on: https://code.wireshark.org/review/33482
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit 6259b79d257fac11cda823b7bf0e4f291d68186b)
Reviewed-on: https://code.wireshark.org/review/33484
commit 03b81325125ff7d57919fb79f2c9224e474f81cd
Author: Guy Harris <guy@alum.mit.edu>
Date: Tue Jun 4 13:02:39 2019 -0700
Add some comments indicating what protocol was selected.
Note, for all of the different word count values, what protocol or
protocols it represents.
(If we have the Negotiate request, and can thus determine which protocol
was selected based on the set of protocols the client was willing to
accept, should we verify that the server selected a protocol for which
the given word count value was used, and add an expert info if it
didn't?)
Change-Id: I95ad4b1245bf2a04fdef4746815352967d8ac0a6
Reviewed-on: https://code.wireshark.org/review/33475
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit cdaa04cc30669cb0a9272b692cf5a152ef6612c4)
Reviewed-on: https://code.wireshark.org/review/33477
commit 53f176b0bd1bc51efb326398d86a1161bf9713ac
Author: Guy Harris <guy@alum.mit.edu>
Date: Tue Jun 4 12:46:44 2019 -0700
Register the "missing word parameters" expert info.
Change-Id: I6dbd8af61bf8ee4e55264116c1838d7bdf1b1a67
Reviewed-on: https://code.wireshark.org/review/33468
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit c591049194a39415ea3bc25935d48b72bd7a53fb)
Reviewed-on: https://code.wireshark.org/review/33472
commit 8abffd99292c0dc13bec37469393d4a1e1772ced
Author: Guy Harris <guy@alum.mit.edu>
Date: Tue Jun 4 12:44:09 2019 -0700
Don't assume an NT Create AndX request has all the word parameters.
It *should*, but a malicious or otherwise malformed packet might not
have them. One of them is the file name length; if it's missing, we
can't dissect the file name, as we don't know how long it is.
Change-Id: Ie259e2d8ec65f5d53d466382d89889902495d2c8
Reviewed-on: https://code.wireshark.org/review/33467
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit f0c13af7d3862f11b47cfcb12ccc80341122395d)
Reviewed-on: https://code.wireshark.org/review/33471
commit 8bfd8705b0cca07c93bbc8b06ad0b7db96badc7b
Merge: 07808e3a9e 01f4bdc83e
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Tue Jun 4 18:52:26 2019 +0200
Update upstream source from tag 'upstream/3.0.2'
Update to upstream version '3.0.2'
with Debian dir ec33bd7a8ff64163c6756a02a3805f5c95683132
commit c839f9edf496eba21a4e5f93dfe518af12e81495
Author: Gerald Combs <gerald@wireshark.org>
Date: Mon Nov 19 10:20:44 2018 -0800
rpm-setup.sh: We no longer use FOP or AsciiDoc.
Change-Id: I3b6e200be149d12a42604528a695aae98d310b9c
Reviewed-on: https://code.wireshark.org/review/30719
Reviewed-by: Gerald Combs <gerald@wireshark.org>
(cherry picked from commit 8788c990b540054c512650660bf6d0f4db3df749)
Reviewed-on: https://code.wireshark.org/review/33465
commit 07808e3a9ea9aebaec2ac72f6d9f6a81b59ad1f4
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Tue Jun 4 18:24:27 2019 +0200
debian/copyright: List translators who contributed to debian/po/*
commit 00711e102b2fe13b857fb3707e6896ee89df8221
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Tue Jun 4 18:09:55 2019 +0200
debian/po/templates.pot: Update description and copyright
commit 8e3062b0090ba0b0774eac47525f9bb34b77743d
Author: Gerald Combs <gerald@wireshark.org>
Date: Sun Jun 2 08:50:38 2019 +0000
[Automatic update for 2019-06-02]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: Ic1ced8cfe7c02d79f5f92a1e40b5a89a275335ee
Reviewed-on: https://code.wireshark.org/review/33445
Reviewed-by: Gerald Combs <gerald@wireshark.org>
commit 9997eef374dfe91b5376c3e59159eaeeb05beb23
Author: Jonas Jonsson <jonas@ludd.ltu.se>
Date: Thu May 30 21:18:19 2019 +0200
btle: Correctly detect l2cap fragment start
The first L2CAP PDU fragment starts with the 4 octet long L2CAP header
consisting of the Length and the CID fields. The Length field doesn't
include the header itself. Thus the Length field in the BLE Data header
will be 4 octets larger than the L2CAP PDU header Length field if the
packet wouldn't be fragmented.
The current implementation doesn't correctly detect the start fragment
causing reassembly to fail as it compares the BLE Data Length with the
L2CAP Length without compensating for the header.
By increasing the L2CAP PDU Length field with the header length the
reassembly works.
Rename the variable to better reflect what length it actually
represents.
Bug: 15807
Change-Id: Idcb6bdccc4daae756a63a9bae0839fe25ae99f23
Reviewed-on: https://code.wireshark.org/review/33428
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
(cherry picked from commit 49b6523c6cd4f8c56f428797283e150e63a52aad)
Reviewed-on: https://code.wireshark.org/review/33429
(cherry picked from commit 7b70ef08a0f9403c287177018c8d21a7e558cccf)
Reviewed-on: https://code.wireshark.org/review/33430
commit 8ba05bd239edf6fd55bc64f8938a2c13aecd473d
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Thu May 30 22:14:25 2019 +0200
Update changelog
commit 9dff20b94ae52910e8f62f06111fc6d9ca8f1bb9
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Thu May 30 22:02:30 2019 +0200
Refresh patches
commit 0504da1655f41371311bf0482152a21cf1c3ce93
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Thu May 30 22:01:02 2019 +0200
Drop obsolete CVE-2019-12295.patch
commit 11d84aa985d95b2c6217fa07e8aa92f7eab68f78
Merge: 757905b57c a5a1ca6c88
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Thu May 30 22:12:31 2019 +0200
Merge tag 'upstream/2.6.9' into debian/buster
Upstream version 2.6.9
commit a5a1ca6c884b7a28b12998cc134b1d857bb5a57a
Merge: 0019d0d708 f1627e90c1
Author: Balint Reczey <balint.reczey@canonical.com>
Date: Thu May 30 21:55:09 2019 +0200
New upstream version 2.6.9
commit c0a31ae75a50ff89fc3cc6c3bea4decfc4c8f264
Author: Guy Harris <guy@alum.mit.edu>
Date: Wed May 29 10:31:13 2019 -0700
Fix handling of headers in body part.
Check whether the unfolded-and-compacted header has only printable
characters, not whether the full header does - the full header may
include LWSP, which includes HT, CR, and LF, none of which are
considered "printable", so valid headers were being treated as not being
headers, causing mis-dissection of some packets.
We don't need to split the header name from the value -
is_known_multipart_header() stops comparison at the end of the header
name.
Change-Id: I96e4ac0b69df726b984ee7faeea19eda18be223c
Reviewed-on: https://code.wireshark.org/review/33417
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
(cherry picked from commit 78a106dc2a5516b9b9cf42cf973d990828cac54e)
Reviewed-on: https://code.wireshark.org/review/33419
commit d8e91a7a7b5afa80c56056f3ef246434abbbc298
Author: Guy Harris <guy@alum.mit.edu>
Date: Tue May 28 11:03:11 2019 -0700
Clean up indentation.
Change-Id: Idfa3e15eaa1d764f66d630878f1c44561169d8bf
Reviewed-on: https://code.wireshark.org/review/33409
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit 4997002458e5262aa88c3b0d8a132d2237f909d4)
Reviewed-on: https://code.wireshark.org/review/33411
commit 5911e56082eb0dc8ebc1113de69e5e60606e235c
Author: Eric Wild <ewild@sysmocom.de>
Date: Mon May 20 12:56:02 2019 +0200
Fix for incorrectly decoded RSL ERR REP/BCCH INFORMATION optional IEs
This patch adjusts the inconsistent usage of the is_mandatory flag
passed to the dissect_* functions for optional IEs, which fixes the
issue of incorrectly parsed RSL ERR REP optional IEs and the equally
broken BCCH INFORMATION optional IE parsing.
Bug: 15789
Change-Id: I94ea8fe110d8d6aa6ebd0cec5013d3cc8fd55311
Reviewed-on: https://code.wireshark.org/review/33269
Reviewed-by: Harald Welte <laforge@gnumonks.org>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
(cherry picked from commit bc9f570680862c7835eb58488230b40a9e89251e)
Reviewed-on: https://code.wireshark.org/review/33389
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot
commit 6077a35c05ca74e0b5a8372e9d8e8fb640ec27db
Author: Guy Harris <guy@alum.mit.edu>
Date: Mon May 27 18:27:44 2019 -0700
Clean up some ASCII vs. EBCDIC string handling.
In at least one capture, structure IDs are in ASCII even though the code
page in the header is an EBCDIC code page. Determine the structure ID's
character encoding based on whether it's the ASCII or EBCDIC version of
the ID value, not on the global character encoding.
We were using the *integer* encoding, not the *string* encoding, for the
"qprotect" field, which is a string; fix that.
Use STR_UNICODE for strings, as they're not guaranteed to consist of
characters that can be mapped to ASCII characters (even the common
subset of EBCDIC, not counting code page-dependent code points, has
non-ASCII printable characters in it).
Change-Id: I971dd7ae55617c27ebe88f31089b2495374593bf
Reviewed-on: https://code.wireshark.org/review/33399
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit b9c69d6ef8b2c759bb1b4be05240bba42038a051)
Reviewed-on: https://code.wireshark.org/review/33401
commit 393cd686cc367b687d69a9f1dbcf08144397dafa
Author: Guy Harris <guy@alum.mit.edu>
Date: Mon May 27 17:46:59 2019 -0700
Strings in mDNS TXT records are UTF-8.
Change-Id: Iedde17155aae71e9bc7ad3cc5185ea33e34e209c
Reviewed-on: https://code.wireshark.org/review/33391
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit 0ac699d621ab1e033cd7b3d576b2e746932e82b8)
Reviewed-on: https://code.wireshark.org/review/33396
commit 4336bfb1e1d355351777ef3c2b8b0259a1a0e27e
Author: Guy Harris <guy@alum.mit.edu>
Date: Mon May 27 17:43:23 2019 -0700
Strings in the CUPS browsing protocol are UTF-8.
Change-Id: I594a22acf9202f7b7ca2e4ee3c58c308c2cd7019
Reviewed-on: https://code.wireshark.org/review/33390
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit 1d88e9b25fd40a692777c9ab7fb503584afacf0d)
Reviewed-on: https://code.wireshark.org/review/33393
commit 757905b57c1abfeecc57572b838f138584e1c925
Author: Dr. Tobias Quathamer <toddy@debian.org>
Date: Mon May 27 16:09:36 2019 +0200
Debian release 2.6.8-1.1
commit e3312cb4ac26c0e73405db3f82016a5fa6ea36a5
Author: Dr. Tobias Quathamer <toddy@debian.org>
Date: Mon May 27 16:07:49 2019 +0200
CVE-2019-12295
In Wireshark 3.0.0 to 3.0.1, 2.6.0 to 2.6.8, and 2.4.0 to 2.4.14,
the dissection engine could crash. This was addressed in
epan/packet.c by restricting the number of layers and
consequently limiting recursion.
Closes: #929446
commit e2692730ba1010a20ef3ac54b41bb4c9b5efcd07
Author: Guy Harris <guy@alum.mit.edu>
Date: Sun May 26 11:43:07 2019 -0700
*Always* pair ENC_UTF_16 and ENC_UCS_2 with a byte order.
Big-endian and little-endian UTF-16 and UCS-2 aren't the same; always
associate them with a byte order ENC_ flag, to clarify what byte order
is being used. Yes, for big-endian, omitting the ENC_ flag, or using
ENC_NA, *happens* to work, because ENC_BIG_ENDIAN and ENC_NA *happen* to
be 0, but omitting ENC_BIG_ENDIAN doesn't make it sufficiently clear
that it's UTF-16BE or UCS-2BE.
Change-Id: Iecf7375763ce4922bd1b0676c9dc5a01731c2fec
Reviewed-on: https://code.wireshark.org/review/33374
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit 38dec96c656e438e1f09f7dda6327b85ffd0c479)
Reviewed-on: https://code.wireshark.org/review/33376
commit d272747b6599ccf489ee2d3870e0b7867c061d9e
Author: Gerald Combs <gerald@wireshark.org>
Date: Sun May 26 08:50:12 2019 +0000
[Automatic update for 2019-05-26]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: Ib303a6589882d920aae2dabdea4df8c739089b93
Reviewed-on: https://code.wireshark.org/review/33366
Reviewed-by: Gerald Combs <gerald@wireshark.org>
commit 6aa4428c89969e6fece4edd0712dd7f423dda8f8
Author: Guy Harris <guy@alum.mit.edu>
Date: Fri May 24 19:32:46 2019 -0700
*Little-endian* UTF-16.
ENC_UTF_16 does *not* go with ENC_NA; ENC_NA is for cases where the byte
order is "not applicable", such as a 1-byte number or a character
encoding where every character is encoded in 1 byte, but UTF-16 isn't
one of those cases, as a character is encoded in either 1 or 2 2-byte
values. This being a Windows thing, the byte order is little-endian.
Change-Id: Iab0db3fa2c5d2c25be209e4ed0ebd57827edbcd8
Reviewed-on: https://code.wireshark.org/review/33347
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit 2114dba1effebba50cdb611b2650b0a4a37761e4)
Reviewed-on: https://code.wireshark.org/review/33349
commit 5a9123ecb5bb7dee9cae90f3315fdb311c091e3c
Author: Guy Harris <guy@alum.mit.edu>
Date: Fri May 24 18:51:01 2019 -0700
"OEM Codepage" appears to mean "code page number"; show it in decimal.
Code page numbers are generally referred to by their number in decimal,
not hex.
Change-Id: I1dee3df09cf7b5efaca2f4144ee5fcbc8d3ee44c
Reviewed-on: https://code.wireshark.org/review/33343
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit cf89939a1966c37348ca14620c0afa9ca3a23c01)
Reviewed-on: https://code.wireshark.org/review/33345
commit 0558b2af3139af6e379125755391f932f751ae5f
Author: Jaap Keuter <jaap.keuter@xs4all.nl>
Date: Wed May 22 21:05:41 2019 +0200
SDP: show rtcp and rtcp-mux media attribute values
With the addition of handling the rtcp and rtpc-mux media attributes
(see cde023c3c5a08131495eb2574c00ff1f34cdce55) the default behaviour
of presenting the media attribute value itself was lost. This change
adds this back.
Bug: 15791
Change-Id: Ib0084b99961bfadf1d89c70b54bd4a0805f9b9f6
Reviewed-on: https://code.wireshark.org/review/33314
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
(cherry picked from commit d36b72e6b881b773e0f54a3a8339723955a05f71)
Reviewed-on: https://code.wireshark.org/review/33327
commit 1279b512c9164a180c6b6374b413c6cae027888c
Author: Jaap Keuter <jaap.keuter@xs4all.nl>
Date: Wed May 22 22:56:04 2019 +0200
DPNSS: dissect Service Indicator Code synch/asynch info
The DPNSS specification for the Service Indicator Code
Synch/Asynchronous Information field states that the lower three bits of
this field define the Data Type. This requires a filter of three bits,
in this case 0x7, instead of 0x3 which is two bits.
CID 1159107
Change-Id: I38eec252c771adf085f98c3be077c9de102a37d2
Reviewed-on: https://code.wireshark.org/review/33317
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
(cherry picked from commit 6cb990ccb03e3fa4154e080d8592f64ca45a9c7b)
Reviewed-on: https://code.wireshark.org/review/33324
commit 35bf3bcaeb280abcc23058780ad124a5e683ab93
Author: Gerald Combs <gerald@wireshark.org>
Date: Wed May 22 14:30:16 2019 -0700
2.6.9 → 2.6.10.
Change-Id: I283dd938ac462933dc473c61a776fcfa9ef51e38
Reviewed-on: https://code.wireshark.org/review/33319
Reviewed-by: Gerald Combs <gerald@wireshark.org>
commit f1627e90c1292405b238aae0c19b5ac52dfa38ad
Author: Gerald Combs <gerald@wireshark.org>
Date: Wed May 22 10:27:36 2019 -0700
Build 2.6.9.
Change-Id: Ia495991aeffb9135878e78a10d0db7eaa6983593
Reviewed-on: https://code.wireshark.org/review/33312
Reviewed-by: Gerald Combs <gerald@wireshark.org>
commit 9d5f0411bdd4670f2345d8b56a6939d4823063b5
Author: Gerald Combs <gerald@wireshark.org>
Date: Tue May 21 10:41:41 2019 -0700
Add dissection recursion checks.
Enforce a maximum layer limit in call_dissector_work and
dissector_try_heuristic.
Bug: 15778
Change-Id: I691868e980384b76a64f88de4db5bb7340a7c4aa
Reviewed-on: https://code.wireshark.org/review/33301
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Dario Lombardo <lomato@gmail.com>
Reviewed-by: Gerald Combs <gerald@wireshark.org>
(cherry picked from commit be9bdfda02a2498c6f65122d80e3a8b4235dc7f5)
Reviewed-on: https://code.wireshark.org/review/33309
commit a361bb98d08ca4ae7849822643b33336274a933c
Author: Gerald Combs <gerald@wireshark.org>
Date: Tue May 21 15:45:49 2019 -0700
Prep for 2.6.9.
Change-Id: I6e698d5ef5757d3801d7971feba1dbff86ff0b6e
Reviewed-on: https://code.wireshark.org/review/33304
Reviewed-by: Gerald Combs <gerald@wireshark.org>
commit 83f20db0b12fa34e2336995b141e996235e12104
Author: Dario Lombardo <lomato@gmail.com>
Date: Mon May 20 15:31:59 2019 +0200
pcapng: fix the magic when bytes are swapped.
This value is used when checking if the file was generated on a
machine with different endianess. The error message changes from
"Unrecognized pcapng format or not pcapng data."
to
"dumpcap: Interface 0 is big endian but we're little endian."
Fix dumpcap.c and pcapio.c.
Ping-Bug: 15754
Change-Id: I3a31f873f01bcb3f1324410e70f29f285e56c715
Reviewed-on: https://code.wireshark.org/review/33274
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
(cherry picked from commit 3e53ec5e11e141c37aa26b3472cc45bd4cdbfb0d)
Reviewed-on: https://code.wireshark.org/review/33290
Petri-Dish: Dario Lombardo <lomato@gmail.com>
commit 427ceece106e5d394b0948b22ebcc739112296dd
Author: Guy Harris <guy@alum.mit.edu>
Date: Mon May 20 23:02:39 2019 -0700
Fix format_uri().
It was using the same index into the input and output strings, which
means that if it escaped any character, it would skip the next two
characters in the input sring.
It was also not clearing is_reserved before testing whether a character
was reserved, so once it saw a character that neede dto be escaped, it
would escape all subsequent characters.
It was only used in get_key_string(), which was never used, so it was
dead code, but let's at least fix it, even if we end up removing that
code, so that if we bring it back, we bring back a non-broken version,
and so that if anybody *else* uses it, it's not broken.
Change-Id: I36588efad36908e012023bcfbd813c749a6a254f
Reviewed-on: https://code.wireshark.org/review/33287
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit a409987eeaded5d7f6c7379530fbe856e9a97c7b)
Reviewed-on: https://code.wireshark.org/review/33293
commit a266bf0a3a1ece9c5404d7eefe102cc574cdef18
Author: Gerald Combs <gerald@wireshark.org>
Date: Sun May 19 08:52:57 2019 +0000
[Automatic update for 2019-05-19]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: Icb24c425cf5edb575b48865620dcc2b8f0119a7a
Reviewed-on: https://code.wireshark.org/review/33258
Reviewed-by: Gerald Combs <gerald@wireshark.org>
commit 5504228ad7a3be4460b1175230028be9523df825
Author: Guy Harris <guy@alum.mit.edu>
Date: Thu May 16 10:50:03 2019 -0700
In pcapng_open(), don't use the local pcapng_t once we know it's a pcapng file.
Use the local one *only* while we're trying to determine whether we have
a pcapng file or not; once we know we have a pcapng file, and have
allocated a pcapng_t and attached it to the wtap structure, pass *that*
one to pcapng_read_block(), so if it changes anything in the pcapng_t,
it changes the one we're using.
Change-Id: I53b32595276be97957a0b6056171471878fa40c4
Reviewed-on: https://code.wireshark.org/review/33226
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit 576f33fffd4384d869ae516aa3f346d2ce0b4c6b)
Reviewed-on: https://code.wireshark.org/review/33228
commit 38a48c3d5c4f997f0db576cdd0cf8eaa5cfda879
Author: Guy Harris <guy@alum.mit.edu>
Date: Wed May 15 18:25:42 2019 -0700
Keep and use per-interface, not per-file, FCS length information.
There is no FCS length information for a pcapng file; there's FCS length
information for each interface.
Change-Id: I3abb1a35b28475aa3ad6f126060140d0a524bbca
Reviewed-on: https://code.wireshark.org/review/33215
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit f8ac57a2c4d3b0bab160dc5da925c1bb83e39444)
Reviewed-on: https://code.wireshark.org/review/33218
commit 371fcaf019ec4433c9a287c1b02cd63b0ff0df0e
Author: Peter Wu <peter@lekensteyn.nl>
Date: Sat May 11 15:04:41 2019 +0100
Qt: do not expose a UAT record if the update callback fails
The default chk callbacks for individual fields only catches basic
errors such as invalid, too large numbers. Many dissectors perform
additional validation in the update_cb which is invoked for a record as
a whole. If this check fails, then the UAT must not be marked as valid
or else invalid records (like NULL pointers) could be exposed.
Thanks to Uli Heilmeier for noticing this.
Bug: 15709
Change-Id: I1cc4c6925322011a561ad6df840fbac67796e5b2
Fixes: v2.3.0rc0-1002-g1cd22559a8 ("Qt: convert UatDialog to model/view pattern, improve UX")
Reviewed-on: https://code.wireshark.org/review/33157
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Uli Heilmeier <openid@heilmeier.eu>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
(cherry picked from commit 7b43c480f6c2914e7d5fa69d78e69b0a50fed7c7)
Reviewed-on: https://code.wireshark.org/review/33210
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
commit 536eae48220e94f42739ef1461ffbde63d271f6f
Author: Gerald Combs <gerald@wireshark.org>
Date: Mon May 13 15:36:17 2019 -0700
mmdbresolve: Improve our main loop check.
Check the return value of fscanf() instead of relying on feof(). This
should help ensure that we exit correctly.
Bug: 15777
Change-Id: I8b5985f6015cb6a85378db5135b29bb2c3de1e90
Reviewed-on: https://code.wireshark.org/review/33196
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
(cherry picked from commit 276d62b639c2dbbe8ada823c2ca714daccbd0ce7)
Reviewed-on: https://code.wireshark.org/review/33207
commit 2ae17b88bcd915b07b6df01d6185b5e79045ac1b
Author: Guy Harris <guy@alum.mit.edu>
Date: Mon May 13 15:55:17 2019 -0700
Fix SMB2 decryption on big-endian machines.
Convert the host-endian session ID passed to seskey_find_sid_key()
before comparing it with the little-endian session IDs in the UAT.
While we're at it, tag session ID fields in various structures with the
byte order.
Bug: 15772
Change-Id: Ib1e7323bad1dfdb1ac24a08998205650f2744097
Reviewed-on: https://code.wireshark.org/review/33188
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit 3234152bec1d1245cc0a8288c9be90242e2a11ed)
Reviewed-on: https://code.wireshark.org/review/33190
commit c8b70ca98d5fa19a692e1d513f7d0a20689d08b4
Author: Guy Harris <guy@alum.mit.edu>
Date: Sun May 12 11:20:30 2019 -0700
Fix the length of the item added for the value field of undissected CLVs.
The length variable is the length of the value, not the length of the
entire CLV, so there's no need to subtract the length of the C and the
L from the length - it covers just the V.
Change-Id: I711657e4e0b76e2aac9d58efd88f45201b9c2c5b
Reviewed-on: https://code.wireshark.org/review/33174
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit beed21b038683377efb7b5c13b36a3a35fa720a2)
Reviewed-on: https://code.wireshark.org/review/33176
commit e9e42f7469cdee61b5643dfc52d3f3e6348fb907
Author: Gerald Combs <gerald@wireshark.org>
Date: Sun May 12 09:07:16 2019 +0000
[Automatic update for 2019-05-12]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: I9e9d7e64cd0a55fc5778c1d95a1403442e5ebfe0
Reviewed-on: https://code.wireshark.org/review/33164
Reviewed-by: Gerald Combs <gerald@wireshark.org>
![[bug history graph]](https://qa.debian.org/data/bts/graphs/w/wireshark.png){kind=link}