vcswatch reports that
this package seems to have new commits in its VCS but has
not yet updated debian/changelog. You should consider updating
the Debian changelog and uploading this new version into the archive.
Here are the relevant commit logs:
commit d09cd74c194258675ec13f5285f5f6c8d7be3841
Author: Barak A. Pearlmutter <barak+git@pearlmutter.net>
Date: Thu Dec 5 18:32:56 2019 +0000
remove upstreamed patch
commit 977c303885449a3b48abdbedc96476a9dac56ac4
Merge: 3a0c54b 9b730c7
Author: Barak A. Pearlmutter <barak+git@pearlmutter.net>
Date: Thu Dec 5 18:32:34 2019 +0000
Merge remote-tracking branch 'upstream/master' into debian
commit 9b730c721294db0df7c0b752994b9d255ef58479
Author: Marcus Edel <marcus.edel@fu-berlin.de>
Date: Thu Dec 5 19:24:40 2019 +0100
Move the latest update into a new block.
commit d7fda77f0fa369bcab9d2fafef3f55d4f939a6a7
Author: Marcus Edel <marcus.edel@fu-berlin.de>
Date: Thu Dec 5 19:19:43 2019 +0100
Update history.
commit d70b12a296da0b51227c2432a6d6b17878476b43
Merge: a7798de 176fbef
Author: Marcus Edel <marcus.edel@fu-berlin.de>
Date: Thu Dec 5 19:16:42 2019 +0100
Merge pull request #143 from barak/master
32-bit safety in big random number.
commit 3a0c54b9db5de4f9e6c4295e46c2bfd8fe4a17dc
Author: Barak A. Pearlmutter <barak+git@pearlmutter.net>
Date: Thu Dec 5 15:05:21 2019 +0000
can build w/o root
commit 176fbef576ba080b10c1259fd60848da2d460848
Author: Barak A. Pearlmutter <barak+git@pearlmutter.net>
Date: Thu Dec 5 14:30:42 2019 +0000
32-bit safety in big random number
This patch fixes a compile-time warning and test case failure on
32-bit architectures, including i386.
cd /<<PKGBUILDDIR>>/obj-i686-linux-gnu/tests && /usr/bin/c++ -I/<<PKGBUILDDIR>>/include -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fopenmp -Wall -Wpedantic -Wunused-parameter -std=gnu++11 -o CMakeFiles/ensmallen_tests.dir/cmaes_test.cpp.o -c /<<PKGBUILDDIR>>/tests/cmaes_test.cpp
/<<PKGBUILDDIR>>/tests/callbacks_test.cpp: In function ‘void ____C_A_T_C_H____T_E_S_T____46()’:
/<<PKGBUILDDIR>>/tests/callbacks_test.cpp:397:28: warning: unsigned conversion from ‘long long int’ to ‘size_t’ {aka ‘unsigned int’} changes value from ‘10000000000’ to ‘1410065408’ [-Woverflow]
397 | StandardSGD s(0.0003, 1, 10000000000, -10);
| ^~~~~~~~~~~
/<<PKGBUILDDIR>>/tests/callbacks_test.cpp: In function ‘void ____C_A_T_C_H____T_E_S_T____54()’:
/<<PKGBUILDDIR>>/tests/callbacks_test.cpp:473:28: warning: unsigned conversion from ‘long long int’ to ‘size_t’ {aka ‘unsigned int’} changes value from ‘10000000000’ to ‘1410065408’ [-Woverflow]
473 | StandardSGD s(0.0003, 1, 10000000000, -100, true);
| ^~~~~~~~~~~
...
Test project /<<PKGBUILDDIR>>/obj-i686-linux-gnu
Start 1: ensmallen_tests
1/1 Test #1: ensmallen_tests ..................***Failed 5163.40 sec
The SGD maxIterations parameter to the SGD routine is stored in a
size_t. Arguably inappropriate; it belongs in something guaranteed to
be at least 64 bits, perhaps long long int.
Be that as it may, a test routine was passing a number meant to be so
large it would not be exceeded, to test a mechanism that should
terminate the optimization early. The large number chosen was
10000000000, ten billion, which exceeds the maximum value of an
unsigned 32-bit integer of 4 billion plus change.
This patch changes the maxIterations parameter passed to two billion,
2000000000, which is both sufficiently large for the purposes here and
safely below the maximum value for a 32-bit signed integer.
![[bug history graph]](https://qa.debian.org/data/bts/graphs/e/ensmallen.png){kind=link}