In debian/watch no matching files for watch source https://gitlab.com/lava/lava/tags?sort=updated_desc
commit 4a3d9f63eb1970b17e9b1edf91376e282c53bf36
Merge: 86344c9b 4e8752d5
Author: Rémi Duraffort <remi.duraffort@linaro.org>
Date: Mon Oct 27 15:51:51 2025 +0000
Merge branch 'pylint-enable-W4701' into 'master'
pylint: Enable W4701 iterated list is being modified inside for loop body
See merge request lava/lava!3018
commit 86344c9b6ea34eaa96a3718a1fa71f02ebfe8f21
Merge: 5c04eb5c da9955b8
Author: Rémi Duraffort <remi.duraffort@linaro.org>
Date: Mon Oct 27 15:49:02 2025 +0000
Merge branch 'pylint-enable-r1735' into 'master'
pylint: Enable R1735 consider using {} instead of dict()
See merge request lava/lava!3017
commit 5c04eb5c6df67152ddebac510e0e690bbf342f45
Merge: f41ec2b6 506b5ab3
Author: Rémi Duraffort <remi.duraffort@linaro.org>
Date: Mon Oct 27 15:48:22 2025 +0000
Merge branch 'pylint-enable-r1701' into 'master'
pylint: Enable R1701 Consider merging these isinstance calls
See merge request lava/lava!3016
commit f41ec2b6c1b6f4444b86bc1a173d1eb062b93303
Merge: e3f4256b 8dd07200
Author: Rémi Duraffort <remi.duraffort@linaro.org>
Date: Mon Oct 27 15:48:03 2025 +0000
Merge branch 'pylint-enable-c0207' into 'master'
pylint: Enable C0207 use `.split(maxsplit=1)[0]` instead
See merge request lava/lava!3015
commit e3f4256b34f3390c4642e663733868e53a850705
Merge: 06099977 217fa90f
Author: Rémi Duraffort <remi.duraffort@linaro.org>
Date: Mon Oct 27 15:47:00 2025 +0000
Merge branch 'pylint-enable-w0706' into 'master'
pylint: Enable W0706 the except handler raises immediately
See merge request lava/lava!3014
commit 06099977521f46c525f4ec29b02ec1b0fe0eb449
Merge: 2ea11e81 66ecd043
Author: Rémi Duraffort <remi.duraffort@linaro.org>
Date: Mon Oct 27 15:46:26 2025 +0000
Merge branch 'pylint-enable-W0102' into 'master'
pylint: Enable W0102 Dangerous default value as argument
See merge request lava/lava!3024
commit 2ea11e815f6fe4696cc0f5d1d1212dea18c20f7a
Merge: bc4b724d 978c5ad9
Author: Rémi Duraffort <remi.duraffort@linaro.org>
Date: Mon Oct 27 15:44:07 2025 +0000
Merge branch 'pylint-enable-W0715' into 'master'
pylint: Enable W0715 Exception arguments suggest string formatting
See merge request lava/lava!3026
commit bc4b724d8813ce365c7dcb3cd132e5880d3d2242
Merge: 7775f64f 786e75ca
Author: Rémi Duraffort <remi.duraffort@linaro.org>
Date: Mon Oct 27 15:43:46 2025 +0000
Merge branch 'pylint-enable-W0640' into 'master'
pylint: Enable W0640 Cell variable defined in loop
See merge request lava/lava!3025
commit 7775f64f4ba0969976e9fe8d5d12aec41a5f74f8
Merge: b438c81d 50cb9292
Author: Rémi Duraffort <remi.duraffort@linaro.org>
Date: Mon Oct 27 15:43:06 2025 +0000
Merge branch 'shell-cmd-return-check' into 'master'
lava_dispatcher: allow to check returncode of the line sent to shell session
See merge request lava/lava!2957
commit 978c5ad92b878577d32d204845abb275726d72d5
Author: Igor Ponomarev <igor.ponomarev@collabora.com>
Date: Mon Oct 27 10:21:53 2025 +0000
pylint: Enable W0715 Exception arguments suggest string formatting
This warning was fixed in 8e7136ae7c0b796ffe198907a3ae7cb332e9b2f0
but pylint configuration was not updated.
commit 786e75ca0fc51bf3f04b758f659e594083bf071f
Author: Igor Ponomarev <igor.ponomarev@collabora.com>
Date: Mon Oct 27 09:46:15 2025 +0000
pylint: Enable W0640 Cell variable defined in loop
This warning is raised when a closure captures a loop variable.
The issue is that this loop variable will change while loop
is progressing leading to unexpected behavior.
commit 66ecd0433a40016dca301727d0566cf162c839f2
Author: Igor Ponomarev <igor.ponomarev@collabora.com>
Date: Mon Oct 27 09:14:53 2025 +0000
pylint: Enable W0102 Dangerous default value as argument
Using a mutable collection like `[]` or `{}` as a default argument
is dangerous because it will stay modified between function calls
which can have an unexpected behavior.
commit 4e8752d5b7b8eb0539fa741c9662ddf2fd790f65
Author: Igor Ponomarev <igor.ponomarev@collabora.com>
Date: Fri Oct 24 15:11:25 2025 +0100
pylint: Enable W4701 iterated list is being modified inside for loop body
This can result in unpredictable behavior:
https://andrewwegner.com/python-gotcha-modify-list-while-iterating.html
commit da9955b857a73a4160d04f2b77ac430046ba9b53
Author: Igor Ponomarev <igor.ponomarev@collabora.com>
Date: Fri Oct 24 14:57:35 2025 +0100
pylint: Enable R1735 consider using {} instead of dict()
Dictionaries literals are faster than function calls.
commit 506b5ab3b6b6d9967716b028e8c3e0c4ac891efe
Author: Igor Ponomarev <igor.ponomarev@collabora.com>
Date: Fri Oct 24 14:49:02 2025 +0100
pylint: Enable R1701 Consider merging these isinstance calls
`isinstance` accepts a sequence of classes as an argument which
can be used instead of chaining `isinstance` with `or`.
commit 8dd072009352de744b1816f6a19f0e7677ef66f4
Author: Igor Ponomarev <igor.ponomarev@collabora.com>
Date: Fri Oct 24 14:43:39 2025 +0100
pylint: Enable C0207 use `.split(maxsplit=1)[0]` instead
This reduces amount of strings parsed and allocated.
commit 217fa90fa08e78dd728ac91d2615f95bd0d3aae9
Author: Igor Ponomarev <igor.ponomarev@collabora.com>
Date: Fri Oct 24 14:38:21 2025 +0100
pylint: Enable W0706 the except handler raises immediately
This error gets raised if an except handler simply raises exception
again without doing any work.
commit b438c81d4a1eb24f6d7ef7fcdf27d2bb1365965b
Merge: 65039df1 d8d125ee
Author: Rémi Duraffort <remi.duraffort@linaro.org>
Date: Fri Oct 24 13:27:28 2025 +0000
Merge branch 'pylint-pyproject-toml-config' into 'master'
gitlab-ci: Move pylint configuration to pyproject.toml
See merge request lava/lava!2989
commit 65039df1a1bef2b8c72179b8b20786f162b4d148
Merge: 59b52f60 b22a97e3
Author: Rémi Duraffort <remi.duraffort@linaro.org>
Date: Fri Oct 24 13:26:55 2025 +0000
Merge branch 'management-commands-no-print' into 'master'
Avoid using `print` in management commands
See merge request lava/lava!3000
commit 59b52f602a5d616ad395204de01a6b3ae809f64a
Merge: 58f5f49d f282e225
Author: Rémi Duraffort <remi.duraffort@linaro.org>
Date: Fri Oct 24 13:26:19 2025 +0000
Merge branch 'fix-nodebooter-docker-network-call' into 'master'
Fix RunNodebooterContainer incorrectly using DockerRun.network
See merge request lava/lava!3008
commit 58f5f49dc944c9353a14ea922fa9805e8b24f140
Merge: 4565fafa a2d6a6cc
Author: Rémi Duraffort <remi.duraffort@linaro.org>
Date: Fri Oct 24 13:06:53 2025 +0000
Merge branch 'test-runscript-overlay-use-posix-expansion' into 'master'
Use POSIX `$(...)` notation instead of backticks in TestRunnerAction
See merge request lava/lava!2982
commit 4565fafa8009bad4e9fd028924ac5afd859249f3
Merge: ea8636d2 ca5582fd
Author: Rémi Duraffort <remi.duraffort@linaro.org>
Date: Fri Oct 24 13:05:11 2025 +0000
Merge branch 'ui_health_reason' into 'master'
ui: show latest health reason on top of device page
See merge request lava/lava!2997
commit a2d6a6cc69da10c5dabc157e284c17f2a1a7410f
Author: Igor Ponomarev <igor.ponomarev@collabora.com>
Date: Mon Sep 29 15:05:42 2025 +0100
Use POSIX `$(...)` notation instead of backticks in TestRunnerAction
The backticks is an outdated way of doing shell substitution
that might not be supported on all the shells. The `$(...)` is
a standardized. For example, PowerShell only supports the new
syntax but not backticks.
https://www.shellcheck.net/wiki/SC2006
commit d8d125ee789c58566d9d80ef2acefc4c9003d18c
Author: Igor Ponomarev <igor.ponomarev@collabora.com>
Date: Mon Oct 6 16:35:44 2025 +0100
gitlab-ci: Move pylint configuration to pyproject.toml
TOML supports multiline inline comments unlike shell. This makes
it easier to document which flags are enabled and which are not.
Instead of disabling everything and then enabling some checks
disable check one by one. This makes it easy to enable them one
by one in the future.
Add `init-hook` to fix Django's AppRegistryNotReady. For some
reason the `pylint_django` plugin does not properly call
`django.setup()`.
Switch to `server-debian-13` image because pylint has to import
everything when it is run.
commit f282e22576710f7146d8a04840c2228db7e68970
Author: Igor Ponomarev <igor.ponomarev@collabora.com>
Date: Tue Oct 21 11:26:47 2025 +0100
Fix RunNodebooterContainer incorrectly using DockerRun.network
`DockerRun.network` is a method that should be called but
`RunNodebooterContainer.run` assigned it as an attribute.
This confused pylint where it would sometimes decide that `network`
was not a callable even though it is.
commit b22a97e30e6886724789b1f1e72d203378236e77
Author: Igor Ponomarev <igor.ponomarev@collabora.com>
Date: Mon Oct 13 16:14:53 2025 +0100
Avoid using `print` in management commands
Use Django provided `self.stdout.write` and `self.stderr.write`.
Using those functions is recommended over `print` because it
makes it easier to test the commands.
https://docs.djangoproject.com/en/5.2/howto/custom-management-commands/
commit ea8636d21174e7521c66bfad997df302af121ce0
Merge: fe33d484 b1d739f0
Author: Rémi Duraffort <remi.duraffort@linaro.org>
Date: Mon Oct 20 18:41:57 2025 +0000
Merge branch 'fix-device-type-details-last-job-column' into 'master'
Fix Last Job column not working on Devices table on device type page
See merge request lava/lava!3005
commit fe33d484c19ad029bebddb9b7e3baa3721647e5d
Merge: 2736bf25 f921f25a
Author: Rémi Duraffort <remi.duraffort@linaro.org>
Date: Mon Oct 20 18:40:26 2025 +0000
Merge branch 'health_reason' into 'master'
xmlrpc: add reason of health change
See merge request lava/lava!2996
commit 2736bf25c7178316783e15e69987849fa706eb92
Merge: b82eca66 4c0c2cd0
Author: Rémi Duraffort <remi.duraffort@linaro.org>
Date: Mon Oct 20 18:38:37 2025 +0000
Merge branch 'lava-server-commands-job-use-fstrings' into 'master'
Use f-strings in lava_server/management/commands/jobs.py
See merge request lava/lava!2999
commit b82eca6680e6b53e8f090c302a90833fa58e6bad
Merge: 92afcfaa bd5fd668
Author: Rémi Duraffort <remi.duraffort@linaro.org>
Date: Mon Oct 20 18:37:24 2025 +0000
Merge branch 'fix-device-dict-plain-no-authorization' into 'master'
Fix some views missing permission check
See merge request lava/lava!3006
commit bd5fd668458c5562c12265b5e33118fab42af130
Author: Igor Ponomarev <igor.ponomarev@collabora.com>
Date: Fri Oct 17 13:14:43 2025 +0100
Fix some views missing permission check
Add `can_view` permission check to following views:
* Plain device dictionary download
* Device health check list
* Worker details
commit b1d739f044c0f6e9f3c1de7548f50edcc8783020
Author: Igor Ponomarev <igor.ponomarev@collabora.com>
Date: Thu Oct 16 11:42:54 2025 +0100
Fix Last Job column not working on Devices table on device type page
The issue is that `DTDeviceView` was using a copy pasted code
from its parent class `DeviceTableView`. When a new column was
added in 4f3e583cc96f25c5d11b619bd0f45c10ef285e32 the `DTDeviceView`
was not updated. This resulted in column always being blank and
also crasing if a sort by it was attempted.
To fix this use `super()` instead of copy pasted code. Comparing
side by side it seems like the only difference was that retired
devices were excluded.
Revert 2845fbf351e1d04f47e15cd19caa69a8bd20bef6 as order by now
works correctly.
Thanks to @chase-qi for providing the error logs.
commit 4c0c2cd03018149394f1fcec5a226530a4203dcb
Author: Igor Ponomarev <igor.ponomarev@collabora.com>
Date: Mon Oct 13 15:59:40 2025 +0100
Use f-strings in lava_server/management/commands/jobs.py
This is a more modern approach to string formatting. It forces
the values to string which fixes pylint warnings.
commit 92afcfaa09f68deeac87694cebd6c4fc18af4f1d
Merge: 2df0865a 8e7136ae
Author: Rémi Duraffort <remi.duraffort@linaro.org>
Date: Tue Oct 14 14:49:05 2025 +0000
Merge branch 'fix-usbgms-strategy-exception-formatting' into 'master'
Fix USBGMS deploy strategy exception formatting not working
See merge request lava/lava!3001
commit 2df0865a139dbb2e9b36a0a85aef69087e8e7d7f
Merge: 140881a8 c230e24c
Author: Rémi Duraffort <remi.duraffort@linaro.org>
Date: Tue Oct 14 14:48:47 2025 +0000
Merge branch 'tests-remove-unused-test-shell-results' into 'master'
tests: Remove unused TestShellResults class
See merge request lava/lava!3002
commit 140881a84d105d75ff875131d79ae16274640bc7
Merge: 31acf177 8d18469f
Author: Rémi Duraffort <remi.duraffort@linaro.org>
Date: Tue Oct 14 14:48:33 2025 +0000
Merge branch 'tests-test-pipeline-remove-statement-with-no-effect' into 'master'
tests: Remove statement with no effect in test_vlan_interface
See merge request lava/lava!3003
commit 8d18469ff9227ba2cf138dee429964ace031d21f
Author: Igor Ponomarev <igor.ponomarev@collabora.com>
Date: Tue Oct 14 13:43:34 2025 +0100
tests: Remove statement with no effect in test_vlan_interface
Found during pylint configuration revamp.
commit 8e7136ae7c0b796ffe198907a3ae7cb332e9b2f0
Author: Igor Ponomarev <igor.ponomarev@collabora.com>
Date: Mon Oct 13 16:22:04 2025 +0100
Fix USBGMS deploy strategy exception formatting not working
The exception string contained the `%s` specifier but `%` was
never called on it. Convert it to f-string to properly format it.
Found during pylint configuration revamp.
commit c230e24c0b31c499deeb615d3ddcaa42b25c308d
Author: Igor Ponomarev <igor.ponomarev@collabora.com>
Date: Mon Oct 13 14:36:02 2025 +0100
tests: Remove unused TestShellResults class
This class has no tests in its body or used anywhere else.
It also has an error in `FakeAction` which where super init
is called without job.
commit 31acf177e1404aedeccab6a01d1cf685bcbb18a7
Merge: 9e85a8c8 0d841790
Author: Rémi Duraffort <remi.duraffort@linaro.org>
Date: Mon Oct 13 13:09:27 2025 +0000
Merge branch 'fix-nodebooter-docker-run-use-keyword' into 'master'
Properly fix DockerRun.run call missing action arg in RunNodebooterContainer
See merge request lava/lava!2998
commit 0d841790ae3d672bf24b9127cf7786f4831d92af
Author: Igor Ponomarev <igor.ponomarev@collabora.com>
Date: Mon Oct 13 14:02:21 2025 +0100
Properly fix DockerRun.run call missing action arg in RunNodebooterContainer
The 6b89706d85d699e683ce8695c1fe16932a3cfdff does not work correctly
because `DockerRun.run` has `*args` argument which forces `action`
argument to be keyword only.
commit 9e85a8c87bfbd4bae9b1b49b35fc1798dd714ce6
Merge: cde1995f 76452a83
Author: Rémi Duraffort <remi.duraffort@linaro.org>
Date: Mon Oct 13 12:52:48 2025 +0000
Merge branch 'fix-configure-nodebooter-errors-call' into 'master'
Fix ConfigureNodebooter incorrectly using errors attribute
See merge request lava/lava!2995
commit cde1995f5dd1779f2d322ca0931e2a50812b6c0f
Merge: a083100b 6b89706d
Author: Rémi Duraffort <remi.duraffort@linaro.org>
Date: Mon Oct 13 12:51:49 2025 +0000
Merge branch 'fix-nodebooter-docker-run-missing-argument' into 'master'
Fix DockerRun.run call missing action arg in RunNodebooterContainer
See merge request lava/lava!2993
commit a083100beaa0c99f546802cd94d37cd632ce6d05
Merge: a92feb70 c51bca0b
Author: Rémi Duraffort <remi.duraffort@linaro.org>
Date: Mon Oct 13 12:50:33 2025 +0000
Merge branch 'fix-ssh-session-too-many-args' into 'master'
Fix SShSession being called with too many args
See merge request lava/lava!2994
commit ca5582fd1d6367e7504133cdd3b0430e4cae185f
Author: Larry Shen <larry.shen@nxp.com>
Date: Mon Oct 13 16:58:59 2025 +0900
ui: show latest health reason on top of device page
Signed-off-by: Larry Shen <larry.shen@nxp.com>
commit f921f25a5e2c3584399fcc261d34e88facf5debf
Author: Larry Shen <larry.shen@nxp.com>
Date: Mon Oct 13 11:35:25 2025 +0900
xmlrpc: add reason of health change
Function align with ui operation and rest api
Signed-off-by: Larry Shen <larry.shen@nxp.com>
commit 76452a83b81e728d3cf529648fd4d3bb9c501ff2
Author: Igor Ponomarev <igor.ponomarev@collabora.com>
Date: Fri Oct 10 16:37:59 2025 +0100
Fix ConfigureNodebooter incorrectly using errors attribute
It called the attribute instead of assigning to it. This would raise
an error as the `list` class is not callable.
Equivalent to 169c1970ec66501e32004c91183a97140d794609.
commit c51bca0be4ac6f75c81034a606def3743fd8dc96
Author: Igor Ponomarev <igor.ponomarev@collabora.com>
Date: Fri Oct 10 15:43:46 2025 +0100
Fix SShSession being called with too many args
The 44ae771fcbb7ea73a8357c10fa114e7d11ef4c96 removed unused
`job` argument from ShellSession but not all subclasses were
updated.
Found during pylint configuration revamp.
commit 6b89706d85d699e683ce8695c1fe16932a3cfdff
Author: Igor Ponomarev <igor.ponomarev@collabora.com>
Date: Fri Oct 10 15:17:59 2025 +0100
Fix DockerRun.run call missing action arg in RunNodebooterContainer
After 413beac5030dbff6275c645301b7541cbf12703c the `action` argument
is required but RunNodebooterContainer was not updated. The fix
is to simply pass `self` as the action.
commit 50cb929222f7bfedd6c386ba2a3b0cf66cd48880
Author: Chase Qi <chase.qi@linaro.org>
Date: Sun Sep 14 08:29:06 2025 +0000
lava_dispatcher: check if overlay deployed correctly
Signed-off-by: Chase Qi <chase.qi@linaro.org>
commit cec19ed8b1f16490b78f3221ab4c6194cac77b0c
Author: Chase Qi <chase.qi@linaro.org>
Date: Sun Sep 14 08:26:18 2025 +0000
lava_dispatcher: allow to check returncode of the line sent to shell session
Signed-off-by: Chase Qi <chase.qi@linaro.org>
Among the 1 debian patch available in version 2024.09-1.1 of the package, we noticed the following issues:
![[bug history graph]](https://qa.debian.org/data/bts/graphs/l/lava.png){kind=link}